[commits] Horde branch master updated. 523c443e56beca76735ef0356f447995c04cab9a
Gunnar Wrobel
p at rdus.de
Wed Nov 4 15:18:47 UTC 2009
The branch "master" has been updated.
The following is a summary of the commits.
from: 73a97eb03d608d29ec6270c46a24f16b31c5267d
9215415 Reduce the functionality of the kolab authentication driver. Some functionality should be readded as decorators.
d632485 Typo.
c346547 Clarify error.
17e82be Added testing for the Kolab auth driver.
16b18fe Add a stub method for abstract _authenticate() throwing a "Not implemented" error. Otherwise the classes are not useable.
1e92094 The parent class declares this as public.
04c70bc Indicate that binding failed.
53a71b0 Return the correct attribute value.
412783b Return an object decorated with the hash decorator.
80c9f36 Fix constructor. Add todo. Use array_shift instead of array_pop.
82f8810 Correct the attribute definitions.
39c32f7 Correct the attribute definitions.
9d6d41a Hash.php was missing.
8a3293a Correct retrieving user attributes.
523c443 Adapt testing.
-----------------------------------------------------------------------
commit 9215415163beea38ca926d04f3d945615c6cd903
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 12:10:47 2009 +0100
Reduce the functionality of the kolab authentication driver. Some functionality should be readded as decorators.
framework/Auth/lib/Horde/Auth/Kolab.php | 242 ++---
.../Kolab_Server/lib/Horde/Kolab/Server/Exception/Bindfailed.php | 30 +
framework/Kolab_Server/lib/Horde/Kolab/Server/Ldap.php | 7 +-
framework/Kolab_Server/package.xml | 2 +
framework/Kolab_Session/lib/Horde/Kolab/Session/Base.php | 3 +
.../Kolab_Session/lib/Horde/Kolab/Session/Exception/Badlogin.php | 30 +
framework/Kolab_Session/package.xml | 4 +
7 files changed, 190 insertions(+), 128 deletions(-)
create mode 100644 framework/Kolab_Server/lib/Horde/Kolab/Server/Exception/Bindfailed.php
create mode 100644 framework/Kolab_Session/lib/Horde/Kolab/Session/Exception/Badlogin.php
http://git.horde.org/diff.php/framework/Auth/lib/Horde/Auth/Kolab.php?rt=horde-git&r1=41230b7ca22ad383ce0f4273a08c74a6a55932ef&r2=9215415163beea38ca926d04f3d945615c6cd903
http://git.horde.org/co.php/framework/Kolab_Server/lib/Horde/Kolab/Server/Exception/Bindfailed.php?rt=horde-git&r=9215415163beea38ca926d04f3d945615c6cd903
http://git.horde.org/diff.php/framework/Kolab_Server/lib/Horde/Kolab/Server/Ldap.php?rt=horde-git&r1=a005fd6ede20332cacf84c9ab9552f12a10b38c4&r2=9215415163beea38ca926d04f3d945615c6cd903
http://git.horde.org/diff.php/framework/Kolab_Server/package.xml?rt=horde-git&r1=4f8974460e67ac64df97fd29a9377b1b4e822236&r2=9215415163beea38ca926d04f3d945615c6cd903
http://git.horde.org/diff.php/framework/Kolab_Session/lib/Horde/Kolab/Session/Base.php?rt=horde-git&r1=73a97eb03d608d29ec6270c46a24f16b31c5267d&r2=9215415163beea38ca926d04f3d945615c6cd903
http://git.horde.org/co.php/framework/Kolab_Session/lib/Horde/Kolab/Session/Exception/Badlogin.php?rt=horde-git&r=9215415163beea38ca926d04f3d945615c6cd903
http://git.horde.org/diff.php/framework/Kolab_Session/package.xml?rt=horde-git&r1=73a97eb03d608d29ec6270c46a24f16b31c5267d&r2=9215415163beea38ca926d04f3d945615c6cd903
-----------------------------------------------------------------------
commit d6324854116d8728f2eab46eb82f936da7b72ffc
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 12:55:11 2009 +0100
Typo.
framework/Kolab_Session/lib/Horde/Kolab/Session/Base.php | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/Kolab_Session/lib/Horde/Kolab/Session/Base.php?rt=horde-git&r1=9215415163beea38ca926d04f3d945615c6cd903&r2=d6324854116d8728f2eab46eb82f936da7b72ffc
-----------------------------------------------------------------------
commit c346547c9635ace5363c443866dc539175fdd625
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 12:55:35 2009 +0100
Clarify error.
.../lib/Horde/Kolab/Session/Factory/Configuration.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/Kolab_Session/lib/Horde/Kolab/Session/Factory/Configuration.php?rt=horde-git&r1=60dc4ba165106be8d7f94208d5007798b81b0e2d&r2=c346547c9635ace5363c443866dc539175fdd625
-----------------------------------------------------------------------
commit 17e82bea3c1755bf3905ab1888c1ebd982baf09d
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 15:41:17 2009 +0100
Added testing for the Kolab auth driver.
framework/Auth/lib/Horde/Auth/Kolab.php | 66 ++++-
framework/Auth/test/Horde/Auth/Kolab/Autoload.php | 53 +--
framework/Auth/test/Horde/Auth/Kolab/Class/KolabTest.php | 144 ++++++++
framework/Auth/test/Horde/Auth/Kolab/Integration/AuthTest.php | 152 +++++++++
framework/Auth/test/Horde/Auth/Kolab/KolabScenarioTest.php | 58 ----
framework/Auth/test/Horde/Auth/Kolab/KolabTest.php | 92 -----
framework/Auth/test/Horde/Auth/Kolab/Scenario.php | 121 -------
framework/Auth/test/Horde/Auth/phpunit.xml | 8 +
8 files changed, 382 insertions(+), 312 deletions(-)
create mode 100644 framework/Auth/test/Horde/Auth/Kolab/Class/KolabTest.php
create mode 100644 framework/Auth/test/Horde/Auth/Kolab/Integration/AuthTest.php
delete mode 100644 framework/Auth/test/Horde/Auth/Kolab/KolabScenarioTest.php
delete mode 100644 framework/Auth/test/Horde/Auth/Kolab/KolabTest.php
delete mode 100644 framework/Auth/test/Horde/Auth/Kolab/Scenario.php
create mode 100644 framework/Auth/test/Horde/Auth/phpunit.xml
http://git.horde.org/diff.php/framework/Auth/lib/Horde/Auth/Kolab.php?rt=horde-git&r1=9215415163beea38ca926d04f3d945615c6cd903&r2=17e82bea3c1755bf3905ab1888c1ebd982baf09d
http://git.horde.org/diff.php/framework/Auth/test/Horde/Auth/Kolab/Autoload.php?rt=horde-git&r1=e84cb0a7062410e94d16c027309abb954e854ca4&r2=17e82bea3c1755bf3905ab1888c1ebd982baf09d
http://git.horde.org/co.php/framework/Auth/test/Horde/Auth/Kolab/Class/KolabTest.php?rt=horde-git&r=17e82bea3c1755bf3905ab1888c1ebd982baf09d
http://git.horde.org/co.php/framework/Auth/test/Horde/Auth/Kolab/Integration/AuthTest.php?rt=horde-git&r=17e82bea3c1755bf3905ab1888c1ebd982baf09d
http://git.horde.org/diff.php/framework/Auth/test/Horde/Auth/Kolab/KolabScenarioTest.php?rt=horde-git&r1=e987cf7faf0f760844882a0a67eb8122ccb3eb28&r2=17e82bea3c1755bf3905ab1888c1ebd982baf09d
http://git.horde.org/diff.php/framework/Auth/test/Horde/Auth/Kolab/KolabTest.php?rt=horde-git&r1=e987cf7faf0f760844882a0a67eb8122ccb3eb28&r2=17e82bea3c1755bf3905ab1888c1ebd982baf09d
http://git.horde.org/diff.php/framework/Auth/test/Horde/Auth/Kolab/Scenario.php?rt=horde-git&r1=e987cf7faf0f760844882a0a67eb8122ccb3eb28&r2=17e82bea3c1755bf3905ab1888c1ebd982baf09d
http://git.horde.org/co.php/framework/Auth/test/Horde/Auth/phpunit.xml?rt=horde-git&r=17e82bea3c1755bf3905ab1888c1ebd982baf09d
-----------------------------------------------------------------------
commit 16b18fe40860eeccaf9326bea4030b52edaf9ce6
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 15:47:23 2009 +0100
Add a stub method for abstract _authenticate() throwing a "Not implemented" error. Otherwise the classes are not useable.
framework/Auth/lib/Horde/Auth/Cyrus.php | 17 +++++++++++++++++
framework/Auth/lib/Horde/Auth/Ipbasic.php | 17 +++++++++++++++++
framework/Auth/lib/Horde/Auth/Shibboleth.php | 17 +++++++++++++++++
3 files changed, 51 insertions(+), 0 deletions(-)
http://git.horde.org/diff.php/framework/Auth/lib/Horde/Auth/Cyrus.php?rt=horde-git&r1=ff024158c54a59ec21602e720043c8be403bf74c&r2=16b18fe40860eeccaf9326bea4030b52edaf9ce6
http://git.horde.org/diff.php/framework/Auth/lib/Horde/Auth/Ipbasic.php?rt=horde-git&r1=83ba16e6c0ec3c989eab0a81fcda06978ddef8a1&r2=16b18fe40860eeccaf9326bea4030b52edaf9ce6
http://git.horde.org/diff.php/framework/Auth/lib/Horde/Auth/Shibboleth.php?rt=horde-git&r1=e33cb59708e5f5d6767407d946b997a1aa8e3a68&r2=16b18fe40860eeccaf9326bea4030b52edaf9ce6
-----------------------------------------------------------------------
commit 1e92094e7b49ff4e793beaa146e33160230b514f
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 15:47:45 2009 +0100
The parent class declares this as public.
framework/Auth/lib/Horde/Auth/Cyrsql.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/Auth/lib/Horde/Auth/Cyrsql.php?rt=horde-git&r1=ff024158c54a59ec21602e720043c8be403bf74c&r2=1e92094e7b49ff4e793beaa146e33160230b514f
-----------------------------------------------------------------------
commit 04c70bcff0365c8c3be6bd81c75f460d18776828
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 16:16:23 2009 +0100
Indicate that binding failed.
.../Kolab_Server/lib/Horde/Kolab/Server/Connection/Mock/Ldap.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/Kolab_Server/lib/Horde/Kolab/Server/Connection/Mock/Ldap.php?rt=horde-git&r1=6a2a0405ba7a7876ecad29a9981cfd95282869b9&r2=04c70bcff0365c8c3be6bd81c75f460d18776828
-----------------------------------------------------------------------
commit 53a71b0f8acc36fcbfbc1b0a51666fa551bc2e56
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 16:16:53 2009 +0100
Return the correct attribute value.
.../lib/Horde/Kolab/Server/Object/Attribute/Value.php | 7 ++++-
1 files changed, 6 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/Kolab_Server/lib/Horde/Kolab/Server/Object/Attribute/Value.php?rt=horde-git&r1=4f8974460e67ac64df97fd29a9377b1b4e822236&r2=53a71b0f8acc36fcbfbc1b0a51666fa551bc2e56
-----------------------------------------------------------------------
commit 412783b5e2aa6957575e5dc4b5f999d9b7397b39
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 16:17:20 2009 +0100
Return an object decorated with the hash decorator.
framework/Kolab_Server/lib/Horde/Kolab/Server/Object/Factory.php | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
http://git.horde.org/diff.php/framework/Kolab_Server/lib/Horde/Kolab/Server/Object/Factory.php?rt=horde-git&r1=cfb6433d649687e426181162b1ff503e93bcc2f2&r2=412783b5e2aa6957575e5dc4b5f999d9b7397b39
-----------------------------------------------------------------------
commit 80c9f36981d57d06917e35575d2e9baa125c67f7
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 16:17:51 2009 +0100
Fix constructor. Add todo. Use array_shift instead of array_pop.
framework/Kolab_Server/lib/Horde/Kolab/Server/Object/Hash.php | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
http://git.horde.org/diff.php/framework/Kolab_Server/lib/Horde/Kolab/Server/Object/Hash.php?rt=horde-git&r1=4f8974460e67ac64df97fd29a9377b1b4e822236&r2=80c9f36981d57d06917e35575d2e9baa125c67f7
-----------------------------------------------------------------------
commit 82f881085355fb11e35bc36e46c3f4c91c9b1d0a
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 16:18:08 2009 +0100
Correct the attribute definitions.
.../Kolab_Server/lib/Horde/Kolab/Server/Object/Inetorgperson.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/Kolab_Server/lib/Horde/Kolab/Server/Object/Inetorgperson.php?rt=horde-git&r1=4f8974460e67ac64df97fd29a9377b1b4e822236&r2=82f881085355fb11e35bc36e46c3f4c91c9b1d0a
-----------------------------------------------------------------------
commit 39c32f788657c79d48abe4a58401ba3df875fa9d
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 16:18:21 2009 +0100
Correct the attribute definitions.
.../lib/Horde/Kolab/Server/Object/Kolabinetorgperson.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/Kolab_Server/lib/Horde/Kolab/Server/Object/Kolabinetorgperson.php?rt=horde-git&r1=4f8974460e67ac64df97fd29a9377b1b4e822236&r2=39c32f788657c79d48abe4a58401ba3df875fa9d
-----------------------------------------------------------------------
commit 9d6d41a2ec98d6a2ba21b8daa34c64f51aae27ad
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 16:18:31 2009 +0100
Hash.php was missing.
framework/Kolab_Server/package.xml | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
http://git.horde.org/diff.php/framework/Kolab_Server/package.xml?rt=horde-git&r1=9215415163beea38ca926d04f3d945615c6cd903&r2=9d6d41a2ec98d6a2ba21b8daa34c64f51aae27ad
-----------------------------------------------------------------------
commit 8a3293a9aca277d4f89ecadb4ebda722080a01de
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 16:18:47 2009 +0100
Correct retrieving user attributes.
framework/Kolab_Session/lib/Horde/Kolab/Session/Base.php | 18 +++++++-------
1 files changed, 9 insertions(+), 9 deletions(-)
http://git.horde.org/diff.php/framework/Kolab_Session/lib/Horde/Kolab/Session/Base.php?rt=horde-git&r1=d6324854116d8728f2eab46eb82f936da7b72ffc&r2=8a3293a9aca277d4f89ecadb4ebda722080a01de
-----------------------------------------------------------------------
commit 523c443e56beca76735ef0356f447995c04cab9a
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 16:18:55 2009 +0100
Adapt testing.
.../test/Horde/Kolab/Server/Class/Server/LdapTest.php | 13 +
.../Kolab_Session/test/Horde/Kolab/Session/Class/BaseTest.php | 131 +++--
.../test/Horde/Kolab/Session/Class/Factory/ConfigurationTest.php | 2 +-
.../test/Horde/Kolab/Session/Integration/AnonymousTest.php | 9 +-
.../test/Horde/Kolab/Session/Integration/ValidTest.php | 39 +-
5 files changed, 121 insertions(+), 73 deletions(-)
http://git.horde.org/diff.php/framework/Kolab_Server/test/Horde/Kolab/Server/Class/Server/LdapTest.php?rt=horde-git&r1=a005fd6ede20332cacf84c9ab9552f12a10b38c4&r2=523c443e56beca76735ef0356f447995c04cab9a
http://git.horde.org/diff.php/framework/Kolab_Session/test/Horde/Kolab/Session/Class/BaseTest.php?rt=horde-git&r1=cfb6433d649687e426181162b1ff503e93bcc2f2&r2=523c443e56beca76735ef0356f447995c04cab9a
http://git.horde.org/diff.php/framework/Kolab_Session/test/Horde/Kolab/Session/Class/Factory/ConfigurationTest.php?rt=horde-git&r1=cfb6433d649687e426181162b1ff503e93bcc2f2&r2=523c443e56beca76735ef0356f447995c04cab9a
http://git.horde.org/diff.php/framework/Kolab_Session/test/Horde/Kolab/Session/Integration/AnonymousTest.php?rt=horde-git&r1=cfb6433d649687e426181162b1ff503e93bcc2f2&r2=523c443e56beca76735ef0356f447995c04cab9a
http://git.horde.org/diff.php/framework/Kolab_Session/test/Horde/Kolab/Session/Integration/ValidTest.php?rt=horde-git&r1=cfb6433d649687e426181162b1ff503e93bcc2f2&r2=523c443e56beca76735ef0356f447995c04cab9a
More information about the commits
mailing list