[commits] Horde branch master updated. 897b3a7ad14dd8c08ec459ba3381d0e1b532556e
Gunnar Wrobel
p at rdus.de
Thu Nov 5 06:07:26 UTC 2009
The branch "master" has been updated.
The following is a summary of the commits.
from: 523c443e56beca76735ef0356f447995c04cab9a
b79ad0b Added a test suite for the Notification package. Coverage is about 90% and primarily excludes sections that rely heavily on global scope (Horde_Registry, Horde_Nls, Horde_Auth, Horde_Alarm).
d000d80 Splitted off the Horde_Notification_Storage interface and added the Horde_Notification_Storage_Session class implementing this interface.
7ee1472 Fix typo. getMessage() in the mobile listener should delegate to getMessage() instead of notify() in the status listener if no mobile handler is set.
3b59009 Moved the core part from Horde_Notification into different Horde_Notification_Handler classes. Added unit testing.
cd3fedd Fix package name.
7526f22 Use Horde_String.
36ed961 Be more relaxed on the params argument.
8f39f7b Clarify that these are interfaces by renaming them to Interface.php.
f6bf80b Add another hierarchy level for decorators to indicate their function.
4ab58d6 Fix clearing the message stacks.
7b16317 Do not use ArrayAccess so that we can fetch message stacks by reference.
12581d8 Do not dereference otherwise the fix does not help :)
7541e80 Do not pass the option array by reference.
897b3a7 Merge branch 'refactor-Notification'
-----------------------------------------------------------------------
commit b79ad0b268c3cddb46fec53529feda2e1d128c87
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Oct 27 17:47:49 2009 +0100
Added a test suite for the Notification package. Coverage is about 90%
and primarily excludes sections that rely heavily on global scope
(Horde_Registry, Horde_Nls, Horde_Auth, Horde_Alarm).
framework/Notification/package.xml | 35 +-
framework/Notification/test/Horde/Notification/AllTests.php | 85 ++
framework/Notification/test/Horde/Notification/Autoload.php | 28 +
.../test/Horde/Notification/Class/Notification/EventTest.php | 60 +
.../Horde/Notification/Class/Notification/Listener/AudioTest.php | 62 +
.../Notification/Class/Notification/Listener/JavascriptTest.php | 105 ++
.../Horde/Notification/Class/Notification/Listener/MobileTest.php | 120 ++
.../Horde/Notification/Class/Notification/Listener/StatusTest.php | 126 ++
.../test/Horde/Notification/Class/Notification/ListenerTest.php | 225 ++++
.../test/Horde/Notification/Class/NotificationTest.php | 254 +++++
framework/Notification/test/Horde/Notification/phpunit.xml | 8 +
11 files changed, 1107 insertions(+), 1 deletions(-)
create mode 100644 framework/Notification/test/Horde/Notification/AllTests.php
create mode 100644 framework/Notification/test/Horde/Notification/Autoload.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/EventTest.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Listener/AudioTest.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Listener/JavascriptTest.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Listener/MobileTest.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Listener/StatusTest.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/ListenerTest.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/NotificationTest.php
create mode 100644 framework/Notification/test/Horde/Notification/phpunit.xml
http://git.horde.org/diff.php/framework/Notification/package.xml?rt=horde-git&r1=a06e46506f19765aed445e68cc63179f4f7a51f4&r2=b79ad0b268c3cddb46fec53529feda2e1d128c87
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/AllTests.php?rt=horde-git&r=b79ad0b268c3cddb46fec53529feda2e1d128c87
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Autoload.php?rt=horde-git&r=b79ad0b268c3cddb46fec53529feda2e1d128c87
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/EventTest.php?rt=horde-git&r=b79ad0b268c3cddb46fec53529feda2e1d128c87
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/AudioTest.php?rt=horde-git&r=b79ad0b268c3cddb46fec53529feda2e1d128c87
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/JavascriptTest.php?rt=horde-git&r=b79ad0b268c3cddb46fec53529feda2e1d128c87
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/MobileTest.php?rt=horde-git&r=b79ad0b268c3cddb46fec53529feda2e1d128c87
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/StatusTest.php?rt=horde-git&r=b79ad0b268c3cddb46fec53529feda2e1d128c87
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/ListenerTest.php?rt=horde-git&r=b79ad0b268c3cddb46fec53529feda2e1d128c87
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/NotificationTest.php?rt=horde-git&r=b79ad0b268c3cddb46fec53529feda2e1d128c87
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/phpunit.xml?rt=horde-git&r=b79ad0b268c3cddb46fec53529feda2e1d128c87
-----------------------------------------------------------------------
commit d000d80252fb52aa5fcac0c718cbbcec08f5762f
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Oct 27 18:51:09 2009 +0100
Splitted off the Horde_Notification_Storage interface and added the
Horde_Notification_Storage_Session class implementing this interface.
framework/Notification/lib/Horde/Notification.php | 49 +-
framework/Notification/lib/Horde/Notification/Storage.php | 39 ++
framework/Notification/lib/Horde/Notification/Storage/Session.php | 113 +++++
framework/Notification/package.xml | 6 +
.../test/Horde/Notification/Class/NotificationTest.php | 3 +-
5 files changed, 184 insertions(+), 26 deletions(-)
create mode 100644 framework/Notification/lib/Horde/Notification/Storage.php
create mode 100644 framework/Notification/lib/Horde/Notification/Storage/Session.php
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification.php?rt=horde-git&r1=a06e46506f19765aed445e68cc63179f4f7a51f4&r2=d000d80252fb52aa5fcac0c718cbbcec08f5762f
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Storage.php?rt=horde-git&r=d000d80252fb52aa5fcac0c718cbbcec08f5762f
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Storage/Session.php?rt=horde-git&r=d000d80252fb52aa5fcac0c718cbbcec08f5762f
http://git.horde.org/diff.php/framework/Notification/package.xml?rt=horde-git&r1=b79ad0b268c3cddb46fec53529feda2e1d128c87&r2=d000d80252fb52aa5fcac0c718cbbcec08f5762f
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/NotificationTest.php?rt=horde-git&r1=b79ad0b268c3cddb46fec53529feda2e1d128c87&r2=d000d80252fb52aa5fcac0c718cbbcec08f5762f
-----------------------------------------------------------------------
commit 7ee14724b0dcdb39d2d8b66d2b57942f88ab251d
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Oct 27 19:35:58 2009 +0100
Fix typo. getMessage() in the mobile listener should delegate to
getMessage() instead of notify() in the status listener if no mobile
handler is set.
framework/Notification/lib/Horde/Notification/Listener/Mobile.php | 2 +-
.../Horde/Notification/Class/Notification/Listener/MobileTest.php | 15 +++++
2 files changed, 16 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener/Mobile.php?rt=horde-git&r1=59fa30018ae20160422119959133aa2f7a64d78f&r2=7ee14724b0dcdb39d2d8b66d2b57942f88ab251d
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/MobileTest.php?rt=horde-git&r1=b79ad0b268c3cddb46fec53529feda2e1d128c87&r2=7ee14724b0dcdb39d2d8b66d2b57942f88ab251d
-----------------------------------------------------------------------
commit 3b590095a4312f85639071510adc42d5dc9090fc
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Oct 28 12:29:22 2009 +0100
Moved the core part from Horde_Notification into different
Horde_Notification_Handler classes. Added unit testing.
The core part of the functionality went into
Horde_Notification_Handler_Base. Only the segments that require access
to Horde global state have been split off into separate decorators.
The Horde_Notification_Handler_Alarm decorator delegates alarms to the
alarm system provided in the constructor. It needs access to
Horde_Auth::getAuth().
The Horde_Notification_Handler_Hordelog decorator logs error events
via Horde::logMessage().
As the logging part is useful but should be independant of Horde
global state if possible the Horde_Notification_Handler_Logged
decorator has been added. It allows providing a logger in the
constructor.
framework/Notification/lib/Horde/Notification.php | 228 +----
framework/Notification/lib/Horde/Notification/Handler.php | 117 ++
framework/Notification/lib/Horde/Notification/Handler/Alarm.php | 178 +++
framework/Notification/lib/Horde/Notification/Handler/Base.php | 254 +++++
.../Notification/lib/Horde/Notification/Handler/Hordelog.php | 164 +++
framework/Notification/lib/Horde/Notification/Handler/Logged.php | 184 +++
framework/Notification/package.xml | 22 +
.../Horde/Notification/Class/Notification/Handler/AlarmTest.php | 138 +++
.../Horde/Notification/Class/Notification/Handler/BaseTest.php | 221 ++++
.../Notification/Class/Notification/Handler/HordelogTest.php | 134 +++
.../Horde/Notification/Class/Notification/Handler/LoggedTest.php | 133 +++
.../test/Horde/Notification/Class/NotificationTest.php | 204 +----
12 files changed, 1563 insertions(+), 414 deletions(-)
create mode 100644 framework/Notification/lib/Horde/Notification/Handler.php
create mode 100644 framework/Notification/lib/Horde/Notification/Handler/Alarm.php
create mode 100644 framework/Notification/lib/Horde/Notification/Handler/Base.php
create mode 100644 framework/Notification/lib/Horde/Notification/Handler/Hordelog.php
create mode 100644 framework/Notification/lib/Horde/Notification/Handler/Logged.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/AlarmTest.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/BaseTest.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/HordelogTest.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/LoggedTest.php
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification.php?rt=horde-git&r1=d000d80252fb52aa5fcac0c718cbbcec08f5762f&r2=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Alarm.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Hordelog.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Logged.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/diff.php/framework/Notification/package.xml?rt=horde-git&r1=d000d80252fb52aa5fcac0c718cbbcec08f5762f&r2=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/AlarmTest.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/BaseTest.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/HordelogTest.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/LoggedTest.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/NotificationTest.php?rt=horde-git&r1=d000d80252fb52aa5fcac0c718cbbcec08f5762f&r2=3b590095a4312f85639071510adc42d5dc9090fc
-----------------------------------------------------------------------
commit cd3fedd26662f1612af4d77c46661733f1e08ac6
Author: Jan Schneider <jan at horde.org>
Date: Thu Oct 29 15:15:20 2009 +0100
Fix package name.
framework/Lock/package.xml | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/Lock/package.xml?rt=horde-git&r1=d1d97a219da2535a4c932b0757573c3b2b355da8&r2=cd3fedd26662f1612af4d77c46661733f1e08ac6
-----------------------------------------------------------------------
commit 7526f22f42431f48d21de485033e65c0065894e6
Author: Jan Schneider <jan at horde.org>
Date: Thu Oct 29 15:17:11 2009 +0100
Use Horde_String.
framework/Notification/lib/Horde/Notification/Handler/Base.php | 15 ++++----
framework/Notification/package.xml | 4 ++
2 files changed, 11 insertions(+), 8 deletions(-)
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r1=3b590095a4312f85639071510adc42d5dc9090fc&r2=7526f22f42431f48d21de485033e65c0065894e6
http://git.horde.org/diff.php/framework/Notification/package.xml?rt=horde-git&r1=3b590095a4312f85639071510adc42d5dc9090fc&r2=7526f22f42431f48d21de485033e65c0065894e6
-----------------------------------------------------------------------
commit 36ed96174989e844305049d84b078100826a02b0
Author: Jan Schneider <jan at horde.org>
Date: Thu Oct 29 15:38:25 2009 +0100
Be more relaxed on the params argument.
framework/Notification/lib/Horde/Notification/Handler.php | 2 +-
framework/Notification/lib/Horde/Notification/Handler/Alarm.php | 2 +-
framework/Notification/lib/Horde/Notification/Handler/Base.php | 2 +-
.../Notification/lib/Horde/Notification/Handler/Hordelog.php | 2 +-
framework/Notification/lib/Horde/Notification/Handler/Logged.php | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler.php?rt=horde-git&r1=3b590095a4312f85639071510adc42d5dc9090fc&r2=36ed96174989e844305049d84b078100826a02b0
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Alarm.php?rt=horde-git&r1=3b590095a4312f85639071510adc42d5dc9090fc&r2=36ed96174989e844305049d84b078100826a02b0
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r1=7526f22f42431f48d21de485033e65c0065894e6&r2=36ed96174989e844305049d84b078100826a02b0
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Hordelog.php?rt=horde-git&r1=3b590095a4312f85639071510adc42d5dc9090fc&r2=36ed96174989e844305049d84b078100826a02b0
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Logged.php?rt=horde-git&r1=3b590095a4312f85639071510adc42d5dc9090fc&r2=36ed96174989e844305049d84b078100826a02b0
-----------------------------------------------------------------------
commit 8f39f7ba1947693696174bea03cdbc095d149953
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 4 23:47:10 2009 +0100
Clarify that these are interfaces by renaming them to Interface.php.
framework/Notification/lib/Horde/Notification/Handler.php | 117 -----
framework/Notification/lib/Horde/Notification/Handler/Alarm.php | 4 +-
framework/Notification/lib/Horde/Notification/Handler/Base.php | 8 +-
.../Notification/lib/Horde/Notification/Handler/Hordelog.php | 7 +-
.../Notification/lib/Horde/Notification/Handler/Interface.php | 117 +++++
framework/Notification/lib/Horde/Notification/Handler/Logged.php | 8 +-
framework/Notification/lib/Horde/Notification/Storage.php | 39 --
.../Notification/lib/Horde/Notification/Storage/Interface.php | 39 ++
framework/Notification/lib/Horde/Notification/Storage/Session.php | 3 +-
framework/Notification/package.xml | 8 +-
10 files changed, 178 insertions(+), 172 deletions(-)
delete mode 100644 framework/Notification/lib/Horde/Notification/Handler.php
create mode 100644 framework/Notification/lib/Horde/Notification/Handler/Interface.php
delete mode 100644 framework/Notification/lib/Horde/Notification/Storage.php
create mode 100644 framework/Notification/lib/Horde/Notification/Storage/Interface.php
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler.php?rt=horde-git&r1=36ed96174989e844305049d84b078100826a02b0&r2=8f39f7ba1947693696174bea03cdbc095d149953
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Alarm.php?rt=horde-git&r1=36ed96174989e844305049d84b078100826a02b0&r2=8f39f7ba1947693696174bea03cdbc095d149953
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r1=36ed96174989e844305049d84b078100826a02b0&r2=8f39f7ba1947693696174bea03cdbc095d149953
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Hordelog.php?rt=horde-git&r1=36ed96174989e844305049d84b078100826a02b0&r2=8f39f7ba1947693696174bea03cdbc095d149953
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Interface.php?rt=horde-git&r=8f39f7ba1947693696174bea03cdbc095d149953
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Logged.php?rt=horde-git&r1=36ed96174989e844305049d84b078100826a02b0&r2=8f39f7ba1947693696174bea03cdbc095d149953
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Storage.php?rt=horde-git&r1=d000d80252fb52aa5fcac0c718cbbcec08f5762f&r2=8f39f7ba1947693696174bea03cdbc095d149953
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Storage/Interface.php?rt=horde-git&r=8f39f7ba1947693696174bea03cdbc095d149953
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Storage/Session.php?rt=horde-git&r1=d000d80252fb52aa5fcac0c718cbbcec08f5762f&r2=8f39f7ba1947693696174bea03cdbc095d149953
http://git.horde.org/diff.php/framework/Notification/package.xml?rt=horde-git&r1=7526f22f42431f48d21de485033e65c0065894e6&r2=8f39f7ba1947693696174bea03cdbc095d149953
-----------------------------------------------------------------------
commit f6bf80b4466259bcf14e007a3b1f9833b89baa12
Author: Gunnar Wrobel <p at rdus.de>
Date: Thu Nov 5 00:02:04 2009 +0100
Add another hierarchy level for decorators to indicate their function.
framework/Notification/lib/Horde/Notification.php | 4 +-
framework/Notification/lib/Horde/Notification/Handler/Alarm.php | 178 ----
.../lib/Horde/Notification/Handler/Decorator/Alarm.php | 178 ++++
.../lib/Horde/Notification/Handler/Decorator/Hordelog.php | 165 ++++
.../Notification/lib/Horde/Notification/Handler/Decorator/Log.php | 186 +++++
.../Notification/lib/Horde/Notification/Handler/Hordelog.php | 165 ----
framework/Notification/lib/Horde/Notification/Handler/Logged.php | 186 -----
framework/Notification/package.xml | 36 +-
.../Horde/Notification/Class/Notification/Handler/AlarmTest.php | 138 ---
.../Class/Notification/Handler/Decorator/AlarmTest.php | 139 +++
.../Class/Notification/Handler/Decorator/HordelogTest.php | 135 +++
.../Notification/Class/Notification/Handler/Decorator/LogTest.php | 134 +++
.../Notification/Class/Notification/Handler/HordelogTest.php | 134 ---
.../Horde/Notification/Class/Notification/Handler/LoggedTest.php | 133 ---
.../test/Horde/Notification/Class/NotificationTest.php | 2 +-
15 files changed, 960 insertions(+), 953 deletions(-)
delete mode 100644 framework/Notification/lib/Horde/Notification/Handler/Alarm.php
create mode 100644 framework/Notification/lib/Horde/Notification/Handler/Decorator/Alarm.php
create mode 100644 framework/Notification/lib/Horde/Notification/Handler/Decorator/Hordelog.php
create mode 100644 framework/Notification/lib/Horde/Notification/Handler/Decorator/Log.php
delete mode 100644 framework/Notification/lib/Horde/Notification/Handler/Hordelog.php
delete mode 100644 framework/Notification/lib/Horde/Notification/Handler/Logged.php
delete mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/AlarmTest.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/AlarmTest.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/HordelogTest.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/LogTest.php
delete mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/HordelogTest.php
delete mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/LoggedTest.php
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification.php?rt=horde-git&r1=3b590095a4312f85639071510adc42d5dc9090fc&r2=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Alarm.php?rt=horde-git&r1=8f39f7ba1947693696174bea03cdbc095d149953&r2=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Alarm.php?rt=horde-git&r=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Hordelog.php?rt=horde-git&r=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Log.php?rt=horde-git&r=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Hordelog.php?rt=horde-git&r1=8f39f7ba1947693696174bea03cdbc095d149953&r2=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Logged.php?rt=horde-git&r1=8f39f7ba1947693696174bea03cdbc095d149953&r2=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/diff.php/framework/Notification/package.xml?rt=horde-git&r1=8f39f7ba1947693696174bea03cdbc095d149953&r2=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/AlarmTest.php?rt=horde-git&r1=3b590095a4312f85639071510adc42d5dc9090fc&r2=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/AlarmTest.php?rt=horde-git&r=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/HordelogTest.php?rt=horde-git&r=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/LogTest.php?rt=horde-git&r=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/HordelogTest.php?rt=horde-git&r1=3b590095a4312f85639071510adc42d5dc9090fc&r2=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/LoggedTest.php?rt=horde-git&r1=3b590095a4312f85639071510adc42d5dc9090fc&r2=f6bf80b4466259bcf14e007a3b1f9833b89baa12
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/NotificationTest.php?rt=horde-git&r1=3b590095a4312f85639071510adc42d5dc9090fc&r2=f6bf80b4466259bcf14e007a3b1f9833b89baa12
-----------------------------------------------------------------------
commit 4ab58d686fbf77a9c4e15db912038f2e45711f28
Author: Gunnar Wrobel <p at rdus.de>
Date: Thu Nov 5 00:16:45 2009 +0100
Fix clearing the message stacks.
Looks like I should avoid implementing ArrayAcces for
the storage handler. That prevents passing around the
stacks by reference.
framework/Notification/lib/Horde/Notification/Handler/Base.php | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r1=8f39f7ba1947693696174bea03cdbc095d149953&r2=4ab58d686fbf77a9c4e15db912038f2e45711f28
-----------------------------------------------------------------------
commit 7b16317d3ad5dcb91833481a7a025513b7e35254
Author: Gunnar Wrobel <p at rdus.de>
Date: Thu Nov 5 06:53:46 2009 +0100
Do not use ArrayAccess so that we can fetch message stacks by reference.
framework/Notification/lib/Horde/Notification/Handler/Base.php | 18 +-
.../Notification/lib/Horde/Notification/Storage/Interface.php | 39 ++++-
framework/Notification/lib/Horde/Notification/Storage/Session.php | 18 +-
3 files changed, 56 insertions(+), 19 deletions(-)
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r1=4ab58d686fbf77a9c4e15db912038f2e45711f28&r2=7b16317d3ad5dcb91833481a7a025513b7e35254
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Storage/Interface.php?rt=horde-git&r1=8f39f7ba1947693696174bea03cdbc095d149953&r2=7b16317d3ad5dcb91833481a7a025513b7e35254
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Storage/Session.php?rt=horde-git&r1=8f39f7ba1947693696174bea03cdbc095d149953&r2=7b16317d3ad5dcb91833481a7a025513b7e35254
-----------------------------------------------------------------------
commit 12581d8c8fc89e4f2b80ca0e6847d9e82de6d946
Author: Gunnar Wrobel <p at rdus.de>
Date: Thu Nov 5 07:00:47 2009 +0100
Do not dereference otherwise the fix does not help :)
framework/Notification/lib/Horde/Notification/Handler/Base.php | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r1=7b16317d3ad5dcb91833481a7a025513b7e35254&r2=12581d8c8fc89e4f2b80ca0e6847d9e82de6d946
-----------------------------------------------------------------------
commit 7541e807ba8a06f7c56ff7ab3beffa022faa3c4e
Author: Gunnar Wrobel <p at rdus.de>
Date: Thu Nov 5 07:08:01 2009 +0100
Do not pass the option array by reference.
framework/Notification/lib/Horde/Notification/Handler/Base.php | 5 ++-
.../lib/Horde/Notification/Handler/Decorator/Alarm.php | 6 ++--
.../lib/Horde/Notification/Handler/Decorator/Hordelog.php | 4 +-
.../Notification/lib/Horde/Notification/Handler/Decorator/Log.php | 4 +-
.../Notification/lib/Horde/Notification/Handler/Interface.php | 2 +-
.../Class/Notification/Handler/Decorator/AlarmTest.php | 6 +++-
6 files changed, 15 insertions(+), 12 deletions(-)
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r1=12581d8c8fc89e4f2b80ca0e6847d9e82de6d946&r2=7541e807ba8a06f7c56ff7ab3beffa022faa3c4e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Alarm.php?rt=horde-git&r1=f6bf80b4466259bcf14e007a3b1f9833b89baa12&r2=7541e807ba8a06f7c56ff7ab3beffa022faa3c4e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Hordelog.php?rt=horde-git&r1=f6bf80b4466259bcf14e007a3b1f9833b89baa12&r2=7541e807ba8a06f7c56ff7ab3beffa022faa3c4e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Log.php?rt=horde-git&r1=f6bf80b4466259bcf14e007a3b1f9833b89baa12&r2=7541e807ba8a06f7c56ff7ab3beffa022faa3c4e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Interface.php?rt=horde-git&r1=8f39f7ba1947693696174bea03cdbc095d149953&r2=7541e807ba8a06f7c56ff7ab3beffa022faa3c4e
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/AlarmTest.php?rt=horde-git&r1=f6bf80b4466259bcf14e007a3b1f9833b89baa12&r2=7541e807ba8a06f7c56ff7ab3beffa022faa3c4e
-----------------------------------------------------------------------
commit 897b3a7ad14dd8c08ec459ba3381d0e1b532556e
Merge: 523c443 7541e80
Author: Gunnar Wrobel <p at rdus.de>
Date: Thu Nov 5 07:10:06 2009 +0100
Merge branch 'refactor-Notification'
framework/Notification/lib/Horde/Notification.php | 231 +----
framework/Notification/lib/Horde/Notification/Handler/Base.php | 261 +++++
.../lib/Horde/Notification/Handler/Decorator/Alarm.php | 178 +++
.../lib/Horde/Notification/Handler/Decorator/Hordelog.php | 165 +++
.../Notification/lib/Horde/Notification/Handler/Decorator/Log.php | 186 +++
.../Notification/lib/Horde/Notification/Handler/Interface.php | 117 ++
framework/Notification/lib/Horde/Notification/Listener/Mobile.php | 2 +-
.../Notification/lib/Horde/Notification/Storage/Interface.php | 76 ++
framework/Notification/lib/Horde/Notification/Storage/Session.php | 114 ++
framework/Notification/package.xml | 71 ++-
framework/Notification/test/Horde/Notification/AllTests.php | 85 ++
framework/Notification/test/Horde/Notification/Autoload.php | 28 +
.../test/Horde/Notification/Class/Notification/EventTest.php | 60 +
.../Horde/Notification/Class/Notification/Handler/BaseTest.php | 221 ++++
.../Class/Notification/Handler/Decorator/AlarmTest.php | 141 +++
.../Class/Notification/Handler/Decorator/HordelogTest.php | 135 +++
.../Notification/Class/Notification/Handler/Decorator/LogTest.php | 134 +++
.../Horde/Notification/Class/Notification/Listener/AudioTest.php | 62 +
.../Notification/Class/Notification/Listener/JavascriptTest.php | 105 ++
.../Horde/Notification/Class/Notification/Listener/MobileTest.php | 135 +++
.../Horde/Notification/Class/Notification/Listener/StatusTest.php | 126 ++
.../test/Horde/Notification/Class/Notification/ListenerTest.php | 225 ++++
.../test/Horde/Notification/Class/NotificationTest.php | 69 ++
framework/Notification/test/Horde/Notification/phpunit.xml | 8 +
24 files changed, 2712 insertions(+), 223 deletions(-)
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification.php?rt=horde-git&r1=a06e46506f19765aed445e68cc63179f4f7a51f4&r2=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Alarm.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Hordelog.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Log.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Interface.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener/Mobile.php?rt=horde-git&r1=59fa30018ae20160422119959133aa2f7a64d78f&r2=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Storage/Interface.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Storage/Session.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/diff.php/framework/Notification/package.xml?rt=horde-git&r1=a06e46506f19765aed445e68cc63179f4f7a51f4&r2=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/AllTests.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Autoload.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/EventTest.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/BaseTest.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/AlarmTest.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/HordelogTest.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/LogTest.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/AudioTest.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/JavascriptTest.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/MobileTest.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/StatusTest.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/ListenerTest.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/NotificationTest.php?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/phpunit.xml?rt=horde-git&r=897b3a7ad14dd8c08ec459ba3381d0e1b532556e
More information about the commits
mailing list