[commits] Horde branch refactor-Notification updated. 3b590095a4312f85639071510adc42d5dc9090fc

Gunnar Wrobel p at rdus.de
Wed Oct 28 11:28:08 UTC 2009 

The branch "refactor-Notification" has been updated.
The following is a summary of the commits.

from: 7ee14724b0dcdb39d2d8b66d2b57942f88ab251d

3b59009... Moved the core part from Horde_Notification into different Horde_Notification_Handler classes. Added unit testing.

-----------------------------------------------------------------------

commit 3b590095a4312f85639071510adc42d5dc9090fc
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Oct 28 12:29:22 2009 +0100

    Moved the core part from Horde_Notification into different
    Horde_Notification_Handler classes. Added unit testing.
    
    The core part of the functionality went into
    Horde_Notification_Handler_Base. Only the segments that require access
    to Horde global state have been split off into separate decorators.
    
    The Horde_Notification_Handler_Alarm decorator delegates alarms to the
    alarm system provided in the constructor. It needs access to
    Horde_Auth::getAuth().
    
    The Horde_Notification_Handler_Hordelog decorator logs error events
    via Horde::logMessage().
    
    As the logging part is useful but should be independant of Horde
    global state if possible the Horde_Notification_Handler_Logged
    decorator has been added. It allows providing a logger in the
    constructor.

 framework/Notification/lib/Horde/Notification.php                 |  228 +----
 framework/Notification/lib/Horde/Notification/Handler.php         |  117 ++
 framework/Notification/lib/Horde/Notification/Handler/Alarm.php   |  178 +++
 framework/Notification/lib/Horde/Notification/Handler/Base.php    |  254 +++++
 .../Notification/lib/Horde/Notification/Handler/Hordelog.php      |  164 +++
 framework/Notification/lib/Horde/Notification/Handler/Logged.php  |  184 +++
 framework/Notification/package.xml                                |   22 +
 .../Horde/Notification/Class/Notification/Handler/AlarmTest.php   |  138 +++
 .../Horde/Notification/Class/Notification/Handler/BaseTest.php    |  221 ++++
 .../Notification/Class/Notification/Handler/HordelogTest.php      |  134 +++
 .../Horde/Notification/Class/Notification/Handler/LoggedTest.php  |  133 +++
 .../test/Horde/Notification/Class/NotificationTest.php            |  204 +----
 12 files changed, 1563 insertions(+), 414 deletions(-)
 create mode 100644 framework/Notification/lib/Horde/Notification/Handler.php
 create mode 100644 framework/Notification/lib/Horde/Notification/Handler/Alarm.php
 create mode 100644 framework/Notification/lib/Horde/Notification/Handler/Base.php
 create mode 100644 framework/Notification/lib/Horde/Notification/Handler/Hordelog.php
 create mode 100644 framework/Notification/lib/Horde/Notification/Handler/Logged.php
 create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/AlarmTest.php
 create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/BaseTest.php
 create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/HordelogTest.php
 create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/LoggedTest.php

http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification.php?rt=horde-git&r1=d000d80252fb52aa5fcac0c718cbbcec08f5762f&r2=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Alarm.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Hordelog.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Logged.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/diff.php/framework/Notification/package.xml?rt=horde-git&r1=d000d80252fb52aa5fcac0c718cbbcec08f5762f&r2=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/AlarmTest.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/BaseTest.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/HordelogTest.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/LoggedTest.php?rt=horde-git&r=3b590095a4312f85639071510adc42d5dc9090fc
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/NotificationTest.php?rt=horde-git&r1=d000d80252fb52aa5fcac0c718cbbcec08f5762f&r2=3b590095a4312f85639071510adc42d5dc9090fc

More information about the commits mailing list