[commits] Horde branch master updated. 9d6fbaedd6d648ae374dd3d899e353d8ca1c9772

Michael Rubinsky mike at theupstairsroom.com
Sat Apr 24 16:21:45 UTC 2010


The branch "master" has been updated.
The following is a summary of the commits.

from: 59ec1ba08f3b21c92fb73a7181a7f6cf32d150a7

bab825f clarify what this does
2b072da Have the state object be responsible for stating the message if needed.
8d82dd1 fix typo
f59b1ae Match the default value with the one Nag::listTaskLists() uses
2a65aa2 Implement a working history state driver.
c7938e5 add sql creation script for the activesync tables
e8375e2 style
788a6c1 No need to gc this table on every addition.
0a96467 Move to base class
38b9bcc style, phpdoc, some logic tweaks
e5c2771 More stuff to move to the base class, implement the remaining methods for the history driver.
f87e525 phpdoc, cleanup the base abstract methods etc...
03dea92 Configuration for new history based state driver. Further clean up.
dd2c0a6 Move these to the base activesync class so the Provision class doesn't need to be loaded just to check rwstatus
9d6fbae Fix persisting foldersync state

-----------------------------------------------------------------------

commit bab825f71a72207aa11155709fa3242585c1db65
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Thu Apr 22 09:55:22 2010 -0400

    clarify what this does

 framework/ActiveSync/lib/Horde/ActiveSync/Connector/Importer.php |    9 ++++-
 1 files changed, 7 insertions(+), 2 deletions(-)

http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Connector/Importer.php?rt=horde-git&r1=b92155371d29f49b3332f3d61bfffadade38e6d5&r2=bab825f71a72207aa11155709fa3242585c1db65

-----------------------------------------------------------------------

commit 2b072dad59b9ebebb2f1be5edc141473e0b013a8
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Thu Apr 22 10:23:15 2010 -0400

    Have the state object be responsible for stating the message if needed.
    
    This allows different state drivers to omit the stat if it's not necessary for
    determining changes.

 framework/ActiveSync/lib/Horde/ActiveSync/State/File.php |    8 ++++++++
 framework/ActiveSync/lib/Horde/ActiveSync/Sync.php       |   11 ++---------
 2 files changed, 10 insertions(+), 9 deletions(-)

http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/File.php?rt=horde-git&r1=2e41edbe51e9b5915f23005641c8fbdc57d532c2&r2=2b072dad59b9ebebb2f1be5edc141473e0b013a8
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Sync.php?rt=horde-git&r1=01b84f2502cd2c9ed021ea4964f29caf97a8fab7&r2=2b072dad59b9ebebb2f1be5edc141473e0b013a8

-----------------------------------------------------------------------

commit 8d82dd1f9893b3830c4c664898271c66b850e0b5
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Thu Apr 22 10:25:24 2010 -0400

    fix typo

 framework/ActiveSync/lib/Horde/ActiveSync/State/File.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/File.php?rt=horde-git&r1=2b072dad59b9ebebb2f1be5edc141473e0b013a8&r2=8d82dd1f9893b3830c4c664898271c66b850e0b5

-----------------------------------------------------------------------

commit f59b1ae8f3e7e09e18f956cceb7106b4b27dd645
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Fri Apr 23 17:54:00 2010 -0400

    Match the default value with the one Nag::listTaskLists() uses

 nag/lib/Api.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/diff.php/nag/lib/Api.php?rt=horde-git&r1=3729c269d5cbd21e849894cac34440684b008d6f&r2=f59b1ae8f3e7e09e18f956cceb7106b4b27dd645

-----------------------------------------------------------------------

commit 2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Fri Apr 23 17:56:03 2010 -0400

    Implement a working history state driver.

 framework/ActiveSync/lib/Horde/ActiveSync.php                     |    4 +
 framework/ActiveSync/lib/Horde/ActiveSync/Connector/Importer.php  |   16 +-
 framework/ActiveSync/lib/Horde/ActiveSync/Driver/Base.php         |    2 +-
 framework/ActiveSync/lib/Horde/ActiveSync/Driver/Horde.php        |   78 +-
 .../lib/Horde/ActiveSync/Driver/Horde/Connector/Registry.php      |   34 +-
 framework/ActiveSync/lib/Horde/ActiveSync/Request/FolderSync.php  |    5 +-
 .../ActiveSync/lib/Horde/ActiveSync/Request/GetItemEstimate.php   |    1 +
 framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php        |    9 +-
 framework/ActiveSync/lib/Horde/ActiveSync/Request/Provision.php   |    1 +
 framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php        |    3 +-
 framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php          |  102 +-
 framework/ActiveSync/lib/Horde/ActiveSync/State/File.php          |  104 +-
 framework/ActiveSync/lib/Horde/ActiveSync/State/History.php       |  633 +++--
 framework/ActiveSync/package.xml                                  |    2 +
 framework/ActiveSync/test/Horde/ActiveSync/FileStateTest.php      |   10 +-
 framework/ActiveSync/test/Horde/ActiveSync/HordeDriverTest.php    |   26 +-
 16 files changed, 687 insertions(+), 343 deletions(-)

http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync.php?rt=horde-git&r1=01b84f2502cd2c9ed021ea4964f29caf97a8fab7&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Connector/Importer.php?rt=horde-git&r1=bab825f71a72207aa11155709fa3242585c1db65&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Driver/Base.php?rt=horde-git&r1=08802dcb928d794496be419fffa85825eced7c21&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Driver/Horde.php?rt=horde-git&r1=140b22c25a1dc991401bee07336db320f1549bfa&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Driver/Horde/Connector/Registry.php?rt=horde-git&r1=5cf686a43aab3fd2e53ffa3958ec9baba3f5867d&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Request/FolderSync.php?rt=horde-git&r1=01b84f2502cd2c9ed021ea4964f29caf97a8fab7&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Request/GetItemEstimate.php?rt=horde-git&r1=36248b059370019662368fff3e0df15b3f0ce7f5&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php?rt=horde-git&r1=785d07ed8eff32a04f2dd2d9e6c62504f311d6de&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Request/Provision.php?rt=horde-git&r1=acdc1a0d2b640fa3db92e01f5f34c7a9643293cc&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php?rt=horde-git&r1=01b84f2502cd2c9ed021ea4964f29caf97a8fab7&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php?rt=horde-git&r1=6c0bdba048a0d7ad7976d12e3359407f218078dd&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/File.php?rt=horde-git&r1=8d82dd1f9893b3830c4c664898271c66b850e0b5&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/History.php?rt=horde-git&r1=08802dcb928d794496be419fffa85825eced7c21&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/package.xml?rt=horde-git&r1=456a38dc1e24b5da02e8cef14f7e585e5c2d5de5&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/test/Horde/ActiveSync/FileStateTest.php?rt=horde-git&r1=52a57b986d430641bb8e7b01245de5eb242284fe&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0
http://git.horde.org/diff.php/framework/ActiveSync/test/Horde/ActiveSync/HordeDriverTest.php?rt=horde-git&r1=07885784818ae6db1689086d6f6dcf08a5557dac&r2=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0

-----------------------------------------------------------------------

commit c7938e57684bcd7708bfa64ffff2dc88b30ab636
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Fri Apr 23 17:58:13 2010 -0400

    add sql creation script for the activesync tables

 horde/scripts/sql/horde_activesync.sql |   35 ++++++++++++++++++++++++++++++++
 1 files changed, 35 insertions(+), 0 deletions(-)
 create mode 100644 horde/scripts/sql/horde_activesync.sql

http://git.horde.org/co.php/horde/scripts/sql/horde_activesync.sql?rt=horde-git&r=c7938e57684bcd7708bfa64ffff2dc88b30ab636

-----------------------------------------------------------------------

commit e8375e22231b01253bfa1f53ff73de58d9c44544
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Fri Apr 23 18:00:49 2010 -0400

    style

 framework/ActiveSync/lib/Horde/ActiveSync/State/History.php |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/History.php?rt=horde-git&r1=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0&r2=e8375e22231b01253bfa1f53ff73de58d9c44544

-----------------------------------------------------------------------

commit 788a6c1bc0a35bfdb04497c4683bbf5a4b68ab7c
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Fri Apr 23 18:09:32 2010 -0400

    No need to gc this table on every addition.
    
    This gets gc'd during the next SYNC operation anyway, don't do it explicitly here
    for each entry.

 framework/ActiveSync/lib/Horde/ActiveSync/State/History.php |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/History.php?rt=horde-git&r1=e8375e22231b01253bfa1f53ff73de58d9c44544&r2=788a6c1bc0a35bfdb04497c4683bbf5a4b68ab7c

-----------------------------------------------------------------------

commit 0a9646714ae2a1e53f54e32e40cd68ae9ecab8c4
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Fri Apr 23 18:13:07 2010 -0400

    Move to base class

 framework/ActiveSync/lib/Horde/ActiveSync/State/History.php |   14 +---------
 1 files changed, 2 insertions(+), 12 deletions(-)

http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/History.php?rt=horde-git&r1=788a6c1bc0a35bfdb04497c4683bbf5a4b68ab7c&r2=0a9646714ae2a1e53f54e32e40cd68ae9ecab8c4

-----------------------------------------------------------------------

commit 38b9bcc95761ae093228b5a0e4a81f98f9d76a62
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Fri Apr 23 19:34:37 2010 -0400

    style, phpdoc, some logic tweaks

 framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php  |    2 +-
 framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php    |   33 ++++-
 framework/ActiveSync/lib/Horde/ActiveSync/State/File.php    |   30 +---
 framework/ActiveSync/lib/Horde/ActiveSync/State/History.php |  100 +++++++----
 4 files changed, 101 insertions(+), 64 deletions(-)

http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php?rt=horde-git&r1=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0&r2=38b9bcc95761ae093228b5a0e4a81f98f9d76a62
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php?rt=horde-git&r1=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0&r2=38b9bcc95761ae093228b5a0e4a81f98f9d76a62
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/File.php?rt=horde-git&r1=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0&r2=38b9bcc95761ae093228b5a0e4a81f98f9d76a62
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/History.php?rt=horde-git&r1=0a9646714ae2a1e53f54e32e40cd68ae9ecab8c4&r2=38b9bcc95761ae093228b5a0e4a81f98f9d76a62

-----------------------------------------------------------------------

commit e5c277197cd72d77c6f07ff9a5e79104af563394
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Fri Apr 23 20:03:30 2010 -0400

    More stuff to move to the base class, implement the remaining methods for the history driver.

 framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php    |   47 +++-
 framework/ActiveSync/lib/Horde/ActiveSync/State/File.php    |   42 ---
 framework/ActiveSync/lib/Horde/ActiveSync/State/History.php |  192 +++++------
 3 files changed, 128 insertions(+), 153 deletions(-)

http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php?rt=horde-git&r1=38b9bcc95761ae093228b5a0e4a81f98f9d76a62&r2=e5c277197cd72d77c6f07ff9a5e79104af563394
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/File.php?rt=horde-git&r1=38b9bcc95761ae093228b5a0e4a81f98f9d76a62&r2=e5c277197cd72d77c6f07ff9a5e79104af563394
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/History.php?rt=horde-git&r1=38b9bcc95761ae093228b5a0e4a81f98f9d76a62&r2=e5c277197cd72d77c6f07ff9a5e79104af563394

-----------------------------------------------------------------------

commit f87e525de5a6bbcfb06c7c0da90c75af28333ae8
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Fri Apr 23 20:14:52 2010 -0400

    phpdoc, cleanup the base abstract methods etc...

 framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php |  279 +++++++-------
 1 files changed, 141 insertions(+), 138 deletions(-)

http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php?rt=horde-git&r1=e5c277197cd72d77c6f07ff9a5e79104af563394&r2=f87e525de5a6bbcfb06c7c0da90c75af28333ae8

-----------------------------------------------------------------------

commit 03dea923a72985f215f6fc5f51ab6fd72a9cd3c4
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Sat Apr 24 09:29:57 2010 -0400

    Configuration for new history based state driver. Further clean up.

 framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php        |    2 +-
 framework/ActiveSync/lib/Horde/ActiveSync/State/File.php          |    6 +-
 framework/ActiveSync/lib/Horde/ActiveSync/State/History.php       |   20 ++---
 framework/ActiveSync/test/Horde/ActiveSync/FileStateTest.php      |    4 +-
 framework/ActiveSync/test/Horde/ActiveSync/FolderSyncTest.php     |  Bin 4411 -> 4412 bytes
 .../test/Horde/ActiveSync/{137c3bb0-838d-499a-9f0e-fb6c0761da51}1 |    1 +
 horde/config/conf.xml                                             |   20 ++++-
 horde/rpc.php                                                     |   14 +++-
 8 files changed, 46 insertions(+), 21 deletions(-)
 create mode 100644 framework/ActiveSync/test/Horde/ActiveSync/{137c3bb0-838d-499a-9f0e-fb6c0761da51}1

http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php?rt=horde-git&r1=38b9bcc95761ae093228b5a0e4a81f98f9d76a62&r2=03dea923a72985f215f6fc5f51ab6fd72a9cd3c4
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/File.php?rt=horde-git&r1=e5c277197cd72d77c6f07ff9a5e79104af563394&r2=03dea923a72985f215f6fc5f51ab6fd72a9cd3c4
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/History.php?rt=horde-git&r1=e5c277197cd72d77c6f07ff9a5e79104af563394&r2=03dea923a72985f215f6fc5f51ab6fd72a9cd3c4
http://git.horde.org/diff.php/framework/ActiveSync/test/Horde/ActiveSync/FileStateTest.php?rt=horde-git&r1=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0&r2=03dea923a72985f215f6fc5f51ab6fd72a9cd3c4
http://git.horde.org/diff.php/framework/ActiveSync/test/Horde/ActiveSync/FolderSyncTest.php?rt=horde-git&r1=52a57b986d430641bb8e7b01245de5eb242284fe&r2=03dea923a72985f215f6fc5f51ab6fd72a9cd3c4
http://git.horde.org/co.php/framework/ActiveSync/test/Horde/ActiveSync/{137c3bb0-838d-499a-9f0e-fb6c0761da51}1?rt=horde-git&r=03dea923a72985f215f6fc5f51ab6fd72a9cd3c4
http://git.horde.org/diff.php/horde/config/conf.xml?rt=horde-git&r1=055b46239d41c44d0dc8363929bd6ea4257f347c&r2=03dea923a72985f215f6fc5f51ab6fd72a9cd3c4
http://git.horde.org/diff.php/horde/rpc.php?rt=horde-git&r1=08802dcb928d794496be419fffa85825eced7c21&r2=03dea923a72985f215f6fc5f51ab6fd72a9cd3c4

-----------------------------------------------------------------------

commit dd2c0a686ea23c3f49720e11b066aa18c7f9e750
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Sat Apr 24 09:48:06 2010 -0400

    Move these to the base activesync class so the Provision class doesn't need to be loaded
    just to check rwstatus

 framework/ActiveSync/lib/Horde/ActiveSync.php                   |    7 +++-
 framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php      |    2 +-
 framework/ActiveSync/lib/Horde/ActiveSync/Request/Provision.php |   13 ++-----
 framework/ActiveSync/lib/Horde/ActiveSync/State/File.php        |    2 +-
 framework/ActiveSync/lib/Horde/ActiveSync/State/History.php     |    2 +-
 5 files changed, 13 insertions(+), 13 deletions(-)

http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync.php?rt=horde-git&r1=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0&r2=dd2c0a686ea23c3f49720e11b066aa18c7f9e750
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php?rt=horde-git&r1=03dea923a72985f215f6fc5f51ab6fd72a9cd3c4&r2=dd2c0a686ea23c3f49720e11b066aa18c7f9e750
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/Request/Provision.php?rt=horde-git&r1=2a65aa27f3a76a931a2ceae9629f77eb2e905ab0&r2=dd2c0a686ea23c3f49720e11b066aa18c7f9e750
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/File.php?rt=horde-git&r1=03dea923a72985f215f6fc5f51ab6fd72a9cd3c4&r2=dd2c0a686ea23c3f49720e11b066aa18c7f9e750
http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/History.php?rt=horde-git&r1=03dea923a72985f215f6fc5f51ab6fd72a9cd3c4&r2=dd2c0a686ea23c3f49720e11b066aa18c7f9e750

-----------------------------------------------------------------------

commit 9d6fbaedd6d648ae374dd3d899e353d8ca1c9772
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Sat Apr 24 12:22:00 2010 -0400

    Fix persisting foldersync state

 framework/ActiveSync/lib/Horde/ActiveSync/State/History.php |   28 ++++++++--
 1 files changed, 22 insertions(+), 6 deletions(-)

http://git.horde.org/diff.php/framework/ActiveSync/lib/Horde/ActiveSync/State/History.php?rt=horde-git&r1=dd2c0a686ea23c3f49720e11b066aa18c7f9e750&r2=9d6fbaedd6d648ae374dd3d899e353d8ca1c9772




More information about the commits mailing list