[commits] Horde branch master updated. 549a1a57841717f032d1d95e86d10679297356e1

Gunnar Wrobel p at rdus.de
Mon Aug 30 07:14:50 UTC 2010 

The branch "master" has been updated.
The following is a summary of the commits.

from: 51ce3b4f555cd374782a88d1f6c175ab2bf75742

3982d31 Fix dependency name.
549a1a5 Added the Interfaces package.

-----------------------------------------------------------------------

commit 3982d3163400fe4b8d96c115b84b33ecf2bd363d
Author: Gunnar Wrobel <p at rdus.de>
Date:   Mon Aug 30 08:12:07 2010 +0200

    Fix dependency name.

 framework/Kolab_Server/package.xml |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/diff.php/framework/Kolab_Server/package.xml?rt=horde-git&r1=0414ad89e5f87d71ab0413f1a64d65442f54b20b&r2=3982d3163400fe4b8d96c115b84b33ecf2bd363d

-----------------------------------------------------------------------

commit 549a1a57841717f032d1d95e86d10679297356e1
Author: Gunnar Wrobel <p at rdus.de>
Date:   Mon Aug 30 09:12:59 2010 +0200

    Added the Interfaces package.
    
    Rationale:
    
    When looking at the Kolab_Session package I realized that
    "Horde_Auth::getAuth()" calls have been converted to
    "$GLOBALS['registry']->getAuth()". While this may be fine on the
    application level I don't think it is acceptable on the level of a
    framework package.
    
    "$GLOBALS['registry']->getAuth()" does pretty much the same as
    "Horde_Auth::getAuth()" did before and the move of the functionality
    into the registry is absolutely fine.
    
    For Kolab_Session this does however mean that the dependency on that
    functionality gets further obscured. Something has to setup
    $GLOBALS['registry'] before Kolab_Session is called into the mix.
    
    At the same time I think the package would now need to pull in Core as
    a dependency which I wouldn't like much either.
    
    I think it is a cleaner solution to provide the Interfaces package. It
    can be used to clearly define the communications between Core and the
    other framework packages. This also allows to declare the dependencies
    in an obvious manner and decouples low level libraries from the BIG
    Core thing.

 framework/Core/lib/Horde/Registry.php                             |    1 +
 framework/Core/package.xml                                        |    4 +
 framework/Interfaces/lib/Horde/Interfaces/Registry/Auth.php       |   47 +++
 framework/Interfaces/package.xml                                  |   72 +++++
 framework/Kolab_Session/lib/Horde/Kolab/Session.php               |    8 +-
 framework/Kolab_Session/lib/Horde/Kolab/Session/Auth/Horde.php    |   40 ---
 .../Kolab_Session/lib/Horde/Kolab/Session/Auth/Interface.php      |   36 --
 framework/Kolab_Session/lib/Horde/Kolab/Session/Auth/Mock.php     |   40 ++-
 framework/Kolab_Session/lib/Horde/Kolab/Session/Base.php          |    6 -
 .../Kolab_Session/lib/Horde/Kolab/Session/Decorator/Anonymous.php |    6 -
 framework/Kolab_Session/lib/Horde/Kolab/Session/Valid/Base.php    |   20 +-
 .../lib/Horde/Kolab/Session/Valid/Decorator/Logged.php            |    4 +-
 .../Kolab_Session/lib/Horde/Kolab/Session/Valid/Interface.php     |    8 +-
 framework/Kolab_Session/package.xml                               |   18 +-
 .../test/Horde/Kolab/Session/Class/Auth/HordeTest.php             |   41 ---
 .../test/Horde/Kolab/Session/Class/Auth/MockTest.php              |    2 +-
 .../test/Horde/Kolab/Session/Class/Valid/BaseTest.php             |   24 +-
 .../test/Horde/Kolab/Session/Class/Valid/Decorator/LoggedTest.php |    4 +-
 .../test/Horde/Kolab/Session/Integration/ValidTest.php            |   24 +-
 .../Kolab_Session/test/Horde/Kolab/Session/SessionTestCase.php    |    2 +-
 20 files changed, 204 insertions(+), 203 deletions(-)
 create mode 100644 framework/Interfaces/lib/Horde/Interfaces/Registry/Auth.php
 create mode 100644 framework/Interfaces/package.xml
 delete mode 100644 framework/Kolab_Session/lib/Horde/Kolab/Session/Auth/Horde.php
 delete mode 100644 framework/Kolab_Session/lib/Horde/Kolab/Session/Auth/Interface.php
 delete mode 100644 framework/Kolab_Session/test/Horde/Kolab/Session/Class/Auth/HordeTest.php

http://git.horde.org/diff.php/framework/Core/lib/Horde/Registry.php?rt=horde-git&r1=18ccb8b30b013995732262ac702ea673cb0b79b5&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Core/package.xml?rt=horde-git&r1=82a4095c3e4dc0d584d364a65ae432a24a0f31fb&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/co.php/framework/Interfaces/lib/Horde/Interfaces/Registry/Auth.php?rt=horde-git&r=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/co.php/framework/Interfaces/package.xml?rt=horde-git&r=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/lib/Horde/Kolab/Session.php?rt=horde-git&r1=8d6d2f02319f3355302210b630a695169c41b259&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/lib/Horde/Kolab/Session/Auth/Horde.php?rt=horde-git&r1=4343b7a9079e436ff77770deb9adb6b1f38cc29c&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/lib/Horde/Kolab/Session/Auth/Interface.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/lib/Horde/Kolab/Session/Auth/Mock.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/lib/Horde/Kolab/Session/Base.php?rt=horde-git&r1=585ed8db771eaad7d7f6d60e7d169a74d6d9c744&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/lib/Horde/Kolab/Session/Decorator/Anonymous.php?rt=horde-git&r1=8d6d2f02319f3355302210b630a695169c41b259&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/lib/Horde/Kolab/Session/Valid/Base.php?rt=horde-git&r1=4aa6ebc679fa876250e44141140bf15a41d6d0bb&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/lib/Horde/Kolab/Session/Valid/Decorator/Logged.php?rt=horde-git&r1=4aa6ebc679fa876250e44141140bf15a41d6d0bb&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/lib/Horde/Kolab/Session/Valid/Interface.php?rt=horde-git&r1=4aa6ebc679fa876250e44141140bf15a41d6d0bb&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/package.xml?rt=horde-git&r1=8d6d2f02319f3355302210b630a695169c41b259&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/test/Horde/Kolab/Session/Class/Auth/HordeTest.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/test/Horde/Kolab/Session/Class/Auth/MockTest.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/test/Horde/Kolab/Session/Class/Valid/BaseTest.php?rt=horde-git&r1=4aa6ebc679fa876250e44141140bf15a41d6d0bb&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/test/Horde/Kolab/Session/Class/Valid/Decorator/LoggedTest.php?rt=horde-git&r1=4aa6ebc679fa876250e44141140bf15a41d6d0bb&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/test/Horde/Kolab/Session/Integration/ValidTest.php?rt=horde-git&r1=585ed8db771eaad7d7f6d60e7d169a74d6d9c744&r2=549a1a57841717f032d1d95e86d10679297356e1
http://git.horde.org/diff.php/framework/Kolab_Session/test/Horde/Kolab/Session/SessionTestCase.php?rt=horde-git&r1=3cbde600ec2d9fe2d5f8cd40c7d4d9dc8c2a75c6&r2=549a1a57841717f032d1d95e86d10679297356e1

More information about the commits mailing list