[commits] Horde branch master updated. cd624150e5fa2d0f3aa6edcc966d7d588f14a1c9
Michael M Slusarz
slusarz at horde.org
Tue Feb 9 04:41:45 UTC 2010
The branch "master" has been updated.
The following is a summary of the commits.
from: a808bc1305268c62c7f16d832c4fb5d2369b918a
7214eb6 phpdoc; coding standards
499b725 Store notifications events as Horde_Notification_Event objects
b4468d4 Unneeed tests
bf94ab2 Don't attach events to listeners by default (attach when notify() is called on a listener).
cd62415 Remove move PEAR_Error usage in IMP
-----------------------------------------------------------------------
commit 7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Mon Feb 8 16:36:56 2010 -0700
phpdoc; coding standards
framework/Notification/lib/Horde/Notification.php | 7 +-
framework/Notification/lib/Horde/Notification/Event.php | 3 +-
framework/Notification/lib/Horde/Notification/Handler/Base.php | 42 ++---
.../lib/Horde/Notification/Handler/Decorator/Alarm.php | 13 +-
.../lib/Horde/Notification/Handler/Decorator/Hordelog.php | 5 +-
.../Notification/lib/Horde/Notification/Handler/Decorator/Log.php | 36 ++--
.../Notification/lib/Horde/Notification/Handler/Interface.php | 1 +
framework/Notification/lib/Horde/Notification/Listener/Audio.php | 6 +-
framework/Notification/lib/Horde/Notification/Listener/Mobile.php | 6 +-
.../Notification/lib/Horde/Notification/Storage/Interface.php | 18 +--
framework/Notification/lib/Horde/Notification/Storage/Session.php | 20 +--
framework/Notification/test/Horde/Notification/AllTests.php | 2 -
framework/Notification/test/Horde/Notification/Autoload.php | 4 +-
.../test/Horde/Notification/Class/Notification/EventTest.php | 2 -
.../Horde/Notification/Class/Notification/Handler/BaseTest.php | 4 +-
.../Class/Notification/Handler/Decorator/AlarmTest.php | 4 +-
.../Class/Notification/Handler/Decorator/HordelogTest.php | 4 +-
.../Notification/Class/Notification/Handler/Decorator/LogTest.php | 4 +-
.../Horde/Notification/Class/Notification/Listener/AudioTest.php | 2 -
.../Notification/Class/Notification/Listener/JavascriptTest.php | 2 -
.../Horde/Notification/Class/Notification/Listener/MobileTest.php | 2 -
.../Horde/Notification/Class/Notification/Listener/StatusTest.php | 2 -
.../test/Horde/Notification/Class/Notification/ListenerTest.php | 2 -
.../test/Horde/Notification/Class/NotificationTest.php | 8 +-
24 files changed, 78 insertions(+), 121 deletions(-)
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Event.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Alarm.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Hordelog.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Log.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Interface.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener/Audio.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener/Mobile.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Storage/Interface.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Storage/Session.php?rt=horde-git&r1=8888620617f5bcaf40424fd63023a7cb973457ce&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/AllTests.php?rt=horde-git&r1=bf8fc986126bdbd1eb56a30d5308ab1247d83f7f&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Autoload.php?rt=horde-git&r1=b79ad0b268c3cddb46fec53529feda2e1d128c87&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/EventTest.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/BaseTest.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/AlarmTest.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/HordelogTest.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/LogTest.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/AudioTest.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/JavascriptTest.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/MobileTest.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/StatusTest.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/ListenerTest.php?rt=horde-git&r1=a9e8ae51befc5a9fc97366e1f623e3a822060afa&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/NotificationTest.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c
-----------------------------------------------------------------------
commit 499b725b8970672ba487fc951a42929c82168727
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Mon Feb 8 18:37:46 2010 -0700
Store notifications events as Horde_Notification_Event objects
framework/Notification/lib/Horde/Notification/Event.php | 74 +++-
framework/Notification/lib/Horde/Notification/Handler/Base.php | 32 +--
framework/Notification/lib/Horde/Notification/Listener.php | 84 +----
framework/Notification/lib/Horde/Notification/Listener/Audio.php | 14 +-
.../Notification/lib/Horde/Notification/Listener/Javascript.php | 44 ++-
framework/Notification/lib/Horde/Notification/Listener/Mobile.php | 15 +-
framework/Notification/lib/Horde/Notification/Listener/Status.php | 25 +-
.../Notification/lib/Horde/Notification/Storage/Interface.php | 12 +-
framework/Notification/lib/Horde/Notification/Storage/Session.php | 14 +-
.../test/Horde/Notification/Class/Notification/EventTest.php | 17 +-
.../Horde/Notification/Class/Notification/Listener/AudioTest.php | 7 +-
.../Notification/Class/Notification/Listener/JavascriptTest.php | 28 +--
.../Horde/Notification/Class/Notification/Listener/MobileTest.php | 27 +--
.../Horde/Notification/Class/Notification/Listener/StatusTest.php | 37 +--
14 files changed, 157 insertions(+), 273 deletions(-)
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Event.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=499b725b8970672ba487fc951a42929c82168727
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=499b725b8970672ba487fc951a42929c82168727
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=499b725b8970672ba487fc951a42929c82168727
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener/Audio.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=499b725b8970672ba487fc951a42929c82168727
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener/Javascript.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=499b725b8970672ba487fc951a42929c82168727
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener/Mobile.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=499b725b8970672ba487fc951a42929c82168727
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener/Status.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=499b725b8970672ba487fc951a42929c82168727
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Storage/Interface.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=499b725b8970672ba487fc951a42929c82168727
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Storage/Session.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=499b725b8970672ba487fc951a42929c82168727
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/EventTest.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=499b725b8970672ba487fc951a42929c82168727
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/AudioTest.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=499b725b8970672ba487fc951a42929c82168727
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/JavascriptTest.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=499b725b8970672ba487fc951a42929c82168727
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/MobileTest.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=499b725b8970672ba487fc951a42929c82168727
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/StatusTest.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=499b725b8970672ba487fc951a42929c82168727
-----------------------------------------------------------------------
commit b4468d4962d0167c7067fa96af2bdddb8bb022af
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Mon Feb 8 20:10:21 2010 -0700
Unneeed tests
.../test/Horde/Notification/Class/Notification/ListenerTest.php | 20 -----
1 files changed, 0 insertions(+), 20 deletions(-)
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/ListenerTest.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=b4468d4962d0167c7067fa96af2bdddb8bb022af
-----------------------------------------------------------------------
commit bf94ab2ee58ffe15add8169edda91ecf15da2dce
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Mon Feb 8 20:52:45 2010 -0700
Don't attach events to listeners by default (attach when notify() is
called on a listener).
Remove _initNotification() workaround.
Since the notification system no longer attaches events to listeners
until notify() is called, it is safe to change notification listeners as
needed directly within _init() calls.
framework/Core/lib/Horde/Registry.php | 8 +-
framework/Core/lib/Horde/Registry/Application.php | 14 -
framework/Notification/lib/Horde/Notification/Handler/Base.php | 113 +++++---
imp/lib/Application.php | 26 +--
kronolith/lib/Application.php | 15 +-
nag/lib/Application.php | 24 +--
6 files changed, 96 insertions(+), 104 deletions(-)
http://git.horde.org/diff.php/framework/Core/lib/Horde/Registry.php?rt=horde-git&r1=6a5bf0aa07a50a34c25de6cd8eae0ee388a8e531&r2=bf94ab2ee58ffe15add8169edda91ecf15da2dce
http://git.horde.org/diff.php/framework/Core/lib/Horde/Registry/Application.php?rt=horde-git&r1=1a25ea7e9218d8eedda9ba9cad1d7e68f8f77790&r2=bf94ab2ee58ffe15add8169edda91ecf15da2dce
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r1=499b725b8970672ba487fc951a42929c82168727&r2=bf94ab2ee58ffe15add8169edda91ecf15da2dce
http://git.horde.org/diff.php/imp/lib/Application.php?rt=horde-git&r1=e73c134898000aa83c9b5fbf815e9829adcbbd3e&r2=bf94ab2ee58ffe15add8169edda91ecf15da2dce
http://git.horde.org/diff.php/kronolith/lib/Application.php?rt=horde-git&r1=33eb7243328cac82e4f43fbc1060a9c089d7efb6&r2=bf94ab2ee58ffe15add8169edda91ecf15da2dce
http://git.horde.org/diff.php/nag/lib/Application.php?rt=horde-git&r1=33eb7243328cac82e4f43fbc1060a9c089d7efb6&r2=bf94ab2ee58ffe15add8169edda91ecf15da2dce
-----------------------------------------------------------------------
commit cd624150e5fa2d0f3aa6edcc966d7d588f14a1c9
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Mon Feb 8 21:22:23 2010 -0700
Remove move PEAR_Error usage in IMP
framework/Prefs/lib/Horde/Prefs/Identity.php | 7 ++-----
imp/lib/IMP.php | 14 +++++++-------
imp/lib/Maillog.php | 25 +++++++++----------------
imp/lib/Prefs/Identity.php | 19 ++++---------------
imp/smime.php | 3 +--
5 files changed, 23 insertions(+), 45 deletions(-)
http://git.horde.org/diff.php/framework/Prefs/lib/Horde/Prefs/Identity.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=cd624150e5fa2d0f3aa6edcc966d7d588f14a1c9
http://git.horde.org/diff.php/imp/lib/IMP.php?rt=horde-git&r1=9b5a6d62145bb417f2b2f40bb8302b1cdf20756e&r2=cd624150e5fa2d0f3aa6edcc966d7d588f14a1c9
http://git.horde.org/diff.php/imp/lib/Maillog.php?rt=horde-git&r1=6f57695378dd7ce689805ad9e16b43e90c2a2b78&r2=cd624150e5fa2d0f3aa6edcc966d7d588f14a1c9
http://git.horde.org/diff.php/imp/lib/Prefs/Identity.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=cd624150e5fa2d0f3aa6edcc966d7d588f14a1c9
http://git.horde.org/diff.php/imp/smime.php?rt=horde-git&r1=84e2d040b1e609a6e0d2ccc90abf90900a3ff6da&r2=cd624150e5fa2d0f3aa6edcc966d7d588f14a1c9
More information about the commits
mailing list