[commits] Horde branch master updated. 1e394986ba8dd83a6f2854f51c361f72fce9e7b5
Michael M Slusarz
slusarz at horde.org
Thu Feb 18 07:46:42 UTC 2010
The branch "master" has been updated.
The following is a summary of the commits.
from: 93c95c6b48100852e4584f23f54c225ff9f5d03b
143acec prefs cleanups
a97a35b Improve identity selection javascript
e48b8a5 Another Notification rewrite.
2f0c3cf $result isn't used.
3cd706a Fix undefined error.
b8df764 Fix setting no sound for alarms
3af5c8b Don't show forward dropdown image if disabled
faaaf49 Fix adding body text to forward.
1e39498 Fix license language
-----------------------------------------------------------------------
commit 143acecf023c46b6298013c3c98618fa64d23b4e
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Wed Feb 17 00:55:38 2010 -0700
prefs cleanups
imp/smime.php | 2 +-
imp/templates/pgp/pgp.html | 197 +++++++++++++++++------------
imp/templates/prefs/draftsselect.inc | 19 ++-
imp/templates/prefs/encryptselect.inc | 13 ++-
imp/templates/prefs/initialpageselect.inc | 17 ++-
imp/templates/prefs/sentmailselect.inc | 21 ++--
imp/templates/prefs/soundselect.inc | 33 +++--
imp/templates/prefs/sourceselect.inc | 111 ++++++++--------
imp/templates/prefs/spamselect.inc | 18 ++-
imp/templates/prefs/trashselect.inc | 15 ++-
imp/templates/smime/smime.html | 109 +++++++++++------
11 files changed, 332 insertions(+), 223 deletions(-)
http://git.horde.org/diff.php/imp/smime.php?rt=horde-git&r1=db011a2a40263b0bddcc42b1071f52a1e1bd2a83&r2=143acecf023c46b6298013c3c98618fa64d23b4e
http://git.horde.org/diff.php/imp/templates/pgp/pgp.html?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=143acecf023c46b6298013c3c98618fa64d23b4e
http://git.horde.org/diff.php/imp/templates/prefs/draftsselect.inc?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=143acecf023c46b6298013c3c98618fa64d23b4e
http://git.horde.org/diff.php/imp/templates/prefs/encryptselect.inc?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=143acecf023c46b6298013c3c98618fa64d23b4e
http://git.horde.org/diff.php/imp/templates/prefs/initialpageselect.inc?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=143acecf023c46b6298013c3c98618fa64d23b4e
http://git.horde.org/diff.php/imp/templates/prefs/sentmailselect.inc?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=143acecf023c46b6298013c3c98618fa64d23b4e
http://git.horde.org/diff.php/imp/templates/prefs/soundselect.inc?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=143acecf023c46b6298013c3c98618fa64d23b4e
http://git.horde.org/diff.php/imp/templates/prefs/sourceselect.inc?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=143acecf023c46b6298013c3c98618fa64d23b4e
http://git.horde.org/diff.php/imp/templates/prefs/spamselect.inc?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=143acecf023c46b6298013c3c98618fa64d23b4e
http://git.horde.org/diff.php/imp/templates/prefs/trashselect.inc?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=143acecf023c46b6298013c3c98618fa64d23b4e
http://git.horde.org/diff.php/imp/templates/smime/smime.html?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=143acecf023c46b6298013c3c98618fa64d23b4e
-----------------------------------------------------------------------
commit a97a35b17ec2884b85b10503c7f795b1811d7719
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Wed Feb 17 02:37:43 2010 -0700
Improve identity selection javascript
framework/Prefs/lib/Horde/Prefs/Ui.php | 2 +-
horde/js/identityselect.js | 73 ++++++++++++++++
horde/templates/prefs/deleteidentity.inc | 23 ++---
horde/templates/prefs/identityselect.inc | 133 +++++++++++------------------
4 files changed, 135 insertions(+), 96 deletions(-)
create mode 100644 horde/js/identityselect.js
http://git.horde.org/diff.php/framework/Prefs/lib/Horde/Prefs/Ui.php?rt=horde-git&r1=af62e32af17f8a3cc05142a742523389197d6cb0&r2=a97a35b17ec2884b85b10503c7f795b1811d7719
http://git.horde.org/co.php/horde/js/identityselect.js?rt=horde-git&r=a97a35b17ec2884b85b10503c7f795b1811d7719
http://git.horde.org/diff.php/horde/templates/prefs/deleteidentity.inc?rt=horde-git&r1=11cd550cdb3c45cd7cf76a4ad29b99de426e18ec&r2=a97a35b17ec2884b85b10503c7f795b1811d7719
http://git.horde.org/diff.php/horde/templates/prefs/identityselect.inc?rt=horde-git&r1=44794778d1e148b988fe57a75b3ef203883fa05f&r2=a97a35b17ec2884b85b10503c7f795b1811d7719
-----------------------------------------------------------------------
commit e48b8a54fc54a179be749967a6a8b6b73cc1162e
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Mon Feb 15 23:27:31 2010 -0700
Another Notification rewrite.
First, fix Bug #8870. Fixed by removing Nag specific event type
(nag.alarm). However, this was just a symptom of a larger problem.
The problem: using application specific Notification handlers to handle
application specific event types. The problem comes when switching
between applications. Since these application handlers don't have any
knowledge of each other, events created by one handler may not be able
to be displayed when notify() was eventually called, because another
status handler had replaced the original handler.
The solution: all notifications need to be handled by a single,
centralized source - namely, the horde-level handlers. Application
specific details are instead injected into the horde-level handler to
extend behavior.
While reworking the code, also provided opportunity to remove all
application-specific code from Notification. Horde-specific
instantiation (i.e. adding Horde logging and Alarm decorators) is now
done in Horde_Core rather than in the base Notification object.
Additionally, rework some of the complexity added to the package. I
believe the goal of the recent Notification changes was to make the
Notification package testable and/or usable outside of a base Horde
install. But these changes also made the code unreadable, redundant,
and overly complex.
e.g. using interfaces where simple class extensions
make much more sense (IMHO - there are very few cases where an interface
makes more sense than an abstract class. Using interfaces for the
Handler class was simply overkill. Out of the 10 methods defined, there
are only 2 methods useful for decorator purposes - push() and notify().
And any given decorator won't even use both of these. Having to contort
code to do things like chaining handlers to achieve this in an interface
pattern was almost impossible to follow. It is much simpler to simply
add decorators directly to the base handler object.
framework/Ajax/lib/Horde/Ajax/Application/Base.php | 18 +-
framework/Core/lib/Horde.php | 13 +-
framework/Core/lib/Horde/Core/Binder/Notification.php | 22 +
framework/Core/lib/Horde/Core/Notification/Status.php | 109 ++
framework/Core/lib/Horde/Registry.php | 15 +-
framework/Core/package.xml | 6 +
framework/Notification/lib/Horde/Notification.php | 8 +-
framework/Notification/lib/Horde/Notification/Event.php | 16 +-
framework/Notification/lib/Horde/Notification/Event/Status.php | 32 +
framework/Notification/lib/Horde/Notification/Handler.php | 400 +++++
framework/Notification/lib/Horde/Notification/Handler/Base.php | 288 ---
.../lib/Horde/Notification/Handler/Decorator/Alarm.php | 155 +--
.../lib/Horde/Notification/Handler/Decorator/Base.php | 39 +
.../lib/Horde/Notification/Handler/Decorator/Hordelog.php | 153 +--
.../Notification/lib/Horde/Notification/Handler/Decorator/Log.php | 169 +--
.../Notification/lib/Horde/Notification/Handler/Interface.php | 118 --
framework/Notification/lib/Horde/Notification/Listener.php | 47 +-
framework/Notification/lib/Horde/Notification/Listener/Audio.php | 29 +-
.../Notification/lib/Horde/Notification/Listener/Javascript.php | 47 +-
framework/Notification/lib/Horde/Notification/Listener/Mobile.php | 86 -
framework/Notification/lib/Horde/Notification/Listener/Status.php | 149 +--
framework/Notification/package.xml | 33 +-
framework/Notification/test/Horde/Notification/Autoload.php | 3 +
.../test/Horde/Notification/Class/Notification/EventTest.php | 6 +-
.../Horde/Notification/Class/Notification/Handler/BaseTest.php | 219 ---
.../Class/Notification/Handler/Decorator/AlarmTest.php | 92 +-
.../Class/Notification/Handler/Decorator/HordelogTest.php | 103 +-
.../Notification/Class/Notification/Handler/Decorator/LogTest.php | 90 +-
.../test/Horde/Notification/Class/Notification/HandlerTest.php | 206 +++
.../Horde/Notification/Class/Notification/Listener/AudioTest.php | 4 +-
.../Notification/Class/Notification/Listener/JavascriptTest.php | 10 +-
.../Horde/Notification/Class/Notification/Listener/MobileTest.php | 122 --
.../Horde/Notification/Class/Notification/Listener/StatusTest.php | 42 +-
.../test/Horde/Notification/Class/Notification/ListenerTest.php | 146 +--
.../test/Horde/Notification/Class/NotificationTest.php | 16 +-
framework/Prefs/lib/Horde/Prefs/Ui.php | 1 -
horde/services/ajax.php | 4 +-
horde/services/prefs.php | 5 -
imp/compose-dimp.php | 5 +-
imp/js/DimpCore.js | 6 +-
imp/lib/Ajax/Application.php | 18 +-
imp/lib/Application.php | 45 +-
imp/lib/Auth.php | 9 +-
imp/lib/Dimp.php | 15 -
imp/lib/Notification/Event/Status.php | 45 +
imp/lib/Notification/Handler/Decorator/Imap.php | 34 +
imp/lib/Notification/Listener/AjaxStatus.php | 34 +
imp/lib/Notification/Listener/Status.php | 94 -
imp/lib/Notification/Listener/StatusMobile.php | 34 -
imp/message-dimp.php | 4 +-
imp/message-mimp.php | 3 +-
imp/templates/compose/compose-mimp.inc | 3 +-
imp/templates/compose/redirect-mimp.inc | 3 +-
imp/templates/folders/folders-mimp.inc | 3 +-
imp/templates/mailbox/mailbox-mimp.inc | 3 +-
imp/templates/mailbox/search-mimp.inc | 3 +-
kronolith/lib/Ajax/Application.php | 10 +-
nag/lib/Application.php | 2 -
nag/lib/Nag.php | 4 +-
nag/lib/Notification/Listener/Status.php | 25 -
60 files changed, 1162 insertions(+), 2261 deletions(-)
create mode 100644 framework/Core/lib/Horde/Core/Binder/Notification.php
create mode 100644 framework/Core/lib/Horde/Core/Notification/Status.php
create mode 100644 framework/Notification/lib/Horde/Notification/Event/Status.php
create mode 100644 framework/Notification/lib/Horde/Notification/Handler.php
delete mode 100644 framework/Notification/lib/Horde/Notification/Handler/Base.php
create mode 100644 framework/Notification/lib/Horde/Notification/Handler/Decorator/Base.php
delete mode 100644 framework/Notification/lib/Horde/Notification/Handler/Interface.php
delete mode 100644 framework/Notification/lib/Horde/Notification/Listener/Mobile.php
delete mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Handler/BaseTest.php
create mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/HandlerTest.php
delete mode 100644 framework/Notification/test/Horde/Notification/Class/Notification/Listener/MobileTest.php
create mode 100644 imp/lib/Notification/Event/Status.php
create mode 100644 imp/lib/Notification/Handler/Decorator/Imap.php
create mode 100644 imp/lib/Notification/Listener/AjaxStatus.php
delete mode 100644 imp/lib/Notification/Listener/Status.php
delete mode 100644 imp/lib/Notification/Listener/StatusMobile.php
delete mode 100644 nag/lib/Notification/Listener/Status.php
http://git.horde.org/diff.php/framework/Ajax/lib/Horde/Ajax/Application/Base.php?rt=horde-git&r1=c14ae6da7bc547fecf3163d1b20960de9e18bdd4&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Core/lib/Horde.php?rt=horde-git&r1=0effa829cab0f81ae350b4090120f67ac8eb2e7a&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/co.php/framework/Core/lib/Horde/Core/Binder/Notification.php?rt=horde-git&r=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/co.php/framework/Core/lib/Horde/Core/Notification/Status.php?rt=horde-git&r=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Core/lib/Horde/Registry.php?rt=horde-git&r1=5fb5cc21e861699d935a686940e72dc5097ec2fe&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Core/package.xml?rt=horde-git&r1=0141832fe45176c993464c4b52cef1f3cb3a20dd&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification.php?rt=horde-git&r1=3e76a786ef6dda262954d25d5f9327911a9ed584&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Event.php?rt=horde-git&r1=0e1f67a2365ac4fbe0a6392c0a979d84b7fa79a1&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Event/Status.php?rt=horde-git&r=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler.php?rt=horde-git&r=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Base.php?rt=horde-git&r1=bf94ab2ee58ffe15add8169edda91ecf15da2dce&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Alarm.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/co.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Base.php?rt=horde-git&r=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Hordelog.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Decorator/Log.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Handler/Interface.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener.php?rt=horde-git&r1=499b725b8970672ba487fc951a42929c82168727&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener/Audio.php?rt=horde-git&r1=499b725b8970672ba487fc951a42929c82168727&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener/Javascript.php?rt=horde-git&r1=499b725b8970672ba487fc951a42929c82168727&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener/Mobile.php?rt=horde-git&r1=499b725b8970672ba487fc951a42929c82168727&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/lib/Horde/Notification/Listener/Status.php?rt=horde-git&r1=6c80a3d3b53d7dc002d400fbb2dc33c20ca397d0&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/package.xml?rt=horde-git&r1=0204b97343010ce85f794638451087affcbcc20e&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Autoload.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/EventTest.php?rt=horde-git&r1=499b725b8970672ba487fc951a42929c82168727&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/BaseTest.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/AlarmTest.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/HordelogTest.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Handler/Decorator/LogTest.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/co.php/framework/Notification/test/Horde/Notification/Class/Notification/HandlerTest.php?rt=horde-git&r=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/AudioTest.php?rt=horde-git&r1=499b725b8970672ba487fc951a42929c82168727&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/JavascriptTest.php?rt=horde-git&r1=499b725b8970672ba487fc951a42929c82168727&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/MobileTest.php?rt=horde-git&r1=499b725b8970672ba487fc951a42929c82168727&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/Listener/StatusTest.php?rt=horde-git&r1=499b725b8970672ba487fc951a42929c82168727&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/Notification/ListenerTest.php?rt=horde-git&r1=b4468d4962d0167c7067fa96af2bdddb8bb022af&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Notification/test/Horde/Notification/Class/NotificationTest.php?rt=horde-git&r1=7214eb6aec6b0199bd2877a39f0aff32ec57dd1c&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/framework/Prefs/lib/Horde/Prefs/Ui.php?rt=horde-git&r1=a97a35b17ec2884b85b10503c7f795b1811d7719&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/horde/services/ajax.php?rt=horde-git&r1=c1be869263d94434647831660105616acc22effb&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/horde/services/prefs.php?rt=horde-git&r1=06092df8b6c7e81e134df6d3a0254d9c0aa95a4a&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/compose-dimp.php?rt=horde-git&r1=49893aecfc0d44ad7250d5056ac1b7ed91dd0d52&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/js/DimpCore.js?rt=horde-git&r1=241298ea23cfd63946ad43fbe4669d72f03c8c85&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/lib/Ajax/Application.php?rt=horde-git&r1=2067a57a095ca5466dc098ff12005fc3835d6e36&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/lib/Application.php?rt=horde-git&r1=5fb5cc21e861699d935a686940e72dc5097ec2fe&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/lib/Auth.php?rt=horde-git&r1=8c77e8fa7db5a04ad26f8147155df4e458a8a50d&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/lib/Dimp.php?rt=horde-git&r1=7eba9311ccd488faabe102efee17cca2be7f4f72&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/co.php/imp/lib/Notification/Event/Status.php?rt=horde-git&r=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/co.php/imp/lib/Notification/Handler/Decorator/Imap.php?rt=horde-git&r=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/co.php/imp/lib/Notification/Listener/AjaxStatus.php?rt=horde-git&r=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/lib/Notification/Listener/Status.php?rt=horde-git&r1=205d6b608b229dbc485b89469d5a4039c58dcff0&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/lib/Notification/Listener/StatusMobile.php?rt=horde-git&r1=205d6b608b229dbc485b89469d5a4039c58dcff0&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/message-dimp.php?rt=horde-git&r1=49893aecfc0d44ad7250d5056ac1b7ed91dd0d52&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/message-mimp.php?rt=horde-git&r1=49893aecfc0d44ad7250d5056ac1b7ed91dd0d52&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/templates/compose/compose-mimp.inc?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/templates/compose/redirect-mimp.inc?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/templates/folders/folders-mimp.inc?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/templates/mailbox/mailbox-mimp.inc?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/imp/templates/mailbox/search-mimp.inc?rt=horde-git&r1=99e7aaf59cae56bbdbbfe3256ce8d4564f547e49&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/kronolith/lib/Ajax/Application.php?rt=horde-git&r1=0ccc349f26569383cc37e40c04cea9e5106c0f9b&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/nag/lib/Application.php?rt=horde-git&r1=bf94ab2ee58ffe15add8169edda91ecf15da2dce&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/nag/lib/Nag.php?rt=horde-git&r1=9f529bff639f1cafde6bae97fa3d6c7ee0112bce&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
http://git.horde.org/diff.php/nag/lib/Notification/Listener/Status.php?rt=horde-git&r1=9cd8bf7a40411347cf2b363a35cb3392d3b88d09&r2=e48b8a54fc54a179be749967a6a8b6b73cc1162e
-----------------------------------------------------------------------
commit 2f0c3cf61108fa94adbab2ba5e6380e092e4abd7
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Wed Feb 17 17:20:18 2010 -0700
$result isn't used.
framework/Alarm/lib/Horde/Alarm.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/Alarm/lib/Horde/Alarm.php?rt=horde-git&r1=a07b57e1c5c7c951321a6c89f06f2682d5cb08c6&r2=2f0c3cf61108fa94adbab2ba5e6380e092e4abd7
-----------------------------------------------------------------------
commit 3cd706a3f22efb5fdf32ae493c152774bef473c6
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Wed Feb 17 17:16:19 2010 -0700
Fix undefined error.
imp/lib/Mime/Viewer/Plain.php | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/diff.php/imp/lib/Mime/Viewer/Plain.php?rt=horde-git&r1=9ea2adfd52697fa84390a621cbf4017d7d52170c&r2=3cd706a3f22efb5fdf32ae493c152774bef473c6
-----------------------------------------------------------------------
commit b8df764ec37242582b2308b3682d4885864943dd
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Wed Feb 17 18:20:28 2010 -0700
Fix setting no sound for alarms
horde/admin/alarms.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/horde/admin/alarms.php?rt=horde-git&r1=7b6d7f6c40c48d40b141c94a3afa57d745ebd862&r2=b8df764ec37242582b2308b3682d4885864943dd
-----------------------------------------------------------------------
commit 3af5c8b8e31ff02e5eff55442dd3f561f1b6219c
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Wed Feb 17 21:57:25 2010 -0700
Don't show forward dropdown image if disabled
imp/js/DimpBase.js | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
http://git.horde.org/diff.php/imp/js/DimpBase.js?rt=horde-git&r1=38cfc29f4f1bc459ae7b9309a7632680e29bf605&r2=3af5c8b8e31ff02e5eff55442dd3f561f1b6219c
-----------------------------------------------------------------------
commit faaaf492e85ef454da5d9bd1a41cd54a3d321bf8
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Wed Feb 17 22:18:58 2010 -0700
Fix adding body text to forward.
Don't check for locked forward_default pref in forwardMessage(). It
prevents us from adding body text in dimp. A locked preference here
only means not to show the list of forward choices.
imp/lib/Compose.php | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
http://git.horde.org/diff.php/imp/lib/Compose.php?rt=horde-git&r1=17dbed78822f3756448e89d6cfc1193bdd5ac2c7&r2=faaaf492e85ef454da5d9bd1a41cd54a3d321bf8
-----------------------------------------------------------------------
commit 1e394986ba8dd83a6f2854f51c361f72fce9e7b5
Author: Michael M Slusarz <slusarz at curecanti.org>
Date: Thu Feb 18 00:43:32 2010 -0700
Fix license language
imp/lib/Auth.php | 4 ++--
imp/lib/Imap/Acl.php | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
http://git.horde.org/diff.php/imp/lib/Auth.php?rt=horde-git&r1=e48b8a54fc54a179be749967a6a8b6b73cc1162e&r2=1e394986ba8dd83a6f2854f51c361f72fce9e7b5
http://git.horde.org/diff.php/imp/lib/Imap/Acl.php?rt=horde-git&r1=1176375ff3e866d7aad6fdcf46332d1c0f88cecb&r2=1e394986ba8dd83a6f2854f51c361f72fce9e7b5
More information about the commits
mailing list