[commits] Horde branch master updated. 81943fdafd23db3c762d995ff832d6541b45fe67

Michael Rubinsky mike at theupstairsroom.com
Sat Feb 20 20:36:26 UTC 2010


The branch "master" has been updated.
The following is a summary of the commits.

from: aea09f7af49a0bd0032d5046204a2f693c5a6f34

d1fb290 Remove the $id parameter from loadString and loadFile
890b63d We need to be calling setImageFormat(), not setFormat() here.
81943fd Add test for the now fixed issue of not correctly setting the image's mime type

-----------------------------------------------------------------------

commit d1fb290f4e13496f8fb10bf3f538fdfd1d740b42
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Sat Feb 20 14:59:56 2010 -0500

    Remove the $id parameter from loadString and loadFile
    
    It's not necessary, client code should know that it has loaded data, it
    was causing all kinds of problems with Image effects, and takes up resources.

 ansel/lib/Faces/Base.php                                      |    2 +-
 ansel/lib/Image.php                                           |   25 +++---
 framework/Image/lib/Horde/Image/Base.php                      |   36 ++------
 framework/Image/lib/Horde/Image/Effect/Imagick/PhotoStack.php |    2 +-
 framework/Image/lib/Horde/Image/Gd.php                        |    7 +-
 framework/Image/lib/Horde/Image/Im.php                        |    2 +-
 framework/Image/lib/Horde/Image/Imagick.php                   |    6 +-
 horde/services/images/view.php                                |    2 +-
 imp/lib/Mime/Viewer/Images.php                                |    2 +-
 imp/lib/Mime/Viewer/Pdf.php                                   |    2 +-
 10 files changed, 33 insertions(+), 53 deletions(-)

http://git.horde.org/diff.php/ansel/lib/Faces/Base.php?rt=horde-git&r1=93c95c6b48100852e4584f23f54c225ff9f5d03b&r2=d1fb290f4e13496f8fb10bf3f538fdfd1d740b42
http://git.horde.org/diff.php/ansel/lib/Image.php?rt=horde-git&r1=187aa28931356d5b1b9789b5ae038fc0bd13bce7&r2=d1fb290f4e13496f8fb10bf3f538fdfd1d740b42
http://git.horde.org/diff.php/framework/Image/lib/Horde/Image/Base.php?rt=horde-git&r1=e6941f512788d02ebde35469732d5374e708ba12&r2=d1fb290f4e13496f8fb10bf3f538fdfd1d740b42
http://git.horde.org/diff.php/framework/Image/lib/Horde/Image/Effect/Imagick/PhotoStack.php?rt=horde-git&r1=4d249a3af4faea6509fe8da806264dd5d87ab4e5&r2=d1fb290f4e13496f8fb10bf3f538fdfd1d740b42
http://git.horde.org/diff.php/framework/Image/lib/Horde/Image/Gd.php?rt=horde-git&r1=5dcae2cd2543b6c29aac1690c4f5e15af6b9fe26&r2=d1fb290f4e13496f8fb10bf3f538fdfd1d740b42
http://git.horde.org/diff.php/framework/Image/lib/Horde/Image/Im.php?rt=horde-git&r1=e6941f512788d02ebde35469732d5374e708ba12&r2=d1fb290f4e13496f8fb10bf3f538fdfd1d740b42
http://git.horde.org/diff.php/framework/Image/lib/Horde/Image/Imagick.php?rt=horde-git&r1=125a6d386a14032d3c078b8d5798e255bb9ebce3&r2=d1fb290f4e13496f8fb10bf3f538fdfd1d740b42
http://git.horde.org/diff.php/horde/services/images/view.php?rt=horde-git&r1=4769c84d43d75725f44d409e1c862ca3ea44ed0e&r2=d1fb290f4e13496f8fb10bf3f538fdfd1d740b42
http://git.horde.org/diff.php/imp/lib/Mime/Viewer/Images.php?rt=horde-git&r1=0e862d364160b105b2c2d8c19d301f7ac853abaf&r2=d1fb290f4e13496f8fb10bf3f538fdfd1d740b42
http://git.horde.org/diff.php/imp/lib/Mime/Viewer/Pdf.php?rt=horde-git&r1=cbdfd1f34ba8a0f0218268a01f4d580d2fa018f7&r2=d1fb290f4e13496f8fb10bf3f538fdfd1d740b42

-----------------------------------------------------------------------

commit 890b63dbe3965c0cb64daf328a9f7aeb56ca9da2
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Sat Feb 20 15:32:07 2010 -0500

    We need to be calling setImageFormat(), not setFormat() here.
    
    Damn hard to find this bug, but finally fixes issue causing thumbnails
    to loose transparency when applying certain compound effects.

 framework/Image/lib/Horde/Image/Imagick.php |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

http://git.horde.org/diff.php/framework/Image/lib/Horde/Image/Imagick.php?rt=horde-git&r1=d1fb290f4e13496f8fb10bf3f538fdfd1d740b42&r2=890b63dbe3965c0cb64daf328a9f7aeb56ca9da2

-----------------------------------------------------------------------

commit 81943fdafd23db3c762d995ff832d6541b45fe67
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Sat Feb 20 15:34:47 2010 -0500

    Add test for the now fixed issue of not correctly setting the image's mime type

 framework/Image/tests/im.php      |   18 +++++++++++++++---
 framework/Image/tests/runtest.php |    1 +
 2 files changed, 16 insertions(+), 3 deletions(-)

http://git.horde.org/diff.php/framework/Image/tests/im.php?rt=horde-git&r1=be1eab7ff1002a4ec201f63ae67e75de261c7694&r2=81943fdafd23db3c762d995ff832d6541b45fe67
http://git.horde.org/diff.php/framework/Image/tests/runtest.php?rt=horde-git&r1=73cb229131c65dcaed69f4c3fda510ade63cf05b&r2=81943fdafd23db3c762d995ff832d6541b45fe67




More information about the commits mailing list