[commits] Horde branch Horde_LoginTasks-Refactor created. b70b84343d05538bad914a0738ae25e63ab31806

[Gunnar Wrobel]

The branch "Horde_LoginTasks-Refactor" has been created.
        at  b70b84343d05538bad914a0738ae25e63ab31806 (commit)

-----------------------------------------------------------------------
commit b70b84343d05538bad914a0738ae25e63ab31806
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Mar 3 01:43:53 2010 +0100

    Temporary workaround to avoid the hard redirect exit during testing.
    
    Will be immediately removed once the Backend has been extracted.

commit 71bb1947cdf2341a1394f84cafe0f4ffebe61008
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Mar 3 01:41:33 2010 +0100

    Correct bug in the weekly recurrence calculation.

commit 181f07abd4017196fb4fd95da742806a281b339c
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Mar 3 01:40:24 2010 +0100

    Add a test suite to cover refactoring the module.
    
    This time the test suite concentrates on the external interface. The
    way the Horde_Notification test suite was set up was indeed quite
    problematic.
    
    The next step for the refactoring would be to extract the Horde specific Elements into a Horde_LoginTasks_Backend_Horde class. This should provide links into the preferences system, session storage, authentication, etc.
    
    The test suite covers one bug: The recurrence calculation for weekly recurring tasks.
    
    There are two tests that are marked as incomplete: I currently still fail to understand the LoginTasks_Tasklist logic that uses the private _addTask variable. Depending on the task order some tasks will get displayed or not. But I don't see the rationale behind it. But the area should see no modifications during refactoring.