[commits] Horde branch Horde_LoginTasks-Refactor updated. ce3d0ed4077ceb492bdb6081d7769abadce19902
Gunnar Wrobel
p at rdus.de
Tue Mar 9 17:52:18 UTC 2010
The branch "Horde_LoginTasks-Refactor" has been updated.
The following is a summary of the commits.
from: 62302846ee06c6b4ff02dd8b2afea09dab3c25f7
4252641 Remove obsolete runTasks() parameter that was initially used to avoid redirection.
c57ab53 Allow displaying several confirmations on one page.
578c5c3 Only redirect to the final URL once we are really finished with the task list.
580dace Ensure that only the tasks really completed get removed from the stack. Redirect to the login services page after a confirmation post.
ce3d0ed Remove the _addFlag.
-----------------------------------------------------------------------
commit 4252641d81bbf168245967ed40a58062f6d9dd6e
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Mar 9 14:24:02 2010 +0100
Remove obsolete runTasks() parameter that was initially used to avoid redirection.
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 22 ++++----
1 files changed, 11 insertions(+), 11 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r1=2b8ea7c3b6b555642b659df7b967fd33bfcc6b45&r2=4252641d81bbf168245967ed40a58062f6d9dd6e
-----------------------------------------------------------------------
commit c57ab5329d2351adb02c2a6a473a41021b31c0cc
Author: Gunnar Wrobel <wrobel at temple.(none)>
Date: Tue Mar 9 17:13:29 2010 +0100
Allow displaying several confirmations on one page.
framework/LoginTasks/lib/Horde/LoginTasks/Task.php | 28 +++++++++
framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php | 6 +-
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 12 +++-
3 files changed, 39 insertions(+), 7 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Task.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=c57ab5329d2351adb02c2a6a473a41021b31c0cc
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=c57ab5329d2351adb02c2a6a473a41021b31c0cc
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r1=4252641d81bbf168245967ed40a58062f6d9dd6e&r2=c57ab5329d2351adb02c2a6a473a41021b31c0cc
-----------------------------------------------------------------------
commit 578c5c38404858be8c84ae4d6b3f612fdcd35923
Author: Gunnar Wrobel <wrobel at temple.(none)>
Date: Tue Mar 9 17:39:56 2010 +0100
Only redirect to the final URL once we are really finished with the task list.
framework/LoginTasks/lib/Horde/LoginTasks.php | 4 +-
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 13 +++++----
2 files changed, 9 insertions(+), 8 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=9a6a61e4f142d3723161d5fe2b54c9a2c560ed2d&r2=578c5c38404858be8c84ae4d6b3f612fdcd35923
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r1=c57ab5329d2351adb02c2a6a473a41021b31c0cc&r2=578c5c38404858be8c84ae4d6b3f612fdcd35923
-----------------------------------------------------------------------
commit 580daceb7af750693c96a4cfd63d65b7c5a97502
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Mar 9 18:30:04 2010 +0100
Ensure that only the tasks really completed get removed from the stack. Redirect to the login services page after a confirmation post.
The test runs further though it is still not complete.
framework/LoginTasks/lib/Horde/LoginTasks.php | 6 +-
framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php | 2 +-
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 31 +++++++--
3 files changed, 31 insertions(+), 8 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=578c5c38404858be8c84ae4d6b3f612fdcd35923&r2=580daceb7af750693c96a4cfd63d65b7c5a97502
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php?rt=horde-git&r1=c57ab5329d2351adb02c2a6a473a41021b31c0cc&r2=580daceb7af750693c96a4cfd63d65b7c5a97502
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r1=578c5c38404858be8c84ae4d6b3f612fdcd35923&r2=580daceb7af750693c96a4cfd63d65b7c5a97502
-----------------------------------------------------------------------
commit ce3d0ed4077ceb492bdb6081d7769abadce19902
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Mar 9 18:52:08 2010 +0100
Remove the _addFlag.
I still don't grasp its logic and it prevents the display sequence I
currently expect. Probably my expectations are wrong. Anyhow, I
wrapped my idea of how the display series should look like into a
lengthy test (that would need to be slimmed down at some point):
Assume you have a list of tasks with
DISPLAY_CONFIRM_NO
DISPLAY_CONFIRM_YES
DISPLAY_NONE
DISPLAY_NOTICE
DISPLAY_CONFIRM_YES
DISPLAY_NONE
DISPLAY_CONFIRM_YES
DISPLAY_NOTICE
then there would be five screens with
- 1 with CONFIRM_NO and CONFIRM_YES tasks
- 1 with NOTICE task
- 1 with CONFIRM_YES task
- 1 with CONFIRM_YES task
- 1 with NOTICE task
Once the user posted to the login service page he is redirected to the
login service page again in case the tasks are not finished. Only in
case all tasks are completed he is beind redirected to the final
redirect URL provided on the first call of runTasks().
framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php | 15 +--
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 88 +++++++++
2 files changed, 89 insertions(+), 14 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php?rt=horde-git&r1=580daceb7af750693c96a4cfd63d65b7c5a97502&r2=ce3d0ed4077ceb492bdb6081d7769abadce19902
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r1=580daceb7af750693c96a4cfd63d65b7c5a97502&r2=ce3d0ed4077ceb492bdb6081d7769abadce19902
More information about the commits
mailing list