[commits] Horde branch master updated. 36cf76112c80f08946691def37671f78e2e1f4b5
Gunnar Wrobel
p at rdus.de
Wed Mar 10 08:10:51 UTC 2010
The branch "master" has been updated.
The following is a summary of the commits.
from: 5af5c335ececf94625771c7e51148bd655000575
181f07a Add a test suite to cover refactoring the module.
71bb194 Correct bug in the weekly recurrence calculation.
b70b843 Temporary workaround to avoid the hard redirect exit during testing.
7481b0c Tried to replace the two step test against a complete login task series but I'm still doing something wrong.
0472dcd Add the Backend class. Still empty.
d9e424e Move the authentication check and restoring the tasklist from the session into the backend.
178317e Move storing the task as well as registering the shutdown into the backend.
1f7de41 Move registry calls (returning the tasks and the URL of the login tasks view) into the backend.
655b4ab Move the first preferences based task into the backend.
fa21959 Transfer the rest of the preferences based functionality into the backend.
9a6a61e Move redirection into the backend.
aea73c8 Add some stub definitions for the basic Horde services so that the tests also run outside of the Horde framework context. It would probably be cleaner to stub the backend though.
2b8ea7c Fix test name.
4947d23 Update package.xml with the Packaging script and mark some dependencies now moved into the backend as optional.
6230284 Missed global refernce.
4252641 Remove obsolete runTasks() parameter that was initially used to avoid redirection.
c57ab53 Allow displaying several confirmations on one page.
578c5c3 Only redirect to the final URL once we are really finished with the task list.
580dace Ensure that only the tasks really completed get removed from the stack. Redirect to the login services page after a confirmation post.
ce3d0ed Remove the _addFlag.
2a01cd7 Simplify
6eb9563 Reorder.
36cf761 Merge branch 'Horde_LoginTasks-Refactor'
-----------------------------------------------------------------------
commit 181f07abd4017196fb4fd95da742806a281b339c
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 01:40:24 2010 +0100
Add a test suite to cover refactoring the module.
This time the test suite concentrates on the external interface. The
way the Horde_Notification test suite was set up was indeed quite
problematic.
The next step for the refactoring would be to extract the Horde specific Elements into a Horde_LoginTasks_Backend_Horde class. This should provide links into the preferences system, session storage, authentication, etc.
The test suite covers one bug: The recurrence calculation for weekly recurring tasks.
There are two tests that are marked as incomplete: I currently still fail to understand the LoginTasks_Tasklist logic that uses the private _addTask variable. Depending on the task order some tasks will get displayed or not. But I don't see the rationale behind it. But the area should see no modifications during refactoring.
framework/LoginTasks/test/Horde/LoginTasks/AllTests.php | 36 +
framework/LoginTasks/test/Horde/LoginTasks/Autoload.php | 28 +
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 508 +++++++++
framework/LoginTasks/test/Horde/LoginTasks/Stubs.php | 93 ++
framework/LoginTasks/test/Horde/LoginTasks/phpunit.xml | 8 +
5 files changed, 673 insertions(+), 0 deletions(-)
create mode 100644 framework/LoginTasks/test/Horde/LoginTasks/AllTests.php
create mode 100644 framework/LoginTasks/test/Horde/LoginTasks/Autoload.php
create mode 100644 framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php
create mode 100644 framework/LoginTasks/test/Horde/LoginTasks/Stubs.php
create mode 100644 framework/LoginTasks/test/Horde/LoginTasks/phpunit.xml
http://git.horde.org/co.php/framework/LoginTasks/test/Horde/LoginTasks/AllTests.php?rt=horde-git&r=181f07abd4017196fb4fd95da742806a281b339c
http://git.horde.org/co.php/framework/LoginTasks/test/Horde/LoginTasks/Autoload.php?rt=horde-git&r=181f07abd4017196fb4fd95da742806a281b339c
http://git.horde.org/co.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r=181f07abd4017196fb4fd95da742806a281b339c
http://git.horde.org/co.php/framework/LoginTasks/test/Horde/LoginTasks/Stubs.php?rt=horde-git&r=181f07abd4017196fb4fd95da742806a281b339c
http://git.horde.org/co.php/framework/LoginTasks/test/Horde/LoginTasks/phpunit.xml?rt=horde-git&r=181f07abd4017196fb4fd95da742806a281b339c
-----------------------------------------------------------------------
commit 71bb1947cdf2341a1394f84cafe0f4ffebe61008
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 01:41:33 2010 +0100
Correct bug in the weekly recurrence calculation.
framework/LoginTasks/lib/Horde/LoginTasks.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=b36ea34ea75465d9496b2c5ea3ddcae65ef3d650&r2=71bb1947cdf2341a1394f84cafe0f4ffebe61008
-----------------------------------------------------------------------
commit b70b84343d05538bad914a0738ae25e63ab31806
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 01:43:53 2010 +0100
Temporary workaround to avoid the hard redirect exit during testing.
Will be immediately removed once the Backend has been extracted.
framework/LoginTasks/lib/Horde/LoginTasks.php | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=71bb1947cdf2341a1394f84cafe0f4ffebe61008&r2=b70b84343d05538bad914a0738ae25e63ab31806
-----------------------------------------------------------------------
commit 7481b0c5823014a8647afc473b8d337ba62991c1
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 10:44:25 2010 +0100
Tried to replace the two step test against a complete login task series but I'm still doing something wrong.
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 70 +++++++--
framework/LoginTasks/test/Horde/LoginTasks/Stubs.php | 23 +++
2 files changed, 76 insertions(+), 17 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r1=181f07abd4017196fb4fd95da742806a281b339c&r2=7481b0c5823014a8647afc473b8d337ba62991c1
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/Stubs.php?rt=horde-git&r1=181f07abd4017196fb4fd95da742806a281b339c&r2=7481b0c5823014a8647afc473b8d337ba62991c1
-----------------------------------------------------------------------
commit 0472dcdf59321899537944e1cd6b6c02a5f4d796
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 10:56:45 2010 +0100
Add the Backend class. Still empty.
framework/LoginTasks/lib/Horde/LoginTasks.php | 20 +++++++++--
framework/LoginTasks/lib/Horde/LoginTasks/Backend.php | 18 +++++++++
framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php | 18 +++++++++
framework/LoginTasks/package.xml | 12 +++++--
4 files changed, 62 insertions(+), 6 deletions(-)
create mode 100644 framework/LoginTasks/lib/Horde/LoginTasks/Backend.php
create mode 100644 framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=b70b84343d05538bad914a0738ae25e63ab31806&r2=0472dcdf59321899537944e1cd6b6c02a5f4d796
http://git.horde.org/co.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend.php?rt=horde-git&r=0472dcdf59321899537944e1cd6b6c02a5f4d796
http://git.horde.org/co.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php?rt=horde-git&r=0472dcdf59321899537944e1cd6b6c02a5f4d796
http://git.horde.org/diff.php/framework/LoginTasks/package.xml?rt=horde-git&r1=b36ea34ea75465d9496b2c5ea3ddcae65ef3d650&r2=0472dcdf59321899537944e1cd6b6c02a5f4d796
-----------------------------------------------------------------------
commit d9e424ecc4b2e1de88fb2e98b32024482ea37231
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 11:28:36 2010 +0100
Move the authentication check and restoring the tasklist from the session into the backend.
framework/LoginTasks/lib/Horde/LoginTasks.php | 8 +--
framework/LoginTasks/lib/Horde/LoginTasks/Backend.php | 16 ++++-
framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php | 40 +++++++++++
3 files changed, 58 insertions(+), 6 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=0472dcdf59321899537944e1cd6b6c02a5f4d796&r2=d9e424ecc4b2e1de88fb2e98b32024482ea37231
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend.php?rt=horde-git&r1=0472dcdf59321899537944e1cd6b6c02a5f4d796&r2=d9e424ecc4b2e1de88fb2e98b32024482ea37231
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php?rt=horde-git&r1=0472dcdf59321899537944e1cd6b6c02a5f4d796&r2=d9e424ecc4b2e1de88fb2e98b32024482ea37231
-----------------------------------------------------------------------
commit 178317e019337cec498091dbff461fb264a4d9e8
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 11:45:31 2010 +0100
Move storing the task as well as registering the shutdown into the backend.
framework/LoginTasks/lib/Horde/LoginTasks.php | 6 +-
framework/LoginTasks/lib/Horde/LoginTasks/Backend.php | 18 ++++++++
framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php | 24 +++++++++++
3 files changed, 45 insertions(+), 3 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=d9e424ecc4b2e1de88fb2e98b32024482ea37231&r2=178317e019337cec498091dbff461fb264a4d9e8
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend.php?rt=horde-git&r1=d9e424ecc4b2e1de88fb2e98b32024482ea37231&r2=178317e019337cec498091dbff461fb264a4d9e8
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php?rt=horde-git&r1=d9e424ecc4b2e1de88fb2e98b32024482ea37231&r2=178317e019337cec498091dbff461fb264a4d9e8
-----------------------------------------------------------------------
commit 1f7de41018d25050570d2060f7d08941def76559
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 12:02:21 2010 +0100
Move registry calls (returning the tasks and the URL of the login tasks view) into the backend.
framework/LoginTasks/lib/Horde/LoginTasks.php | 31 ++------
framework/LoginTasks/lib/Horde/LoginTasks/Backend.php | 14 ++++
framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php | 43 ++++++++++-
3 files changed, 62 insertions(+), 26 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=178317e019337cec498091dbff461fb264a4d9e8&r2=1f7de41018d25050570d2060f7d08941def76559
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend.php?rt=horde-git&r1=178317e019337cec498091dbff461fb264a4d9e8&r2=1f7de41018d25050570d2060f7d08941def76559
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php?rt=horde-git&r1=178317e019337cec498091dbff461fb264a4d9e8&r2=1f7de41018d25050570d2060f7d08941def76559
-----------------------------------------------------------------------
commit 655b4ab74ccfb0192e4644e1bff016d717b6928e
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 13:58:25 2010 +0100
Move the first preferences based task into the backend.
framework/LoginTasks/lib/Horde/LoginTasks.php | 6 +-
framework/LoginTasks/lib/Horde/LoginTasks/Backend.php | 9 +++
framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php | 32 +++++++++++
framework/LoginTasks/package.xml | 6 ++
framework/LoginTasks/test/Horde/LoginTasks/Stubs.php | 13 +++-
5 files changed, 58 insertions(+), 8 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=1f7de41018d25050570d2060f7d08941def76559&r2=655b4ab74ccfb0192e4644e1bff016d717b6928e
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend.php?rt=horde-git&r1=1f7de41018d25050570d2060f7d08941def76559&r2=655b4ab74ccfb0192e4644e1bff016d717b6928e
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php?rt=horde-git&r1=1f7de41018d25050570d2060f7d08941def76559&r2=655b4ab74ccfb0192e4644e1bff016d717b6928e
http://git.horde.org/diff.php/framework/LoginTasks/package.xml?rt=horde-git&r1=0472dcdf59321899537944e1cd6b6c02a5f4d796&r2=655b4ab74ccfb0192e4644e1bff016d717b6928e
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/Stubs.php?rt=horde-git&r1=7481b0c5823014a8647afc473b8d337ba62991c1&r2=655b4ab74ccfb0192e4644e1bff016d717b6928e
-----------------------------------------------------------------------
commit fa219594824bd28097b539254cf2ca1d3653bb25
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 14:08:17 2010 +0100
Transfer the rest of the preferences based functionality into the backend.
framework/LoginTasks/lib/Horde/LoginTasks.php | 13 +----
framework/LoginTasks/lib/Horde/LoginTasks/Backend.php | 18 ++++++-
framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php | 31 ++++++++++-
3 files changed, 50 insertions(+), 12 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=655b4ab74ccfb0192e4644e1bff016d717b6928e&r2=fa219594824bd28097b539254cf2ca1d3653bb25
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend.php?rt=horde-git&r1=655b4ab74ccfb0192e4644e1bff016d717b6928e&r2=fa219594824bd28097b539254cf2ca1d3653bb25
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php?rt=horde-git&r1=655b4ab74ccfb0192e4644e1bff016d717b6928e&r2=fa219594824bd28097b539254cf2ca1d3653bb25
-----------------------------------------------------------------------
commit 9a6a61e4f142d3723161d5fe2b54c9a2c560ed2d
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 14:36:24 2010 +0100
Move redirection into the backend.
framework/LoginTasks/lib/Horde/LoginTasks.php | 21 +++------
framework/LoginTasks/lib/Horde/LoginTasks/Backend.php | 9 ++++
framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php | 13 +++++
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 12 +++--
framework/LoginTasks/test/Horde/LoginTasks/Stubs.php | 9 ++++
5 files changed, 45 insertions(+), 19 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=fa219594824bd28097b539254cf2ca1d3653bb25&r2=9a6a61e4f142d3723161d5fe2b54c9a2c560ed2d
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend.php?rt=horde-git&r1=fa219594824bd28097b539254cf2ca1d3653bb25&r2=9a6a61e4f142d3723161d5fe2b54c9a2c560ed2d
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php?rt=horde-git&r1=fa219594824bd28097b539254cf2ca1d3653bb25&r2=9a6a61e4f142d3723161d5fe2b54c9a2c560ed2d
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r1=7481b0c5823014a8647afc473b8d337ba62991c1&r2=9a6a61e4f142d3723161d5fe2b54c9a2c560ed2d
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/Stubs.php?rt=horde-git&r1=655b4ab74ccfb0192e4644e1bff016d717b6928e&r2=9a6a61e4f142d3723161d5fe2b54c9a2c560ed2d
-----------------------------------------------------------------------
commit aea73c8496bbbbb2ed59656331035b23146388af
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 17:03:35 2010 +0100
Add some stub definitions for the basic Horde services so that the
tests also run outside of the Horde framework context. It would
probably be cleaner to stub the backend though.
framework/LoginTasks/test/Horde/LoginTasks/Stubs.php | 45 ++++++++++++++++++
1 files changed, 45 insertions(+), 0 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/Stubs.php?rt=horde-git&r1=9a6a61e4f142d3723161d5fe2b54c9a2c560ed2d&r2=aea73c8496bbbbb2ed59656331035b23146388af
-----------------------------------------------------------------------
commit 2b8ea7c3b6b555642b659df7b967fd33bfcc6b45
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 17:03:52 2010 +0100
Fix test name.
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r1=9a6a61e4f142d3723161d5fe2b54c9a2c560ed2d&r2=2b8ea7c3b6b555642b659df7b967fd33bfcc6b45
-----------------------------------------------------------------------
commit 4947d23699f36fbf245294792b4247ccd2804fee
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Mar 3 17:04:25 2010 +0100
Update package.xml with the Packaging script and mark some dependencies now moved into the backend as optional.
framework/LoginTasks/package.xml | 101 ++++++++++++++++++++++++++------------
1 files changed, 70 insertions(+), 31 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/package.xml?rt=horde-git&r1=655b4ab74ccfb0192e4644e1bff016d717b6928e&r2=4947d23699f36fbf245294792b4247ccd2804fee
-----------------------------------------------------------------------
commit 62302846ee06c6b4ff02dd8b2afea09dab3c25f7
Author: Gunnar Wrobel <p at rdus.de>
Date: Thu Mar 4 08:44:52 2010 +0100
Missed global refernce.
framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php?rt=horde-git&r1=9a6a61e4f142d3723161d5fe2b54c9a2c560ed2d&r2=62302846ee06c6b4ff02dd8b2afea09dab3c25f7
-----------------------------------------------------------------------
commit 4252641d81bbf168245967ed40a58062f6d9dd6e
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Mar 9 14:24:02 2010 +0100
Remove obsolete runTasks() parameter that was initially used to avoid redirection.
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 22 ++++----
1 files changed, 11 insertions(+), 11 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r1=2b8ea7c3b6b555642b659df7b967fd33bfcc6b45&r2=4252641d81bbf168245967ed40a58062f6d9dd6e
-----------------------------------------------------------------------
commit c57ab5329d2351adb02c2a6a473a41021b31c0cc
Author: Gunnar Wrobel <wrobel at temple.(none)>
Date: Tue Mar 9 17:13:29 2010 +0100
Allow displaying several confirmations on one page.
framework/LoginTasks/lib/Horde/LoginTasks/Task.php | 28 +++++++++
framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php | 6 +-
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 12 +++-
3 files changed, 39 insertions(+), 7 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Task.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=c57ab5329d2351adb02c2a6a473a41021b31c0cc
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=c57ab5329d2351adb02c2a6a473a41021b31c0cc
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r1=4252641d81bbf168245967ed40a58062f6d9dd6e&r2=c57ab5329d2351adb02c2a6a473a41021b31c0cc
-----------------------------------------------------------------------
commit 578c5c38404858be8c84ae4d6b3f612fdcd35923
Author: Gunnar Wrobel <wrobel at temple.(none)>
Date: Tue Mar 9 17:39:56 2010 +0100
Only redirect to the final URL once we are really finished with the task list.
framework/LoginTasks/lib/Horde/LoginTasks.php | 4 +-
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 13 +++++----
2 files changed, 9 insertions(+), 8 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=9a6a61e4f142d3723161d5fe2b54c9a2c560ed2d&r2=578c5c38404858be8c84ae4d6b3f612fdcd35923
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r1=c57ab5329d2351adb02c2a6a473a41021b31c0cc&r2=578c5c38404858be8c84ae4d6b3f612fdcd35923
-----------------------------------------------------------------------
commit 580daceb7af750693c96a4cfd63d65b7c5a97502
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Mar 9 18:30:04 2010 +0100
Ensure that only the tasks really completed get removed from the stack. Redirect to the login services page after a confirmation post.
The test runs further though it is still not complete.
framework/LoginTasks/lib/Horde/LoginTasks.php | 6 +-
framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php | 2 +-
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 31 +++++++--
3 files changed, 31 insertions(+), 8 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=578c5c38404858be8c84ae4d6b3f612fdcd35923&r2=580daceb7af750693c96a4cfd63d65b7c5a97502
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php?rt=horde-git&r1=c57ab5329d2351adb02c2a6a473a41021b31c0cc&r2=580daceb7af750693c96a4cfd63d65b7c5a97502
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r1=578c5c38404858be8c84ae4d6b3f612fdcd35923&r2=580daceb7af750693c96a4cfd63d65b7c5a97502
-----------------------------------------------------------------------
commit ce3d0ed4077ceb492bdb6081d7769abadce19902
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Mar 9 18:52:08 2010 +0100
Remove the _addFlag.
I still don't grasp its logic and it prevents the display sequence I
currently expect. Probably my expectations are wrong. Anyhow, I
wrapped my idea of how the display series should look like into a
lengthy test (that would need to be slimmed down at some point):
Assume you have a list of tasks with
DISPLAY_CONFIRM_NO
DISPLAY_CONFIRM_YES
DISPLAY_NONE
DISPLAY_NOTICE
DISPLAY_CONFIRM_YES
DISPLAY_NONE
DISPLAY_CONFIRM_YES
DISPLAY_NOTICE
then there would be five screens with
- 1 with CONFIRM_NO and CONFIRM_YES tasks
- 1 with NOTICE task
- 1 with CONFIRM_YES task
- 1 with CONFIRM_YES task
- 1 with NOTICE task
Once the user posted to the login service page he is redirected to the
login service page again in case the tasks are not finished. Only in
case all tasks are completed he is beind redirected to the final
redirect URL provided on the first call of runTasks().
framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php | 15 +--
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 88 +++++++++
2 files changed, 89 insertions(+), 14 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php?rt=horde-git&r1=580daceb7af750693c96a4cfd63d65b7c5a97502&r2=ce3d0ed4077ceb492bdb6081d7769abadce19902
http://git.horde.org/diff.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r1=580daceb7af750693c96a4cfd63d65b7c5a97502&r2=ce3d0ed4077ceb492bdb6081d7769abadce19902
-----------------------------------------------------------------------
commit 2a01cd71f3808507b569caa4b53518f0ea83be6e
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Mar 9 19:41:53 2010 +0100
Simplify
framework/LoginTasks/lib/Horde/LoginTasks/Task.php | 10 ++++++
framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php | 25 +++++-----------
2 files changed, 18 insertions(+), 17 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Task.php?rt=horde-git&r1=c57ab5329d2351adb02c2a6a473a41021b31c0cc&r2=2a01cd71f3808507b569caa4b53518f0ea83be6e
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php?rt=horde-git&r1=ce3d0ed4077ceb492bdb6081d7769abadce19902&r2=2a01cd71f3808507b569caa4b53518f0ea83be6e
-----------------------------------------------------------------------
commit 6eb95633be566a1d91559f7b820634b8f56e4b37
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Mar 9 20:06:24 2010 +0100
Reorder.
framework/LoginTasks/lib/Horde/LoginTasks.php | 15 ++++++++-------
1 files changed, 8 insertions(+), 7 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=580daceb7af750693c96a4cfd63d65b7c5a97502&r2=6eb95633be566a1d91559f7b820634b8f56e4b37
-----------------------------------------------------------------------
commit 36cf76112c80f08946691def37671f78e2e1f4b5
Merge: 5af5c33 6eb9563
Author: Gunnar Wrobel <wrobel at temple.(none)>
Date: Wed Mar 10 09:10:29 2010 +0100
Merge branch 'Horde_LoginTasks-Refactor'
framework/LoginTasks/lib/Horde/LoginTasks.php | 92 +-
framework/LoginTasks/lib/Horde/LoginTasks/Backend.php | 98 ++
framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php | 193 +++
framework/LoginTasks/lib/Horde/LoginTasks/Task.php | 38 +
framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php | 42 +-
framework/LoginTasks/package.xml | 107 +-
framework/LoginTasks/test/Horde/LoginTasks/AllTests.php | 36 +
framework/LoginTasks/test/Horde/LoginTasks/Autoload.php | 28 +
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php | 662 +++++++++
framework/LoginTasks/test/Horde/LoginTasks/Stubs.php | 175 +++
framework/LoginTasks/test/Horde/LoginTasks/phpunit.xml | 8 +
11 files changed, 1365 insertions(+), 114 deletions(-)
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks.php?rt=horde-git&r1=b36ea34ea75465d9496b2c5ea3ddcae65ef3d650&r2=36cf76112c80f08946691def37671f78e2e1f4b5
http://git.horde.org/co.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend.php?rt=horde-git&r=36cf76112c80f08946691def37671f78e2e1f4b5
http://git.horde.org/co.php/framework/LoginTasks/lib/Horde/LoginTasks/Backend/Horde.php?rt=horde-git&r=36cf76112c80f08946691def37671f78e2e1f4b5
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Task.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=36cf76112c80f08946691def37671f78e2e1f4b5
http://git.horde.org/diff.php/framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php?rt=horde-git&r1=1a310b2de34193b3f984e4506d87b32de412a65e&r2=36cf76112c80f08946691def37671f78e2e1f4b5
http://git.horde.org/diff.php/framework/LoginTasks/package.xml?rt=horde-git&r1=b36ea34ea75465d9496b2c5ea3ddcae65ef3d650&r2=36cf76112c80f08946691def37671f78e2e1f4b5
http://git.horde.org/co.php/framework/LoginTasks/test/Horde/LoginTasks/AllTests.php?rt=horde-git&r=36cf76112c80f08946691def37671f78e2e1f4b5
http://git.horde.org/co.php/framework/LoginTasks/test/Horde/LoginTasks/Autoload.php?rt=horde-git&r=36cf76112c80f08946691def37671f78e2e1f4b5
http://git.horde.org/co.php/framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php?rt=horde-git&r=36cf76112c80f08946691def37671f78e2e1f4b5
http://git.horde.org/co.php/framework/LoginTasks/test/Horde/LoginTasks/Stubs.php?rt=horde-git&r=36cf76112c80f08946691def37671f78e2e1f4b5
http://git.horde.org/co.php/framework/LoginTasks/test/Horde/LoginTasks/phpunit.xml?rt=horde-git&r=36cf76112c80f08946691def37671f78e2e1f4b5
More information about the commits
mailing list