[commits] Horde branch master updated. 1e943c0937d592233379d8cac82b89f80861b11c
Gunnar Wrobel
p at rdus.de
Tue Nov 30 12:49:38 UTC 2010
The branch "master" has been updated.
The following is a summary of the commits.
from: df3540692b01d54dcfb774fca84f8856df51d0ae
1752584 Started validation testing.
50c2557 Timestamp validation.
e541c31 Added a first hashing algorithm (for session based nonce invalidation).
a37ef25 A first, simple bloom filter.
417f746 Updated package.xml and some phpdoc.
a02bdb6 Ah, looks like Null-padding killed the tests :)
6ee5466 Add a test for the null padding issue.
8788576 Do not let Crypt_Blowfish die on exceptions.
e46db70 Cleanup.
8890b47 Add a simple nonce-returning function.
b4f9a3a Simplify.
0adff3f Add the secret parameter to the token system.
051546b Add function to generate signed tokens.
e372f6d Add initial steps of the token validation.
5cca187 Add the timeout and unique checks.
31a9ef3 Fix class name.
21117bb Test the token_lifetime parameter.
f6dff61 I understand it better this way.
e2d733d Add methods that throw an exception in case a token is invalid.
55c121e Provide the token lifetime as parameter to the token system.
0e6c059 Exchange the session based logout token with the timestamped token variant as an example.
1e943c0 Add changelog entry.
-----------------------------------------------------------------------
commit 1752584c151bd6f6e3ebee23957439babdaf1edf
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 3 18:51:49 2010 +0100
Started validation testing.
framework/Nonce/test/Horde/Nonce/Integration/NonceTest.php | 13 +++++++++++-
1 files changed, 12 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/1752584c151bd6f6e3ebee23957439babdaf1edf
-----------------------------------------------------------------------
commit 50c2557a48ba86085cf98ece6b9ddce78da285c8
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 3 21:01:46 2010 +0100
Timestamp validation.
framework/Nonce/lib/Horde/Nonce.php | 17 ++++++++++++
framework/Nonce/test/Horde/Nonce/Integration/NonceTest.php | 4 +-
framework/Nonce/test/Horde/Nonce/StoryTestCase.php | 6 ++++
3 files changed, 25 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/50c2557a48ba86085cf98ece6b9ddce78da285c8
-----------------------------------------------------------------------
commit e541c3126677344291343baf747b62bb8c52e76a
Author: Gunnar Wrobel <p at rdus.de>
Date: Mon Nov 15 09:02:58 2010 +0100
Added a first hashing algorithm (for session based nonce invalidation).
framework/Nonce/lib/Horde/Nonce.php | 41 +++++-
framework/Nonce/lib/Horde/Nonce/Generator.php | 87 +++++++++++
framework/Nonce/lib/Horde/Nonce/Hash.php | 83 +++++++++++
framework/Nonce/package.xml | 12 ++-
framework/Nonce/test/Horde/Nonce/Integration/NonceTest.php | 88 +++++++++++-
framework/Nonce/test/Horde/Nonce/StoryTestCase.php | 42 +++++-
6 files changed, 341 insertions(+), 12 deletions(-)
create mode 100644 framework/Nonce/lib/Horde/Nonce/Generator.php
create mode 100644 framework/Nonce/lib/Horde/Nonce/Hash.php
http://git.horde.org/horde-git/-/commit/e541c3126677344291343baf747b62bb8c52e76a
-----------------------------------------------------------------------
commit a37ef25dcbf3b43bbd634c97a8504f5fb362588b
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 17 15:02:44 2010 +0100
A first, simple bloom filter.
framework/Nonce/lib/Horde/Nonce/Filter.php | 51 ++++++++++++++++++++
framework/Nonce/test/Horde/Nonce/StoryTestCase.php | 15 ++++++
2 files changed, 66 insertions(+), 0 deletions(-)
create mode 100644 framework/Nonce/lib/Horde/Nonce/Filter.php
http://git.horde.org/horde-git/-/commit/a37ef25dcbf3b43bbd634c97a8504f5fb362588b
-----------------------------------------------------------------------
commit 417f746fa5364af90d28ab3572354e155434b597
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 17 16:30:46 2010 +0100
Updated package.xml and some phpdoc.
framework/Secret/package.xml | 78 +++++++++++----
framework/Secret/test/Horde/Secret/AllTests.php | 13 ++-
framework/Secret/test/Horde/Secret/Autoload.php | 28 ++----
framework/Secret/test/Horde/Secret/Class/SecretTest.php | 64 ------------
framework/Secret/test/Horde/Secret/Unit/SecretTest.php | 68 +++++++++++++
5 files changed, 143 insertions(+), 108 deletions(-)
delete mode 100644 framework/Secret/test/Horde/Secret/Class/SecretTest.php
create mode 100644 framework/Secret/test/Horde/Secret/Unit/SecretTest.php
http://git.horde.org/horde-git/-/commit/417f746fa5364af90d28ab3572354e155434b597
-----------------------------------------------------------------------
commit a02bdb636897c4875ba225aa20ef80a960b7300e
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 17 16:35:57 2010 +0100
Ah, looks like Null-padding killed the tests :)
framework/Secret/test/Horde/Secret/Unit/SecretTest.php | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/a02bdb636897c4875ba225aa20ef80a960b7300e
-----------------------------------------------------------------------
commit 6ee5466c678513071352b231e6eb4e761c37fa6a
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 17 16:49:10 2010 +0100
Add a test for the null padding issue.
framework/Secret/test/Horde/Secret/Unit/SecretTest.php | 13 +++++++++++++
1 files changed, 13 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/6ee5466c678513071352b231e6eb4e761c37fa6a
-----------------------------------------------------------------------
commit 8788576ba057f7b67c1e402271cd02d701ddda39
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 17 17:30:50 2010 +0100
Do not let Crypt_Blowfish die on exceptions.
I'm not 100% certain this commit introduces the best way of dealing
with Crypt_Blowfish errors. As far as I can see there are four
situations that Crypt_Blowfish considers to be an error. In each of
these cases the library will unconditionally raise a PEAR error with
the mode "PEAR_ERROR_DIE". Which will unconditionally kill us.
Apparently one such situation has already been hit (commit
271ce27ceee4749c667b3d0b51be8947c915472d).
Now we are double checking input in both Horde_Secret and
Crypt_Blowfish but on the other hand we don't have to check the return
values anymore.
framework/Secret/lib/Horde/Secret.php | 23 ++++++---
framework/Secret/lib/Horde/Secret/Exception.php | 2 +-
framework/Secret/test/Horde/Secret/Autoload.php | 1 +
framework/Secret/test/Horde/Secret/Stub/Message.php | 20 +++++++
framework/Secret/test/Horde/Secret/Unit/SecretTest.php | 43 +++++++++++++++-
5 files changed, 79 insertions(+), 10 deletions(-)
create mode 100644 framework/Secret/test/Horde/Secret/Stub/Message.php
http://git.horde.org/horde-git/-/commit/8788576ba057f7b67c1e402271cd02d701ddda39
-----------------------------------------------------------------------
commit e46db70fbb574cfef7f52686f1ac3dd8ce676d95
Author: Gunnar Wrobel <p at rdus.de>
Date: Wed Nov 17 17:37:34 2010 +0100
Cleanup.
framework/Secret/lib/Horde/Secret.php | 22 +++++++--------
framework/Secret/test/Horde/Secret/Unit/SecretTest.php | 8 +++++-
2 files changed, 17 insertions(+), 13 deletions(-)
http://git.horde.org/horde-git/-/commit/e46db70fbb574cfef7f52686f1ac3dd8ce676d95
-----------------------------------------------------------------------
commit 8890b4793ca7d9b18e052ea2ffd5901af2d17ed7
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Nov 30 05:35:04 2010 +0100
Add a simple nonce-returning function.
I avoided Horde_Nonce for now as I got doubts whether Horde really
needs the complexity of Horde_Nonce.
framework/Token/lib/Horde/Token/Base.php | 11 +++
framework/Token/test/Horde/Token/AllTests.php | 50 +++++++++++++
framework/Token/test/Horde/Token/Autoload.php | 23 ++++++
framework/Token/test/Horde/Token/Unit/FileTest.php | 73 ++++++++++++++++++++
framework/Token/test/Horde/Token/phpunit.xml | 8 ++
5 files changed, 165 insertions(+), 0 deletions(-)
create mode 100644 framework/Token/test/Horde/Token/AllTests.php
create mode 100644 framework/Token/test/Horde/Token/Autoload.php
create mode 100644 framework/Token/test/Horde/Token/Unit/FileTest.php
create mode 100644 framework/Token/test/Horde/Token/phpunit.xml
http://git.horde.org/horde-git/-/commit/8890b4793ca7d9b18e052ea2ffd5901af2d17ed7
-----------------------------------------------------------------------
commit b4f9a3a64cce64abd1c6263aa528b8f55c4660da
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Nov 30 05:36:58 2010 +0100
Simplify.
framework/Token/lib/Horde/Token/Base.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/b4f9a3a64cce64abd1c6263aa528b8f55c4660da
-----------------------------------------------------------------------
commit 0adff3f9ba4c6c4f48d68931d34b8d4120a577fc
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Nov 30 06:05:00 2010 +0100
Add the secret parameter to the token system.
framework/Core/lib/Horde/Core/Factory/Token.php | 1 +
framework/Token/lib/Horde/Token/Base.php | 9 ++++++++-
framework/Token/test/Horde/Token/Unit/FileTest.php | 10 +++++++++-
3 files changed, 18 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/0adff3f9ba4c6c4f48d68931d34b8d4120a577fc
-----------------------------------------------------------------------
commit 051546b7d34a95c06b7dff36c54fc4acff2d7f45
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Nov 30 06:32:09 2010 +0100
Add function to generate signed tokens.
framework/Token/lib/Horde/Token/Base.php | 15 +++++++++++++++
framework/Token/test/Horde/Token/Unit/FileTest.php | 6 ++++++
2 files changed, 21 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/051546b7d34a95c06b7dff36c54fc4acff2d7f45
-----------------------------------------------------------------------
commit e372f6df888f279718320b5561a24a53298f08c3
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Nov 30 06:49:46 2010 +0100
Add initial steps of the token validation.
framework/Token/lib/Horde/Token/Base.php | 30 ++++++++++++++++++-
framework/Token/test/Horde/Token/Unit/FileTest.php | 30 ++++++++++++++++++++
2 files changed, 58 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/e372f6df888f279718320b5561a24a53298f08c3
-----------------------------------------------------------------------
commit 5cca187e89d8054043bf81aa87af1d27ac8485d1
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Nov 30 07:44:55 2010 +0100
Add the timeout and unique checks.
framework/Token/lib/Horde/Token/Base.php | 13 ++++++++-
framework/Token/test/Horde/Token/Unit/FileTest.php | 26 ++++++++++++++++++++
2 files changed, 37 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/5cca187e89d8054043bf81aa87af1d27ac8485d1
-----------------------------------------------------------------------
commit 31a9ef3aa866b9963388d6aaec94b65393416e38
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Nov 30 07:47:49 2010 +0100
Fix class name.
framework/Token/test/Horde/Token/Unit/FileTest.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/31a9ef3aa866b9963388d6aaec94b65393416e38
-----------------------------------------------------------------------
commit 21117bb330fca248209518e065169cf56d03c4e6
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Nov 30 08:29:38 2010 +0100
Test the token_lifetime parameter.
framework/Token/lib/Horde/Token/Base.php | 13 +++++++-
framework/Token/test/Horde/Token/Unit/FileTest.php | 31 ++++++++++++++++++--
2 files changed, 39 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/21117bb330fca248209518e065169cf56d03c4e6
-----------------------------------------------------------------------
commit f6dff61aa10dc8ec0d524f7f4bc2fb06707f4c07
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Nov 30 12:51:44 2010 +0100
I understand it better this way.
framework/Token/lib/Horde/Token/Base.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/f6dff61aa10dc8ec0d524f7f4bc2fb06707f4c07
-----------------------------------------------------------------------
commit e2d733d5ec8a9fc31530148818cbbe6007ad4cae
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Nov 30 13:37:53 2010 +0100
Add methods that throw an exception in case a token is invalid.
framework/Token/lib/Horde/Token/Base.php | 86 +++++++++++++-
framework/Token/lib/Horde/Token/Exception.php | 2 +-
framework/Token/lib/Horde/Token/Exception/Expired.php | 30 +++++
framework/Token/lib/Horde/Token/Exception/Invalid.php | 30 +++++
framework/Token/lib/Horde/Token/Exception/Used.php | 30 +++++
framework/Token/package.xml | 106 ++++++++++++-----
framework/Token/test/Horde/Token/Unit/FileTest.php | 52 ++++++++-
7 files changed, 297 insertions(+), 39 deletions(-)
create mode 100644 framework/Token/lib/Horde/Token/Exception/Expired.php
create mode 100644 framework/Token/lib/Horde/Token/Exception/Invalid.php
create mode 100644 framework/Token/lib/Horde/Token/Exception/Used.php
http://git.horde.org/horde-git/-/commit/e2d733d5ec8a9fc31530148818cbbe6007ad4cae
-----------------------------------------------------------------------
commit 55c121e6a641fbfc537a1f66eae73de1372bd917
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Nov 30 13:44:54 2010 +0100
Provide the token lifetime as parameter to the token system.
framework/Core/lib/Horde/Core/Factory/Token.php | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/55c121e6a641fbfc537a1f66eae73de1372bd917
-----------------------------------------------------------------------
commit 0e6c059c857152a54cd55efc9b3afb04183baea3
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Nov 30 13:46:07 2010 +0100
Exchange the session based logout token with the timestamped token variant as an example.
framework/Core/lib/Horde/Registry.php | 2 +-
horde/login.php | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/0e6c059c857152a54cd55efc9b3afb04183baea3
-----------------------------------------------------------------------
commit 1e943c0937d592233379d8cac82b89f80861b11c
Author: Gunnar Wrobel <p at rdus.de>
Date: Tue Nov 30 13:47:16 2010 +0100
Add changelog entry.
framework/Token/package.xml | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/1e943c0937d592233379d8cac82b89f80861b11c
More information about the commits
mailing list