[commits] Horde branch master updated. 984e558615322f8c3671a4c4c4423a5eae5a2714

Tue Nov 30 20:45:48 UTC 2010

The branch "master" has been updated.
The following is a summary of the commits.

from: 84de7bb593417155e4794e6c339f5441e45c0019

1bcc96d Have Horde handle PHP legacy error handling.
0db86d4 Bug #9415: Fix fatal error if IMAP object does not exist
0f8a6c4 Bug #9415: Fix storing IMAP object in session
e0d2d9e Bug #9417: Fix class name
984e558 Bug #9419: Fix typo

-----------------------------------------------------------------------

commit 1bcc96de0496c8f28ce0945183f2d83c8d36c1d2
Author: Michael M Slusarz <slusarz at curecanti.org>
Date:   Tue Nov 30 12:19:43 2010 -0700

    Have Horde handle PHP legacy error handling.

    First - no need to use error_reporting() wrapper anymore - my tests
    indicate that as of PHP 5.3, using @foo() is twice as fast.

    Next, have all error messages be caught by Horde.  For now, this means
    all PHP warnings are output to the Horde DEBUG log rather than to the
    screen.  We can play with the various output options in
    Horde::errorHandler().

    Still need to go through and remove "@" from many function calls.  These
    suppressions can result in the WSOD and make for difficult debugging.
    Going forward, we should only be concerned with suppressing warnings
    that we know aren't critical (e.g. unserialize(), htmlspecialchars()).

 framework/Core/lib/Horde.php                                |    6 +-
 framework/Core/lib/Horde/Core/Log/Logger.php                |    4 +-
 framework/Db/lib/Horde/Db/Adapter/Mysql.php                 |    5 +-
 framework/Db/lib/Horde/Db/Adapter/Mysqli.php                |    4 +-
 framework/Db/lib/Horde/Db/Adapter/Pdo/Base.php              |    5 +-
 framework/Feed/lib/Horde/Feed/Entry/Atom.php                |    4 +-
 framework/Image/lib/Horde/Image/Gd.php                      |    5 +-
 framework/Imap_Client/lib/Horde/Imap/Client/Cclient.php     |  157 +++-------
 framework/Imap_Client/lib/Horde/Imap/Client/Socket.php      |    8 +-
 framework/Imap_Client/lib/Horde/Imap/Client/Socket/Pop3.php |    8 +-
 framework/Imap_Client/lib/Horde/Imap/Client/Utf7imap.php    |   10 +-
 framework/Memcache/lib/Horde/Memcache.php                   |   16 +-
 framework/Text_Filter/lib/Horde/Text/Filter/Text2html.php   |    6 +-
 framework/Util/lib/Horde/String.php                         |   37 +--
 framework/Xml_Element/lib/Horde/Xml/Element.php             |    4 +-
 horde/docs/CODING_STANDARDS                                 |   15 +-
 horde/lib/core.php                                          |    6 +-
 imp/config/hooks.php.dist                                   |   10 +-
 imp/lib/Compose.php                                         |    4 +-
 imp/lib/Ui/Mailbox.php                                      |    6 +-
 kronolith/lib/Event.php                                     |    4 +-
 21 files changed, 92 insertions(+), 232 deletions(-)

http://git.horde.org/horde-git/-/commit/1bcc96de0496c8f28ce0945183f2d83c8d36c1d2

-----------------------------------------------------------------------

commit 0db86d41a1f35abf34371cccc0e099c6a5ba5c90
Author: Michael M Slusarz <slusarz at curecanti.org>
Date:   Tue Nov 30 12:37:42 2010 -0700

    Bug #9415: Fix fatal error if IMAP object does not exist

 imp/lib/Auth.php |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/0db86d41a1f35abf34371cccc0e099c6a5ba5c90

-----------------------------------------------------------------------

commit 0f8a6c4e58b9be58226a926bc2014122c4344c03
Author: Michael M Slusarz <slusarz at curecanti.org>
Date:   Tue Nov 30 13:36:56 2010 -0700

    Bug #9415: Fix storing IMAP object in session

    Don't store IMAP object in session if login failed.

    While rewriting this, converted IMP_Imap to Serializable interface,
    which allows us to cache one more piece of data that shouldn't change
    during the session (default namespace).  Also moves all recreation of
    the object to the injector, which is cleaner.

 imp/lib/Auth.php                  |    5 +-
 imp/lib/Imap.php                  |  102 ++++++++++--------------------------
 imp/lib/Injector/Factory/Imap.php |   39 +++++++++++++--
 3 files changed, 66 insertions(+), 80 deletions(-)

http://git.horde.org/horde-git/-/commit/0f8a6c4e58b9be58226a926bc2014122c4344c03

-----------------------------------------------------------------------

commit e0d2d9e133af61bdada19f5a63fa4a5d16e5c0ca
Author: Michael M Slusarz <slusarz at curecanti.org>
Date:   Tue Nov 30 13:42:00 2010 -0700

    Bug #9417: Fix class name

 turba/lib/Form/CreateAddressBook.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/e0d2d9e133af61bdada19f5a63fa4a5d16e5c0ca

-----------------------------------------------------------------------

commit 984e558615322f8c3671a4c4c4423a5eae5a2714
Author: Michael M Slusarz <slusarz at curecanti.org>
Date:   Tue Nov 30 13:44:35 2010 -0700

    Bug #9419: Fix typo

 turba/data.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/984e558615322f8c3671a4c4c4423a5eae5a2714