[commits] Horde branch master updated. fb3eb198ebf2168db801db653d9a7eb597ec0e5a

Michael J. Rubinsky mrubinsk at horde.org
Sat Dec 10 06:58:13 UTC 2011


The branch "master" has been updated.
The following is a summary of the commits.

from: 50b5016170dfd25488718981fe820970d33055c3

db75212 simplify
ff1f8ba Always store the textual timezone name in _timezone.
8a2d946 Ensure the timezone property is accurate.
1c11234 Add a test that demonstrates an issue with creating Horde_Date objects from an iso8601 string that represents a transition time from DST -> Standard time.
5c8de13 Fix generating ActiveSync Timezone structures.
cc2ad56 Standardize on a tz I'm more familiar with here...
3d2a977 Fix expected Timezone structure
fb3eb19 If using a custom ActiveSync log, separate logs per device.

-----------------------------------------------------------------------

commit db75212e8d0a749b0301ea40b0fb018215e453c6
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Fri Dec 9 14:04:29 2011 -0500

    simplify

 framework/ActiveSync/lib/Horde/ActiveSync/Timezone.php |   24 +++++++--------
 1 files changed, 11 insertions(+), 13 deletions(-)

http://git.horde.org/horde-git/-/commit/db75212e8d0a749b0301ea40b0fb018215e453c6

-----------------------------------------------------------------------

commit ff1f8ba472c7e3d6d5729826122d88c04b299ca5
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Fri Dec 9 22:24:11 2011 -0500

    Always store the textual timezone name in _timezone.
    
    Prevents errors when instantiating Horde_Date from a DateTime object.

 framework/Date/lib/Horde/Date.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/ff1f8ba472c7e3d6d5729826122d88c04b299ca5

-----------------------------------------------------------------------

commit 8a2d946151cd52b236aed5b0f32ab58f70b438b6
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Dec 10 00:03:27 2011 -0500

    Ensure the timezone property is accurate.

 framework/Date/lib/Horde/Date.php |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/8a2d946151cd52b236aed5b0f32ab58f70b438b6

-----------------------------------------------------------------------

commit 1c1123469c021738937891d9e8634be9996418f1
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Dec 10 01:33:18 2011 -0500

    Add a test that demonstrates an issue with creating Horde_Date
    objects from an iso8601 string that represents a transition time
    from DST -> Standard time.
    
    (Failing portion of test is commented out)

 framework/Date/test/Horde/Date/DateTest.php |   37 +++++++++++++++++++++++++++
 1 files changed, 37 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/1c1123469c021738937891d9e8634be9996418f1

-----------------------------------------------------------------------

commit 5c8de133c64d2fad9894756760d166fca75b25c1
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Dec 10 01:36:41 2011 -0500

    Fix generating ActiveSync Timezone structures.
    
    When Horde_Date receives an iso8601 style datetime string, it uses
    date_create(), and force changes the timezone to date_default_timezone_get().
    Specifying 'UTC' as the 2nd parameter to Horde_Date doesn't work, the tz parameter
    is always ignored in this case. We must change the timezone explicitly back to UTC
    after creating the Horde_Date object in this way. Of course, there is also
    another bug that prevents this from working properly on the DST -> Standard switch
    (see broken test), so we have to use DateTime directly in that case.
    
    I've tried numerous ways of allowing the tz parameter to Horde_Date
    be honored in this case, but there was always some case that wouldn't
    work properly. Fix one, break another.

 framework/ActiveSync/lib/Horde/ActiveSync/Timezone.php |   15 +++++++++++----
 1 files changed, 11 insertions(+), 4 deletions(-)

http://git.horde.org/horde-git/-/commit/5c8de133c64d2fad9894756760d166fca75b25c1

-----------------------------------------------------------------------

commit cc2ad569b74b021f043803241807da45a394d1ee
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Dec 10 01:45:41 2011 -0500

    Standardize on a tz I'm more familiar with here...

 framework/ActiveSync/test/Horde/ActiveSync/TimezoneTest.php |   15 ++++++-----
 1 files changed, 8 insertions(+), 7 deletions(-)

http://git.horde.org/horde-git/-/commit/cc2ad569b74b021f043803241807da45a394d1ee

-----------------------------------------------------------------------

commit 3d2a977f9c31d56417b83a40e7c1923ff14ebaf5
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Dec 10 01:46:11 2011 -0500

    Fix expected Timezone structure

 framework/ActiveSync/test/Horde/ActiveSync/TimezoneTest.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/3d2a977f9c31d56417b83a40e7c1923ff14ebaf5

-----------------------------------------------------------------------

commit fb3eb198ebf2168db801db653d9a7eb597ec0e5a
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Dec 10 01:47:09 2011 -0500

    If using a custom ActiveSync log, separate logs per device.
    
    It's almost impossible to follow one of these logs if you have more than 2 devices
    running at the time of debugging.

 framework/Core/lib/Horde/Core/Factory/ActiveSyncServer.php |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/fb3eb198ebf2168db801db653d9a7eb597ec0e5a




More information about the commits mailing list