[commits] Horde branch master updated. 3531a5ea4bc777193bfe9888aa02d209dd0c8b4a

Fri Jun 10 05:28:22 UTC 2011

The branch "master" has been updated.
The following is a summary of the commits.

from: 5620990e56f6a25104baf026b4d09c001107f9fe

8589f9b Start the Horde_Service_Gravatar class.
6565c6f Start the test suite for "Horde_Service_Gravatar".
dc6783e Require the Horde_Service_Gravatar class.
d6c34f0 Expect the return value of getId() to be a string.
80e84dd Implement an empty variant of getId() that just returns an empty string.
eb81c36 Test the expected hash for 'test at example.org'.
d4303f2 Return the expected hash for 'test at example.org'.
2c99017 Test different addresses with a data provider.
d707f61 Use md5() hashing to convert the mail address into the id.
8dbc0f2 Ensure that the ID generation is case-insensitive.
ad957a6 Implement case-insensitive hashing.
482b6b0 Ensure that leading/trailing whitespace is ignored.
f943363 Implement trimming.
cf984f7 Ensure the library guards against non-string input.
48f3024 Bail out if the provided mail address is no string.
3ea239c Test returning the image URL for a (gr)avatar.
91e5e68 Return the image URL for a (gr)avatar.
5d3d0ec Test returning the profile URL for a Gravatar profile.
9872d4e Return the profile URL for a Gravatar profile.
a2704cf Test for a variable base URL with preset constants.
4b9570b Allow a flexible base URL.
f9ec8da Do not restrict the profile URL to the JSON format. Rather offer a base URL and allow the calling code to append the desired format.
0c1d6a1 Test fetching JSON profile data.
a11395a Support fetching JSON profile data.
0fa601b Add an example for fetching JSON encoded profile data.
1dc2bac We need to pull in the code from the Http library if we do not use autoloading.
6d45736 Test fetching the profile data as an array.
e2af807 Return profile data as an array.
e6155c4 Demonstrate how to fetch and print Gravatar profile information.
2b1e22c Test fetching the avatar image.
31a3b86 Support fetching the avatar image.
cc6f61f Add an example for fetching the avatar image.
4ae79fe Extract to an Autoload.php file.
05ffc16 Add a real server test.
3531a5e Add AllTests.php that combines the two test suites we wrote before.

-----------------------------------------------------------------------

commit 8589f9be1ec0e0318a4abe044cc308818d823741
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 1 08:31:01 2011 +0200

    Start the Horde_Service_Gravatar class.

    This will serve as the primary interface of the Horde_Service_Gravatar
    package for accessing the services provided by the Gravatar API.

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php |   32 +++++++++++++
 1 files changed, 32 insertions(+), 0 deletions(-)
 create mode 100644 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php

http://git.horde.org/horde-git/-/commit/8589f9be1ec0e0318a4abe044cc308818d823741

-----------------------------------------------------------------------

commit 6565c6f00bca6cfa8d64dc47fa1894accaccd886
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 1 08:33:15 2011 +0200

    Start the test suite for "Horde_Service_Gravatar".

    This extends the default PHPUnit_Framework_TestCase for now. Running
    this suite with "phpunit GravatarTest.php" will still fail as no tests
    are present (yet).

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |   33 +++++
 1 files changed, 33 insertions(+), 0 deletions(-)
 create mode 100644 framework/Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php

http://git.horde.org/horde-git/-/commit/6565c6f00bca6cfa8d64dc47fa1894accaccd886

-----------------------------------------------------------------------

commit dc6783e93e89b4825eee6fba8215acbba6719407
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 12:12:53 2011 +0200

    Require the Horde_Service_Gravatar class.

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/dc6783e93e89b4825eee6fba8215acbba6719407

-----------------------------------------------------------------------

commit d6c34f0d8217153fd57fc029606f3f7bddee55b1
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 12:14:03 2011 +0200

    Expect the return value of getId() to be a string.

    This still fails as there is no function getId() in Horde_Service_Gravatar yet.

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/d6c34f0d8217153fd57fc029606f3f7bddee55b1

-----------------------------------------------------------------------

commit 80e84dddbe9c7fc9e97ca02e5ebfc657b85ed90d
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 12:17:31 2011 +0200

    Implement an empty variant of getId() that just returns an empty string.

    The first time that our tests are green!

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/80e84dddbe9c7fc9e97ca02e5ebfc657b85ed90d

-----------------------------------------------------------------------

commit eb81c3650adec085503c4cb81375e4a2d93d1420
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 12:22:58 2011 +0200

    Test the expected hash for 'test at example.org'.

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |    9 +++++
 1 files changed, 9 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/eb81c3650adec085503c4cb81375e4a2d93d1420

-----------------------------------------------------------------------

commit d4303f2170dd23db894b4b9efa7e841efbd3b380
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 12:23:33 2011 +0200

    Return the expected hash for 'test at example.org'.

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/d4303f2170dd23db894b4b9efa7e841efbd3b380

-----------------------------------------------------------------------

commit 2c99017b178f567dc68687791f5a208a84110dcd
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 12:31:45 2011 +0200

    Test different addresses with a data provider.

    "@dataProvider provideAddresses" identifies the data provider. The
    function "provideAddresses" is then expected to deliver the input
    arguments to our test function "testAddresses". As "testAddresses"
    requests two arguments ($mail and $id) "provideAddresses" has to
    deliver an array of arrays with two elements (the mail and the
    expected id).

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |   18 +++++
 1 files changed, 18 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/2c99017b178f567dc68687791f5a208a84110dcd

-----------------------------------------------------------------------

commit d707f61ac6d5931bc4e78708db84501af95f0c3a
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 12:32:31 2011 +0200

    Use md5() hashing to convert the mail address into the id.

    Now we can't fake it anymore and must use a function.

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/d707f61ac6d5931bc4e78708db84501af95f0c3a

-----------------------------------------------------------------------

commit 8dbc0f29589f0c738c749081acb39d2c9cba977d
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 12:34:18 2011 +0200

    Ensure that the ID generation is case-insensitive.

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |    9 +++++
 1 files changed, 9 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/8dbc0f29589f0c738c749081acb39d2c9cba977d

-----------------------------------------------------------------------

commit ad957a6383d673637204dfcd3e810834178cba6e
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 12:35:20 2011 +0200

    Implement case-insensitive hashing.

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/ad957a6383d673637204dfcd3e810834178cba6e

-----------------------------------------------------------------------

commit 482b6b076f827fbbb3290ea5a2c8ae85680fa788
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 12:36:28 2011 +0200

    Ensure that leading/trailing whitespace is ignored.

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |    9 +++++
 1 files changed, 9 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/482b6b076f827fbbb3290ea5a2c8ae85680fa788

-----------------------------------------------------------------------

commit f943363a01ccab5b94b9dbe0897fabaa4171f111
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 12:36:47 2011 +0200

    Implement trimming.

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/f943363a01ccab5b94b9dbe0897fabaa4171f111

-----------------------------------------------------------------------

commit cf984f7ddf8b714ade85d4ca90930eb753ebbb50
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 12:49:42 2011 +0200

    Ensure the library guards against non-string input.

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |    9 +++++
 1 files changed, 9 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/cf984f7ddf8b714ade85d4ca90930eb753ebbb50

-----------------------------------------------------------------------

commit 48f3024094c1034f7b5bae2031dc9016862800b6
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 12:50:01 2011 +0200

    Bail out if the provided mail address is no string.

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/48f3024094c1034f7b5bae2031dc9016862800b6

-----------------------------------------------------------------------

commit 3ea239c8342ef79ada05ee7bbebebb4a94d69652
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 20:48:54 2011 +0200

    Test returning the image URL for a (gr)avatar.

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |   10 +++++
 1 files changed, 10 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/3ea239c8342ef79ada05ee7bbebebb4a94d69652

-----------------------------------------------------------------------

commit 91e5e68be3fe451e90d2100ec6dad5acc40a03b4
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 20:49:13 2011 +0200

    Return the image URL for a (gr)avatar.

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php |   16 +++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/91e5e68be3fe451e90d2100ec6dad5acc40a03b4

-----------------------------------------------------------------------

commit 5d3d0ecfaf2467bb2bed6e39ba7b62e93eaebf2a
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 21:47:01 2011 +0200

    Test returning the profile URL for a Gravatar profile.

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |    9 +++++
 1 files changed, 9 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/5d3d0ecfaf2467bb2bed6e39ba7b62e93eaebf2a

-----------------------------------------------------------------------

commit 9872d4ec998b316636107c8195bda3b0fa6bf5fa
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 21:47:15 2011 +0200

    Return the profile URL for a Gravatar profile.

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php |   15 +++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/9872d4ec998b316636107c8195bda3b0fa6bf5fa

-----------------------------------------------------------------------

commit a2704cf7f87de86b52ce502e95ce157acc8161c0
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 22:17:14 2011 +0200

    Test for a variable base URL with preset constants.

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |    9 +++++
 1 files changed, 9 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/a2704cf7f87de86b52ce502e95ce157acc8161c0

-----------------------------------------------------------------------

commit 4b9570b53a16a092e51b98a8ab81b3d928ce08c7
Author: Gunnar Wrobel <p at rdus.de>
Date:   Tue Jun 7 22:29:24 2011 +0200

    Allow a flexible base URL.

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php |   33 ++++++++++++-
 1 files changed, 31 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/4b9570b53a16a092e51b98a8ab81b3d928ce08c7

-----------------------------------------------------------------------

commit f9ec8dae3d83947d0e3a69ff6dceded163635111
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 06:18:09 2011 +0200

    Do not restrict the profile URL to the JSON format. Rather offer a base URL and allow the calling code to append the desired format.

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php         |    5 ++---
 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |    4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)

http://git.horde.org/horde-git/-/commit/f9ec8dae3d83947d0e3a69ff6dceded163635111

-----------------------------------------------------------------------

commit 0c1d6a11654c242f4f7622ebcc29b20bcc2a2ceb
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 07:17:08 2011 +0200

    Test fetching JSON profile data.

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |   26 +++++
 1 files changed, 26 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/0c1d6a11654c242f4f7622ebcc29b20bcc2a2ceb

-----------------------------------------------------------------------

commit a11395a035e29f65fddb3e8bfa632e5339cf60f9
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 07:17:33 2011 +0200

    Support fetching JSON profile data.

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php |   36 +++++++++++-
 1 files changed, 33 insertions(+), 3 deletions(-)

http://git.horde.org/horde-git/-/commit/a11395a035e29f65fddb3e8bfa632e5339cf60f9

-----------------------------------------------------------------------

commit 0fa601bdde14c054d05a9528c268bc12e06a25ec
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 07:19:27 2011 +0200

    Add an example for fetching JSON encoded profile data.

 .../examples/Horde/Service/Gravatar/fetch_profile.php             |    6 +++++
 1 files changed, 6 insertions(+), 0 deletions(-)
 create mode 100644 framework/Service_Gravatar/examples/Horde/Service/Gravatar/fetch_profile.php

http://git.horde.org/horde-git/-/commit/0fa601bdde14c054d05a9528c268bc12e06a25ec

-----------------------------------------------------------------------

commit 1dc2bac3df9b7a101285dff7cf8ff7891cbbfe35
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 07:29:01 2011 +0200

    We need to pull in the code from the Http library if we do not use autoloading.

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |    6 +++++
 1 files changed, 6 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/1dc2bac3df9b7a101285dff7cf8ff7891cbbfe35

-----------------------------------------------------------------------

commit 6d45736776831fdd9c91946209a7bc8a29d8b16d
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 07:29:29 2011 +0200

    Test fetching the profile data as an array.

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |   15 ++++-
 1 files changed, 12 insertions(+), 3 deletions(-)

http://git.horde.org/horde-git/-/commit/6d45736776831fdd9c91946209a7bc8a29d8b16d

-----------------------------------------------------------------------

commit e2af807fa96650b168a04d621d3e4beac1b8e7bb
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 07:29:42 2011 +0200

    Return profile data as an array.

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php |   14 +++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/e2af807fa96650b168a04d621d3e4beac1b8e7bb

-----------------------------------------------------------------------

commit e6155c4e02eb279551752a51ee90d3d438e7b97a
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 07:30:16 2011 +0200

    Demonstrate how to fetch and print Gravatar profile information.

 .../examples/Horde/Service/Gravatar/get_profile.php               |    6 +++++
 1 files changed, 6 insertions(+), 0 deletions(-)
 create mode 100644 framework/Service_Gravatar/examples/Horde/Service/Gravatar/get_profile.php

http://git.horde.org/horde-git/-/commit/e6155c4e02eb279551752a51ee90d3d438e7b97a

-----------------------------------------------------------------------

commit 2b1e22cfecb5d6575aef92a923b2e02f55238537
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 09:57:43 2011 +0200

    Test fetching the avatar image.

 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |   27 +++++
 1 files changed, 27 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/2b1e22cfecb5d6575aef92a923b2e02f55238537

-----------------------------------------------------------------------

commit 31a3b86323eb74cd2a974432097cc958ef9d8a3c
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 09:58:07 2011 +0200

    Support fetching the avatar image.

 framework/Service_Gravatar/lib/Horde/Service/Gravatar.php |   15 +++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/31a3b86323eb74cd2a974432097cc958ef9d8a3c

-----------------------------------------------------------------------

commit cc6f61f1a5bc6d4f780ae3e52596e09ae16cf8df
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 09:58:56 2011 +0200

    Add an example for fetching the avatar image.

 .../examples/Horde/Service/Gravatar/fetch_avatar.php              |    6 +++++
 1 files changed, 6 insertions(+), 0 deletions(-)
 create mode 100644 framework/Service_Gravatar/examples/Horde/Service/Gravatar/fetch_avatar.php

http://git.horde.org/horde-git/-/commit/cc6f61f1a5bc6d4f780ae3e52596e09ae16cf8df

-----------------------------------------------------------------------

commit 4ae79fe159bac7f29b0abd9863f391f347a3ed17
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 12:46:16 2011 +0200

    Extract to an Autoload.php file.

 .../Service_Gravatar/test/Horde/Service/Gravatar/Autoload.php     |   20 +++++
 .../Service_Gravatar/test/Horde/Service/Gravatar/GravatarTest.php |   14 +---
 2 files changed, 21 insertions(+), 13 deletions(-)
 create mode 100644 framework/Service_Gravatar/test/Horde/Service/Gravatar/Autoload.php

http://git.horde.org/horde-git/-/commit/4ae79fe159bac7f29b0abd9863f391f347a3ed17

-----------------------------------------------------------------------

commit 05ffc16d81df3ce8347ca14d0f431fce0afd4d47
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 12:47:02 2011 +0200

    Add a real server test.

 .../Service_Gravatar/test/Horde/Service/Gravatar/ServerTest.php   |   58 +++++
 .../Service_Gravatar/test/Horde/Service/Gravatar/conf.php.dist    |    2 +
 2 files changed, 60 insertions(+), 0 deletions(-)
 create mode 100644 framework/Service_Gravatar/test/Horde/Service/Gravatar/ServerTest.php
 create mode 100644 framework/Service_Gravatar/test/Horde/Service/Gravatar/conf.php.dist

http://git.horde.org/horde-git/-/commit/05ffc16d81df3ce8347ca14d0f431fce0afd4d47

-----------------------------------------------------------------------

commit 3531a5ea4bc777193bfe9888aa02d209dd0c8b4a
Author: Gunnar Wrobel <p at rdus.de>
Date:   Wed Jun 8 12:47:31 2011 +0200

    Add AllTests.php that combines the two test suites we wrote before.

 .../Service_Gravatar/test/Horde/Service/Gravatar/AllTests.php     |   60 +++++
 1 files changed, 60 insertions(+), 0 deletions(-)
 create mode 100644 framework/Service_Gravatar/test/Horde/Service/Gravatar/AllTests.php

http://git.horde.org/horde-git/-/commit/3531a5ea4bc777193bfe9888aa02d209dd0c8b4a