[commits] Horde branch master updated. 1421a141ab6fff7254a0e4ee3b7dbf1ae0db6037

Michael J. Rubinsky mrubinsk at horde.org
Sun Jun 12 15:43:28 UTC 2011


The branch "master" has been updated.
The following is a summary of the commits.

from: 82daba1714160bd8f04db8fc4be2f18f068fc4d4

5592e11 Initial commit for H4 refactor. Mostly DB:: to Horde_Db
a213f33 some phpdoc, horde_db tweaks
bbc1eac fix adding log entry when creating new tickets
f148c09 fix returning ticket owners
9df4177 typo, don't double log errors
f7a2333 PEAR_Error -> Whups_Exception
c39ef35 PEAR_Error -> Exceptions
bfe303a use a factory for Whups_Driver, some missed PEAR_Error
d4a10e6 autoloading, allow whups_reload action to be loaded by Horde_Form_Action
4f574df query() -> insert()
06ed227 catch exception, fix variable name
0b9f7f9 fix getting attribute descriptions and _getAttributesForType
2f49767 ws
057074a fix constant names from search/replace error
b3b5c86 autoloadable form name
d35df3e autoloadable Whups_Form_SendReminder
4c5daf9 Autoloading for ticket creation form, and custom form type/renderer
7c6a9e2 remove include
612bd88 autoload/php5 for ticket edit form
3ff7b88 removed unused class file
16c90f9 h4-ify queries, autoload forms etc...
48b3398 Refactor Search form for Horde 4
779253c Cleanup lib/Form directory .. fix class name for whupsemail renderer
1126dc1 refactor admin forms for H4
569a92f Fix getVersionInternal
1ec7602 Don't check for empty slugs for uniqueness
7f98153 fix form name
3c95269 fix class name
5b1214c fix filename.
3a08320 fix attribute form name
008289d This method must return an array keyed by id
a8ccb91 ws
0fa12b6 fix form name
acca632 more horde_db method names
1d158b6 Merge branch 'whups'
1421a14 parse error

-----------------------------------------------------------------------

commit 5592e112bb5fc413e0682107369994208b1f75e9
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Jun 6 13:43:49 2011 -0400

    Initial commit for H4 refactor. Mostly DB:: to Horde_Db

 whups/lib/Driver.php                                |   27 +-
 whups/lib/Driver/sql.php                            | 2517 ++++++++++---------
 whups/lib/Forms/Query.php                           |   60 +-
 whups/lib/Query.php                                 |  300 ++--
 whups/lib/Renderer/Query.php                        |   60 +-
 whups/lib/Ticket.php                                |   12 +-
 whups/lib/Whups.php                                 |   13 +-
 whups/migration/4_whups_upgrade_sqlhierarchical.php |    2 +-
 whups/migration/6_whups_upgrade_transactions.php    |   84 +
 whups/migration/7_whups_upgrade_autoincrement.php   |  108 +
 whups/query/index.php                               |    6 +-
 whups/scripts/obliterate.php                        |    5 +-
 whups/search.php                                    |   56 +-
 whups/ticket/delete.php                             |    2 +-
 whups/view.php                                      |    2 +-
 15 files changed, 1763 insertions(+), 1491 deletions(-)
 create mode 100644 whups/migration/6_whups_upgrade_transactions.php
 create mode 100644 whups/migration/7_whups_upgrade_autoincrement.php

http://git.horde.org/horde-git/-/commit/5592e112bb5fc413e0682107369994208b1f75e9

-----------------------------------------------------------------------

commit a213f33fa420d8614eb94265a248a9b95ed4cbc8
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Jun 6 14:18:16 2011 -0400

    some phpdoc, horde_db tweaks

 whups/lib/Driver/sql.php |  126 ++++++++++++++++++++++++++++++++++++++++------
 1 files changed, 110 insertions(+), 16 deletions(-)

http://git.horde.org/horde-git/-/commit/a213f33fa420d8614eb94265a248a9b95ed4cbc8

-----------------------------------------------------------------------

commit bbc1eac33ed1a1cceb8efb1f1fd56135d3368530
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Jun 6 14:30:56 2011 -0400

    fix adding log entry when creating new tickets

 whups/lib/Driver/sql.php |   31 +++++++++++++++++++------------
 1 files changed, 19 insertions(+), 12 deletions(-)

http://git.horde.org/horde-git/-/commit/bbc1eac33ed1a1cceb8efb1f1fd56135d3368530

-----------------------------------------------------------------------

commit f148c09f409bbb094ebc1dc4e217f29c7512d4e1
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Jun 6 14:46:24 2011 -0400

    fix returning ticket owners

 whups/lib/Driver/sql.php |   19 ++++++++++++-------
 1 files changed, 12 insertions(+), 7 deletions(-)

http://git.horde.org/horde-git/-/commit/f148c09f409bbb094ebc1dc4e217f29c7512d4e1

-----------------------------------------------------------------------

commit 9df4177701bc5376b80cca7d535e3cd42767c076
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Jun 6 14:50:37 2011 -0400

    typo, don't double log errors

 whups/lib/Driver/sql.php |   11 +----------
 1 files changed, 1 insertions(+), 10 deletions(-)

http://git.horde.org/horde-git/-/commit/9df4177701bc5376b80cca7d535e3cd42767c076

-----------------------------------------------------------------------

commit f7a23331efcf92de89d2dcbd8837299cb02a2226
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Jun 6 16:03:20 2011 -0400

    PEAR_Error -> Whups_Exception

 whups/admin/index.php |  523 ++++++++++++++++++++++++++-----------------------
 1 files changed, 273 insertions(+), 250 deletions(-)

http://git.horde.org/horde-git/-/commit/f7a23331efcf92de89d2dcbd8837299cb02a2226

-----------------------------------------------------------------------

commit c39ef354f345da46cad1279846f1c6954f3bfe05
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Jun 6 17:17:44 2011 -0400

    PEAR_Error -> Exceptions

 whups/lib/Api.php                                         |  108 +++-------
 whups/lib/Block/Myqueries.php                             |   10 +-
 whups/lib/Block/Myrequests.php                            |    4 -
 whups/lib/Block/Mytickets.php                             |    4 -
 whups/lib/Block/Query.php                                 |    9 +-
 whups/lib/Block/Queuecontents.php                         |   13 +-
 whups/lib/Block/Queuesummary.php                          |    4 -
 whups/lib/Block/Unassigned.php                            |    4 -
 whups/lib/Driver.php                                      |   23 +--
 whups/lib/Forms/Admin/Queue.php                           |   10 +-
 whups/lib/Forms/Admin/User.php                            |   11 +-
 whups/lib/Forms/EditTicket.php                            |   16 +-
 whups/lib/Forms/Query.php                                 |   28 ++-
 whups/lib/Mail.php                                        |   35 +--
 whups/lib/Query.php                                       |   17 +--
 whups/lib/Renderer/Comment.php                            |    3 +-
 whups/lib/Ticket.php                                      |  147 +++++--------
 whups/lib/Whups.php                                       |   15 +-
 whups/lib/tests/ApiTest.php                               |    3 -
 whups/query/index.php                                     |    7 +-
 whups/query/rss.php                                       |    3 +-
 whups/query/run.php                                       |   21 +-
 whups/queue/index.php                                     |   30 ++--
 whups/queue/rss.php                                       |    8 +-
 whups/scripts/bugzilla-import.php                         |   57 +++---
 whups/scripts/mail-filter.php                             |   18 +-
 whups/scripts/upgrades/convert_datatree_shares_to_sql.php |    2 +
 whups/search.php                                          |    9 +-
 whups/templates/reports/stats.inc                         |   11 +-
 whups/ticket/comment.php                                  |    8 +-
 whups/ticket/create.php                                   |   13 +-
 whups/ticket/delete.php                                   |    8 +-
 whups/ticket/delete_attachment.php                        |    8 +-
 whups/ticket/delete_history.php                           |    8 +-
 whups/ticket/queue.php                                    |   12 +-
 whups/ticket/rss.php                                      |    3 -
 whups/ticket/type.php                                     |    8 +-
 whups/ticket/update.php                                   |   19 +-
 whups/ticket/watch.php                                    |   29 ++-
 whups/view.php                                            |   17 +-
 40 files changed, 310 insertions(+), 453 deletions(-)

http://git.horde.org/horde-git/-/commit/c39ef354f345da46cad1279846f1c6954f3bfe05

-----------------------------------------------------------------------

commit bfe303adbf7dde5708920b0a44acb29a913ff353
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Jun 6 17:31:34 2011 -0400

    use a factory for Whups_Driver, some missed PEAR_Error

 whups/lib/Application.php    |    4 +--
 whups/lib/Driver.php         |   30 -------------------------
 whups/lib/Driver/sql.php     |   27 ++++++----------------
 whups/lib/Factory/Driver.php |   50 ++++++++++++++++++++++++++++++++++++++++++
 whups/scripts/obliterate.php |    3 +-
 whups/search/rss.php         |    3 --
 6 files changed, 60 insertions(+), 57 deletions(-)
 create mode 100644 whups/lib/Factory/Driver.php

http://git.horde.org/horde-git/-/commit/bfe303adbf7dde5708920b0a44acb29a913ff353

-----------------------------------------------------------------------

commit d4a10e617454b5f83725b8b7e5ac5469ada5f905
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Jun 6 18:46:21 2011 -0400

    autoloading, allow whups_reload action to be loaded by Horde_Form_Action

 whups/lib/Form/Action/whups_reload.php |   29 ++++++++++++++++++++++++++++
 whups/lib/Forms/Action.php             |   33 --------------------------------
 whups/lib/Forms/Admin/Attribute.php    |    8 +-----
 whups/lib/Forms/Admin/Reply.php        |    4 ---
 whups/lib/Forms/CreateTicket.php       |    2 -
 whups/lib/Forms/EditTicket.php         |    1 -
 6 files changed, 31 insertions(+), 46 deletions(-)
 create mode 100644 whups/lib/Form/Action/whups_reload.php
 delete mode 100644 whups/lib/Forms/Action.php

http://git.horde.org/horde-git/-/commit/d4a10e617454b5f83725b8b7e5ac5469ada5f905

-----------------------------------------------------------------------

commit 4f574df87d5914cc256c8afe4a16eef96a3f46cd
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Jun 6 18:50:28 2011 -0400

    query() -> insert()

 whups/lib/Driver/sql.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/4f574df87d5914cc256c8afe4a16eef96a3f46cd

-----------------------------------------------------------------------

commit 06ed227a905a444606148f823da73d8cb9ca1716
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Thu Jun 9 17:21:26 2011 -0400

    catch exception, fix variable name

 whups/ticket/delete.php |    2 +-
 whups/ticket/index.php  |    8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/06ed227a905a444606148f823da73d8cb9ca1716

-----------------------------------------------------------------------

commit 0b9f7f974937489659bb5eba040b22a47d9a5ca2
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Thu Jun 9 17:31:50 2011 -0400

    fix getting attribute descriptions and _getAttributesForType

 whups/lib/Driver/sql.php |   23 +++++++++++++----------
 1 files changed, 13 insertions(+), 10 deletions(-)

http://git.horde.org/horde-git/-/commit/0b9f7f974937489659bb5eba040b22a47d9a5ca2

-----------------------------------------------------------------------

commit 2f4976709a6c55dd68784857c8eb9f28c5ec06d1
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Thu Jun 9 17:33:26 2011 -0400

    ws

 whups/lib/Forms/Admin/Attribute.php |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/2f4976709a6c55dd68784857c8eb9f28c5ec06d1

-----------------------------------------------------------------------

commit 057074a2311b30d01cb40827466f5fb011c6fd36
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Thu Jun 9 23:30:59 2011 -0400

    fix constant names from search/replace error

 whups/lib/Forms/Query.php |   23 ++++++++++++++---------
 1 files changed, 14 insertions(+), 9 deletions(-)

http://git.horde.org/horde-git/-/commit/057074a2311b30d01cb40827466f5fb011c6fd36

-----------------------------------------------------------------------

commit b3b5c8675b4ac7a7a6008cf0b37c80925192d798
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Thu Jun 9 23:44:17 2011 -0400

    autoloadable form name

 whups/lib/Form/AddComment.php  |   66 ++++++++++++++++++++++++++++++++++++++++
 whups/lib/Forms/AddComment.php |   57 ----------------------------------
 whups/ticket/comment.php       |    4 +--
 3 files changed, 67 insertions(+), 60 deletions(-)
 create mode 100644 whups/lib/Form/AddComment.php
 delete mode 100644 whups/lib/Forms/AddComment.php

http://git.horde.org/horde-git/-/commit/b3b5c8675b4ac7a7a6008cf0b37c80925192d798

-----------------------------------------------------------------------

commit d35df3e7a02938dae6d704bb2b03c9009fd82b7c
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Thu Jun 9 23:51:21 2011 -0400

    autoloadable Whups_Form_SendReminder

 whups/admin/index.php           |    2 +-
 whups/lib/Form/SendReminder.php |   59 +++++++++++++++++++++++++++++++++++++++
 whups/lib/Forms/Admin.php       |   43 ----------------------------
 3 files changed, 60 insertions(+), 44 deletions(-)
 create mode 100644 whups/lib/Form/SendReminder.php
 delete mode 100644 whups/lib/Forms/Admin.php

http://git.horde.org/horde-git/-/commit/d35df3e7a02938dae6d704bb2b03c9009fd82b7c

-----------------------------------------------------------------------

commit 4c5daf924271501690362cde6c4856743cddfdb8
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Fri Jun 10 15:43:06 2011 -0400

    Autoloading for ticket creation form, and custom form type/renderer

 whups/admin/index.php                   |    4 +-
 whups/lib/Api.php                       |    8 +-
 whups/lib/Form/CreateStepFour.php       |   75 +++++++++
 whups/lib/Form/CreateStepOne.php        |   54 +++++++
 whups/lib/Form/CreateStepThree.php      |  107 +++++++++++++
 whups/lib/Form/CreateStepTwo.php        |   62 ++++++++
 whups/lib/Form/Type/whupsemail.php      |    5 +
 whups/lib/Forms/CreateTicket.php        |  262 -------------------------------
 whups/lib/Forms/VarRenderer.php         |    4 +-
 whups/lib/Ui/VarRenderer/Whups.php      |   42 +++++
 whups/lib/Ui/VarRenderer/Whupsemail.php |   42 +++++
 whups/ticket/create.php                 |   13 +-
 12 files changed, 399 insertions(+), 279 deletions(-)
 create mode 100644 whups/lib/Form/CreateStepFour.php
 create mode 100644 whups/lib/Form/CreateStepOne.php
 create mode 100644 whups/lib/Form/CreateStepThree.php
 create mode 100644 whups/lib/Form/CreateStepTwo.php
 create mode 100644 whups/lib/Form/Type/whupsemail.php
 delete mode 100644 whups/lib/Forms/CreateTicket.php
 create mode 100644 whups/lib/Ui/VarRenderer/Whups.php
 create mode 100644 whups/lib/Ui/VarRenderer/Whupsemail.php

http://git.horde.org/horde-git/-/commit/4c5daf924271501690362cde6c4856743cddfdb8

-----------------------------------------------------------------------

commit 7c6a9e2a31ffb08d76527b98037aa7e550fc5581
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Fri Jun 10 15:49:50 2011 -0400

    remove include

 whups/ticket/create.php |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/7c6a9e2a31ffb08d76527b98037aa7e550fc5581

-----------------------------------------------------------------------

commit 612bd8812cfeed9991174fc99e82f5b5689763bc
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Fri Jun 10 15:50:11 2011 -0400

    autoload/php5 for ticket edit form

 whups/lib/Form/EditTicket.php  |  219 ++++++++++++++++++++++++++++++++++++++++
 whups/lib/Forms/EditTicket.php |  219 ----------------------------------------
 2 files changed, 219 insertions(+), 219 deletions(-)
 create mode 100644 whups/lib/Form/EditTicket.php
 delete mode 100644 whups/lib/Forms/EditTicket.php

http://git.horde.org/horde-git/-/commit/612bd8812cfeed9991174fc99e82f5b5689763bc

-----------------------------------------------------------------------

commit 3ff7b881f1135cd64db4f66b48e80ebfd22d1e12
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Fri Jun 10 15:50:43 2011 -0400

    removed unused class file

 whups/lib/Forms/VarRenderer.php |   42 ---------------------------------------
 1 files changed, 0 insertions(+), 42 deletions(-)
 delete mode 100644 whups/lib/Forms/VarRenderer.php

http://git.horde.org/horde-git/-/commit/3ff7b881f1135cd64db4f66b48e80ebfd22d1e12

-----------------------------------------------------------------------

commit 16c90f9f5f445384d1f2fe861c93a913f1c40eb2
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Fri Jun 10 17:19:06 2011 -0400

    h4-ify queries, autoload forms etc...

 whups/lib/Block/Myqueries.php             |    4 +-
 whups/lib/Block/Query.php                 |    8 +-
 whups/lib/Factory/Driver.php              |    2 +-
 whups/lib/Form/AttributeCriterion.php     |   76 +++++
 whups/lib/Form/ChooseQueryNameForLoad.php |   38 +++
 whups/lib/Form/ChooseQueryNameForSave.php |   27 ++
 whups/lib/Form/DateCriterion.php          |   93 ++++++
 whups/lib/Form/DeleteQuery.php            |   46 +++
 whups/lib/Form/GroupCriterion.php         |   51 +++
 whups/lib/Form/InsertBranch.php           |   31 ++
 whups/lib/Form/PropertyCriterion.php      |  116 +++++++
 whups/lib/Form/QueryParameter.php         |   24 ++
 whups/lib/Form/Renderer/Query.php         |  259 +++++++++++++++
 whups/lib/Form/TextCriterion.php          |   49 +++
 whups/lib/Form/Type/whups_email.php       |    5 +
 whups/lib/Form/UserCriterion.php          |   69 ++++
 whups/lib/Forms/Query.php                 |  487 -----------------------------
 whups/lib/Forms/QueryParameterForm.php    |   24 --
 whups/lib/Query.php                       |  281 ++++-------------
 whups/lib/Query/Manager.php               |  192 ++++++++++++
 whups/lib/Renderer/Query.php              |  249 ---------------
 whups/query/index.php                     |   28 +-
 whups/query/rss.php                       |    4 +-
 whups/query/run.php                       |    8 +-
 whups/search.php                          |    6 +-
 25 files changed, 1152 insertions(+), 1025 deletions(-)
 create mode 100644 whups/lib/Form/AttributeCriterion.php
 create mode 100644 whups/lib/Form/ChooseQueryNameForLoad.php
 create mode 100644 whups/lib/Form/ChooseQueryNameForSave.php
 create mode 100644 whups/lib/Form/DateCriterion.php
 create mode 100644 whups/lib/Form/DeleteQuery.php
 create mode 100644 whups/lib/Form/GroupCriterion.php
 create mode 100644 whups/lib/Form/InsertBranch.php
 create mode 100644 whups/lib/Form/PropertyCriterion.php
 create mode 100644 whups/lib/Form/QueryParameter.php
 create mode 100644 whups/lib/Form/Renderer/Query.php
 create mode 100644 whups/lib/Form/TextCriterion.php
 create mode 100644 whups/lib/Form/Type/whups_email.php
 create mode 100644 whups/lib/Form/UserCriterion.php
 delete mode 100644 whups/lib/Forms/Query.php
 delete mode 100644 whups/lib/Forms/QueryParameterForm.php
 create mode 100644 whups/lib/Query/Manager.php
 delete mode 100644 whups/lib/Renderer/Query.php

http://git.horde.org/horde-git/-/commit/16c90f9f5f445384d1f2fe861c93a913f1c40eb2

-----------------------------------------------------------------------

commit 48b3398e6b2e477cea76097156b508fe5e73e49b
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Jun 11 14:46:04 2011 -0400

    Refactor Search form for Horde 4

 whups/lib/Form/Search.php  |  133 ++++++++++++++++++++++++++++++++++++++++++++
 whups/lib/Forms/Search.php |  103 ----------------------------------
 whups/search/rss.php       |    4 +-
 3 files changed, 134 insertions(+), 106 deletions(-)
 create mode 100644 whups/lib/Form/Search.php
 delete mode 100644 whups/lib/Forms/Search.php

http://git.horde.org/horde-git/-/commit/48b3398e6b2e477cea76097156b508fe5e73e49b

-----------------------------------------------------------------------

commit 779253c7ce6934df1182a059bf448a02199ac164
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Jun 11 15:30:08 2011 -0400

    Cleanup lib/Form directory .. fix class name for whupsemail renderer

 whups/lib/Api.php                           |   10 +-
 whups/lib/Form/AttributeCriterion.php       |   76 ---------
 whups/lib/Form/ChooseQueryNameForLoad.php   |   38 -----
 whups/lib/Form/ChooseQueryNameForSave.php   |   27 ----
 whups/lib/Form/CreateStepFour.php           |   75 ---------
 whups/lib/Form/CreateStepOne.php            |   54 -------
 whups/lib/Form/CreateStepThree.php          |  107 -------------
 whups/lib/Form/CreateStepTwo.php            |   62 --------
 whups/lib/Form/DateCriterion.php            |   93 -----------
 whups/lib/Form/DeleteQuery.php              |   46 ------
 whups/lib/Form/EditTicket.php               |  219 ---------------------------
 whups/lib/Form/GroupCriterion.php           |   51 ------
 whups/lib/Form/PropertyCriterion.php        |  116 --------------
 whups/lib/Form/Query/AttributeCriterion.php |   76 +++++++++
 whups/lib/Form/Query/ChooseNameForLoad.php  |   38 +++++
 whups/lib/Form/Query/ChooseNameForSave.php  |   27 ++++
 whups/lib/Form/Query/DateCriterion.php      |   93 +++++++++++
 whups/lib/Form/Query/Delete.php             |   46 ++++++
 whups/lib/Form/Query/GroupCriterion.php     |   51 ++++++
 whups/lib/Form/Query/Parameter.php          |   24 +++
 whups/lib/Form/Query/PropertyCriterion.php  |  116 ++++++++++++++
 whups/lib/Form/Query/TextCriterion.php      |   49 ++++++
 whups/lib/Form/Query/UserCriterion.php      |   69 +++++++++
 whups/lib/Form/QueryParameter.php           |   24 ---
 whups/lib/Form/TextCriterion.php            |   49 ------
 whups/lib/Form/Ticket/CreateStepFour.php    |   75 +++++++++
 whups/lib/Form/Ticket/CreateStepOne.php     |   54 +++++++
 whups/lib/Form/Ticket/CreateStepThree.php   |  107 +++++++++++++
 whups/lib/Form/Ticket/CreateStepTwo.php     |   62 ++++++++
 whups/lib/Form/Ticket/Edit.php              |  219 +++++++++++++++++++++++++++
 whups/lib/Form/Type/whups_email.php         |    5 -
 whups/lib/Form/UserCriterion.php            |   69 ---------
 whups/lib/Ui/VarRenderer/Whups.php          |    2 +-
 whups/lib/Ui/VarRenderer/Whupsemail.php     |   42 -----
 whups/query/index.php                       |   18 +-
 whups/query/run.php                         |    2 +-
 whups/search.php                            |    4 +-
 whups/ticket/create.php                     |   18 +-
 whups/ticket/update.php                     |    8 +-
 39 files changed, 1135 insertions(+), 1186 deletions(-)
 delete mode 100644 whups/lib/Form/AttributeCriterion.php
 delete mode 100644 whups/lib/Form/ChooseQueryNameForLoad.php
 delete mode 100644 whups/lib/Form/ChooseQueryNameForSave.php
 delete mode 100644 whups/lib/Form/CreateStepFour.php
 delete mode 100644 whups/lib/Form/CreateStepOne.php
 delete mode 100644 whups/lib/Form/CreateStepThree.php
 delete mode 100644 whups/lib/Form/CreateStepTwo.php
 delete mode 100644 whups/lib/Form/DateCriterion.php
 delete mode 100644 whups/lib/Form/DeleteQuery.php
 delete mode 100644 whups/lib/Form/EditTicket.php
 delete mode 100644 whups/lib/Form/GroupCriterion.php
 delete mode 100644 whups/lib/Form/PropertyCriterion.php
 create mode 100644 whups/lib/Form/Query/AttributeCriterion.php
 create mode 100644 whups/lib/Form/Query/ChooseNameForLoad.php
 create mode 100644 whups/lib/Form/Query/ChooseNameForSave.php
 create mode 100644 whups/lib/Form/Query/DateCriterion.php
 create mode 100644 whups/lib/Form/Query/Delete.php
 create mode 100644 whups/lib/Form/Query/GroupCriterion.php
 create mode 100644 whups/lib/Form/Query/Parameter.php
 create mode 100644 whups/lib/Form/Query/PropertyCriterion.php
 create mode 100644 whups/lib/Form/Query/TextCriterion.php
 create mode 100644 whups/lib/Form/Query/UserCriterion.php
 delete mode 100644 whups/lib/Form/QueryParameter.php
 delete mode 100644 whups/lib/Form/TextCriterion.php
 create mode 100644 whups/lib/Form/Ticket/CreateStepFour.php
 create mode 100644 whups/lib/Form/Ticket/CreateStepOne.php
 create mode 100644 whups/lib/Form/Ticket/CreateStepThree.php
 create mode 100644 whups/lib/Form/Ticket/CreateStepTwo.php
 create mode 100644 whups/lib/Form/Ticket/Edit.php
 delete mode 100644 whups/lib/Form/Type/whups_email.php
 delete mode 100644 whups/lib/Form/UserCriterion.php
 delete mode 100644 whups/lib/Ui/VarRenderer/Whupsemail.php

http://git.horde.org/horde-git/-/commit/779253c7ce6934df1182a059bf448a02199ac164

-----------------------------------------------------------------------

commit 1126dc1f1a37b6f6c3ed069d4df7472fa6d89934
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Jun 11 21:40:00 2011 -0400

    refactor admin forms for H4

 whups/admin/index.php                         |  297 +++++++++++--------------
 whups/lib/Form/Admin/AddAttribute.php         |   47 ++++
 whups/lib/Form/Admin/AddPriority.html         |   25 ++
 whups/lib/Form/Admin/AddQueue.php             |   33 +++
 whups/lib/Form/Admin/AddReply.php             |   25 ++
 whups/lib/Form/Admin/AddState.php             |   26 +++
 whups/lib/Form/Admin/AddType.php              |   24 ++
 whups/lib/Form/Admin/AddUser.php              |   51 +++++
 whups/lib/Form/Admin/AddVersion.php           |   27 +++
 whups/lib/Form/Admin/CloneType.php            |   37 +++
 whups/lib/Form/Admin/DefaultPriority.php      |   38 ++++
 whups/lib/Form/Admin/DefaultState.php         |   39 ++++
 whups/lib/Form/Admin/DeleteAttribute.php      |   38 ++++
 whups/lib/Form/Admin/DeletePriority.php       |   37 +++
 whups/lib/Form/Admin/DeleteQueue.php          |   41 ++++
 whups/lib/Form/Admin/DeleteReply.php          |   36 +++
 whups/lib/Form/Admin/DeleteState.php          |   36 +++
 whups/lib/Form/Admin/DeleteType.php           |   52 +++++
 whups/lib/Form/Admin/DeleteVersion.php        |   38 ++++
 whups/lib/Form/Admin/EditAttributeStepOne.php |   39 ++++
 whups/lib/Form/Admin/EditAttributeStepTwo.php |   59 +++++
 whups/lib/Form/Admin/EditPriorityStepOne.php  |   36 +++
 whups/lib/Form/Admin/EditPriorityStepTwo.php  |   35 +++
 whups/lib/Form/Admin/EditQueueStepOne.php     |   42 ++++
 whups/lib/Form/Admin/EditQueueStepTwo.php     |   99 ++++++++
 whups/lib/Form/Admin/EditReplyStepOne.php     |   39 ++++
 whups/lib/Form/Admin/EditReplyStepTwo.php     |   41 ++++
 whups/lib/Form/Admin/EditStateStepOne.php     |   34 +++
 whups/lib/Form/Admin/EditStateStepTwo.php     |   36 +++
 whups/lib/Form/Admin/EditTypeStepOne.php      |   39 ++++
 whups/lib/Form/Admin/EditTypeStepTwo.php      |  101 +++++++++
 whups/lib/Form/Admin/EditUser.php             |   44 ++++
 whups/lib/Form/Admin/EditVersionStepOne.php   |   37 +++
 whups/lib/Form/Admin/EditVersionStepTwo.php   |   37 +++
 whups/lib/Form/Ticket/EditTicket.php          |  219 ++++++++++++++++++
 whups/lib/Forms/Admin/Attribute.php           |  146 ------------
 whups/lib/Forms/Admin/Priority.php            |  123 ----------
 whups/lib/Forms/Admin/Queue.php               |  180 ---------------
 whups/lib/Forms/Admin/Reply.php               |  107 ---------
 whups/lib/Forms/Admin/State.php               |  123 ----------
 whups/lib/Forms/Admin/Type.php                |  205 -----------------
 whups/lib/Forms/Admin/User.php                |   81 -------
 whups/lib/Forms/Admin/Version.php             |  102 ---------
 43 files changed, 1716 insertions(+), 1235 deletions(-)
 create mode 100644 whups/lib/Form/Admin/AddAttribute.php
 create mode 100644 whups/lib/Form/Admin/AddPriority.html
 create mode 100644 whups/lib/Form/Admin/AddQueue.php
 create mode 100644 whups/lib/Form/Admin/AddReply.php
 create mode 100644 whups/lib/Form/Admin/AddState.php
 create mode 100644 whups/lib/Form/Admin/AddType.php
 create mode 100644 whups/lib/Form/Admin/AddUser.php
 create mode 100644 whups/lib/Form/Admin/AddVersion.php
 create mode 100644 whups/lib/Form/Admin/CloneType.php
 create mode 100644 whups/lib/Form/Admin/DefaultPriority.php
 create mode 100644 whups/lib/Form/Admin/DefaultState.php
 create mode 100644 whups/lib/Form/Admin/DeleteAttribute.php
 create mode 100644 whups/lib/Form/Admin/DeletePriority.php
 create mode 100644 whups/lib/Form/Admin/DeleteQueue.php
 create mode 100644 whups/lib/Form/Admin/DeleteReply.php
 create mode 100644 whups/lib/Form/Admin/DeleteState.php
 create mode 100644 whups/lib/Form/Admin/DeleteType.php
 create mode 100644 whups/lib/Form/Admin/DeleteVersion.php
 create mode 100644 whups/lib/Form/Admin/EditAttributeStepOne.php
 create mode 100644 whups/lib/Form/Admin/EditAttributeStepTwo.php
 create mode 100644 whups/lib/Form/Admin/EditPriorityStepOne.php
 create mode 100644 whups/lib/Form/Admin/EditPriorityStepTwo.php
 create mode 100644 whups/lib/Form/Admin/EditQueueStepOne.php
 create mode 100644 whups/lib/Form/Admin/EditQueueStepTwo.php
 create mode 100644 whups/lib/Form/Admin/EditReplyStepOne.php
 create mode 100644 whups/lib/Form/Admin/EditReplyStepTwo.php
 create mode 100644 whups/lib/Form/Admin/EditStateStepOne.php
 create mode 100644 whups/lib/Form/Admin/EditStateStepTwo.php
 create mode 100644 whups/lib/Form/Admin/EditTypeStepOne.php
 create mode 100644 whups/lib/Form/Admin/EditTypeStepTwo.php
 create mode 100644 whups/lib/Form/Admin/EditUser.php
 create mode 100644 whups/lib/Form/Admin/EditVersionStepOne.php
 create mode 100644 whups/lib/Form/Admin/EditVersionStepTwo.php
 create mode 100644 whups/lib/Form/Ticket/EditTicket.php
 delete mode 100644 whups/lib/Forms/Admin/Attribute.php
 delete mode 100644 whups/lib/Forms/Admin/Priority.php
 delete mode 100644 whups/lib/Forms/Admin/Queue.php
 delete mode 100644 whups/lib/Forms/Admin/Reply.php
 delete mode 100644 whups/lib/Forms/Admin/State.php
 delete mode 100644 whups/lib/Forms/Admin/Type.php
 delete mode 100644 whups/lib/Forms/Admin/User.php
 delete mode 100644 whups/lib/Forms/Admin/Version.php

http://git.horde.org/horde-git/-/commit/1126dc1f1a37b6f6c3ed069d4df7472fa6d89934

-----------------------------------------------------------------------

commit 569a92faa6b1144cb4d72391ef6f03ac9f38b5a9
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Jun 11 21:46:23 2011 -0400

    Fix getVersionInternal
    
    Horde_Db_Adapter#selectAssoc only works with 2 column selects

 whups/lib/Driver/sql.php |   29 +++++++++++++++++++++--------
 1 files changed, 21 insertions(+), 8 deletions(-)

http://git.horde.org/horde-git/-/commit/569a92faa6b1144cb4d72391ef6f03ac9f38b5a9

-----------------------------------------------------------------------

commit 1ec7602781f93c94b771cab917e2cdcb3244f2f7
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Jun 11 21:54:43 2011 -0400

    Don't check for empty slugs for uniqueness

 whups/lib/Driver/sql.php |   24 +++++++++++++-----------
 1 files changed, 13 insertions(+), 11 deletions(-)

http://git.horde.org/horde-git/-/commit/1ec7602781f93c94b771cab917e2cdcb3244f2f7

-----------------------------------------------------------------------

commit 7f98153ed17afe77a66ef8dcb1e2b5935bb3e524
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Jun 11 21:58:02 2011 -0400

    fix form name

 whups/admin/index.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/7f98153ed17afe77a66ef8dcb1e2b5935bb3e524

-----------------------------------------------------------------------

commit 3c952695ec5a9c160b9acb13b19a08d248944482
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Jun 11 22:03:25 2011 -0400

    fix class name

 whups/lib/Form/Admin/AddAttribute.php    |    2 +-
 whups/lib/Form/Admin/EditTypeStepTwo.php |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/3c952695ec5a9c160b9acb13b19a08d248944482

-----------------------------------------------------------------------

commit 5b1214c53e55f09c656ec6c9847c190e457f4070
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Jun 11 22:08:34 2011 -0400

    fix filename.

 whups/lib/Form/Admin/AddPriority.html |   25 -------------------------
 whups/lib/Form/Admin/AddPriority.php  |   25 +++++++++++++++++++++++++
 2 files changed, 25 insertions(+), 25 deletions(-)
 delete mode 100644 whups/lib/Form/Admin/AddPriority.html
 create mode 100644 whups/lib/Form/Admin/AddPriority.php

http://git.horde.org/horde-git/-/commit/5b1214c53e55f09c656ec6c9847c190e457f4070

-----------------------------------------------------------------------

commit 3a08320b38b827c081eea3ba7421b1f32463a9d2
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sat Jun 11 22:09:16 2011 -0400

    fix attribute form name

 whups/admin/index.php |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

http://git.horde.org/horde-git/-/commit/3a08320b38b827c081eea3ba7421b1f32463a9d2

-----------------------------------------------------------------------

commit 008289d9ca60ee1332dd278feb112b593d9e880a
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sun Jun 12 11:36:21 2011 -0400

    This method must return an array keyed by id

 whups/lib/Driver/sql.php |   11 +++++++----
 1 files changed, 7 insertions(+), 4 deletions(-)

http://git.horde.org/horde-git/-/commit/008289d9ca60ee1332dd278feb112b593d9e880a

-----------------------------------------------------------------------

commit a8ccb911f75ffbfcd3d6e8b47b3a2460a0446e21
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sun Jun 12 11:36:50 2011 -0400

    ws

 whups/admin/index.php |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/a8ccb911f75ffbfcd3d6e8b47b3a2460a0446e21

-----------------------------------------------------------------------

commit 0fa12b6c05611abb4754b5d0b4c397a18ca333a2
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sun Jun 12 11:37:39 2011 -0400

    fix form name

 whups/lib/Form/Admin/EditAttributeStepTwo.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/0fa12b6c05611abb4754b5d0b4c397a18ca333a2

-----------------------------------------------------------------------

commit acca632c55e6be95c57d6403ac8b209577c09e71
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sun Jun 12 11:39:19 2011 -0400

    more horde_db method names

 whups/lib/Driver/sql.php |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/acca632c55e6be95c57d6403ac8b209577c09e71

-----------------------------------------------------------------------

commit 1d158b6c23fbc2d3264f1f2721cf538315c4f646
Merge: 82daba1 acca632
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sun Jun 12 11:41:25 2011 -0400

    Merge branch 'whups'

 whups/admin/index.php                                     |  828 ++--
 whups/lib/Api.php                                         |  120 +-
 whups/lib/Application.php                                 |    4 +-
 whups/lib/Block/Myqueries.php                             |   14 +-
 whups/lib/Block/Myrequests.php                            |    4 -
 whups/lib/Block/Mytickets.php                             |    4 -
 whups/lib/Block/Query.php                                 |   17 +-
 whups/lib/Block/Queuecontents.php                         |   13 +-
 whups/lib/Block/Queuesummary.php                          |    4 -
 whups/lib/Block/Unassigned.php                            |    4 -
 whups/lib/Driver.php                                      |   80 +-
 whups/lib/Driver/sql.php                                  | 2716 +++++++------
 whups/lib/Factory/Driver.php                              |   50 +
 whups/lib/Form/Action/whups_reload.php                    |   29 +
 whups/lib/Form/AddComment.php                             |   66 +
 whups/lib/Form/Admin/AddAttribute.php                     |   47 +
 whups/lib/Form/Admin/AddPriority.php                      |   25 +
 whups/lib/Form/Admin/AddQueue.php                         |   33 +
 whups/lib/Form/Admin/AddReply.php                         |   25 +
 whups/lib/Form/Admin/AddState.php                         |   26 +
 whups/lib/Form/Admin/AddType.php                          |   24 +
 whups/lib/Form/Admin/AddUser.php                          |   51 +
 whups/lib/Form/Admin/AddVersion.php                       |   27 +
 whups/lib/Form/Admin/CloneType.php                        |   37 +
 whups/lib/Form/Admin/DefaultPriority.php                  |   38 +
 whups/lib/Form/Admin/DefaultState.php                     |   39 +
 whups/lib/Form/Admin/DeleteAttribute.php                  |   38 +
 whups/lib/Form/Admin/DeletePriority.php                   |   37 +
 whups/lib/Form/Admin/DeleteQueue.php                      |   41 +
 whups/lib/Form/Admin/DeleteReply.php                      |   36 +
 whups/lib/Form/Admin/DeleteState.php                      |   36 +
 whups/lib/Form/Admin/DeleteType.php                       |   52 +
 whups/lib/Form/Admin/DeleteVersion.php                    |   38 +
 whups/lib/Form/Admin/EditAttributeStepOne.php             |   39 +
 whups/lib/Form/Admin/EditAttributeStepTwo.php             |   59 +
 whups/lib/Form/Admin/EditPriorityStepOne.php              |   36 +
 whups/lib/Form/Admin/EditPriorityStepTwo.php              |   35 +
 whups/lib/Form/Admin/EditQueueStepOne.php                 |   42 +
 whups/lib/Form/Admin/EditQueueStepTwo.php                 |   99 +
 whups/lib/Form/Admin/EditReplyStepOne.php                 |   39 +
 whups/lib/Form/Admin/EditReplyStepTwo.php                 |   41 +
 whups/lib/Form/Admin/EditStateStepOne.php                 |   34 +
 whups/lib/Form/Admin/EditStateStepTwo.php                 |   36 +
 whups/lib/Form/Admin/EditTypeStepOne.php                  |   39 +
 whups/lib/Form/Admin/EditTypeStepTwo.php                  |  101 +
 whups/lib/Form/Admin/EditUser.php                         |   44 +
 whups/lib/Form/Admin/EditVersionStepOne.php               |   37 +
 whups/lib/Form/Admin/EditVersionStepTwo.php               |   37 +
 whups/lib/Form/InsertBranch.php                           |   31 +
 whups/lib/Form/Query/AttributeCriterion.php               |   76 +
 whups/lib/Form/Query/ChooseNameForLoad.php                |   38 +
 whups/lib/Form/Query/ChooseNameForSave.php                |   27 +
 whups/lib/Form/Query/DateCriterion.php                    |   93 +
 whups/lib/Form/Query/Delete.php                           |   46 +
 whups/lib/Form/Query/GroupCriterion.php                   |   51 +
 whups/lib/Form/Query/Parameter.php                        |   24 +
 whups/lib/Form/Query/PropertyCriterion.php                |  116 +
 whups/lib/Form/Query/TextCriterion.php                    |   49 +
 whups/lib/Form/Query/UserCriterion.php                    |   69 +
 whups/lib/Form/Renderer/Query.php                         |  259 ++
 whups/lib/Form/Search.php                                 |  133 +
 whups/lib/Form/SendReminder.php                           |   59 +
 whups/lib/Form/Ticket/CreateStepFour.php                  |   75 +
 whups/lib/Form/Ticket/CreateStepOne.php                   |   54 +
 whups/lib/Form/Ticket/CreateStepThree.php                 |  107 +
 whups/lib/Form/Ticket/CreateStepTwo.php                   |   62 +
 whups/lib/Form/Ticket/Edit.php                            |  219 +
 whups/lib/Form/Ticket/EditTicket.php                      |  219 +
 whups/lib/Form/Type/whupsemail.php                        |    5 +
 whups/lib/Forms/Action.php                                |   33 -
 whups/lib/Forms/AddComment.php                            |   57 -
 whups/lib/Forms/Admin.php                                 |   43 -
 whups/lib/Forms/Admin/Attribute.php                       |  150 -
 whups/lib/Forms/Admin/Priority.php                        |  123 -
 whups/lib/Forms/Admin/Queue.php                           |  178 -
 whups/lib/Forms/Admin/Reply.php                           |  111 -
 whups/lib/Forms/Admin/State.php                           |  123 -
 whups/lib/Forms/Admin/Type.php                            |  205 -
 whups/lib/Forms/Admin/User.php                            |   80 -
 whups/lib/Forms/Admin/Version.php                         |  102 -
 whups/lib/Forms/CreateTicket.php                          |  264 --
 whups/lib/Forms/EditTicket.php                            |  216 -
 whups/lib/Forms/Query.php                                 |  480 ---
 whups/lib/Forms/QueryParameterForm.php                    |   24 -
 whups/lib/Forms/Search.php                                |  103 -
 whups/lib/Forms/VarRenderer.php                           |   42 -
 whups/lib/Mail.php                                        |   35 +-
 whups/lib/Query.php                                       |  592 +--
 whups/lib/Query/Manager.php                               |  192 +
 whups/lib/Renderer/Comment.php                            |    3 +-
 whups/lib/Renderer/Query.php                              |  249 --
 whups/lib/Ticket.php                                      |  159 +-
 whups/lib/Ui/VarRenderer/Whups.php                        |   42 +
 whups/lib/Whups.php                                       |   28 +-
 whups/lib/tests/ApiTest.php                               |    3 -
 whups/migration/4_whups_upgrade_sqlhierarchical.php       |    2 +-
 whups/migration/6_whups_upgrade_transactions.php          |   84 +
 whups/migration/7_whups_upgrade_autoincrement.php         |  108 +
 whups/query/index.php                                     |   41 +-
 whups/query/rss.php                                       |    7 +-
 whups/query/run.php                                       |   29 +-
 whups/queue/index.php                                     |   30 +-
 whups/queue/rss.php                                       |    8 +-
 whups/scripts/bugzilla-import.php                         |   57 +-
 whups/scripts/mail-filter.php                             |   18 +-
 whups/scripts/obliterate.php                              |    8 +-
 whups/scripts/upgrades/convert_datatree_shares_to_sql.php |    2 +
 whups/search.php                                          |   75 +-
 whups/search/rss.php                                      |    7 +-
 whups/templates/reports/stats.inc                         |   11 +-
 whups/ticket/comment.php                                  |   12 +-
 whups/ticket/create.php                                   |   36 +-
 whups/ticket/delete.php                                   |    8 +-
 whups/ticket/delete_attachment.php                        |    8 +-
 whups/ticket/delete_history.php                           |    8 +-
 whups/ticket/index.php                                    |    8 +-
 whups/ticket/queue.php                                    |   12 +-
 whups/ticket/rss.php                                      |    3 -
 whups/ticket/type.php                                     |    8 +-
 whups/ticket/update.php                                   |   27 +-
 whups/ticket/watch.php                                    |   29 +-
 whups/view.php                                            |   19 +-
 122 files changed, 6194 insertions(+), 5241 deletions(-)

http://git.horde.org/horde-git/-/commit/1d158b6c23fbc2d3264f1f2721cf538315c4f646

-----------------------------------------------------------------------

commit 1421a141ab6fff7254a0e4ee3b7dbf1ae0db6037
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Sun Jun 12 11:43:07 2011 -0400

    parse error

 whups/ticket/watch.php |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/1421a141ab6fff7254a0e4ee3b7dbf1ae0db6037




More information about the commits mailing list