[commits] Horde branch master updated. 054b0cd0bc27ed350ac56b2df45520517812d353

[Michael J. Rubinsky]

The branch "master" has been updated.
The following is a summary of the commits.

from: e1b5208e896676eaebc4f6c7de8f59bbe60cb99b

4b73847 Enforce the specification's rule that says a SYNC *MUST* come before a PING.
876070e phpdoc/wrapping/comments
575c728 No need for this to return anything, and in fact it is not expected to anywhere in existing client code.
b20610b This is already logged by the db adapter.
054b0cd BFN

-----------------------------------------------------------------------

commit 4b7384756feff33d5727f462022bc93c56b583ee
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Wed Jun 29 02:43:20 2011 -0400

    Enforce the specification's rule that says a SYNC *MUST* come before a PING.
    
    According to the docs, this is an illegal request. This should really be dealt with
    by sending a 400 response, but this causes issues in some broken clients. Instead,
    we prematurely expire the PING heartbeat. This prevents race conditions with certain
    broken clients.
    
    Also, if the state disappears out from under us (as would happen if the user/admin
    explicitly clears the state via the UI), force a SYNC operation if we find ourselves
    in a PING. This, too, is to prevent broken clients from runaway PING loops that
    never pick up changes.

 framework/ActiveSync/lib/Horde/ActiveSync.php                     |   13 +++-
 .../ActiveSync/lib/Horde/ActiveSync/Exception/InvalidRequest.php  |    4 +
 framework/ActiveSync/lib/Horde/ActiveSync/Exception/StateGone.php |    4 +
 framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php        |   21 +++++
 framework/ActiveSync/lib/Horde/ActiveSync/State/History.php       |   21 ++---
 framework/ActiveSync/package.xml                                  |   12 ++-
 6 files changed, 58 insertions(+), 17 deletions(-)
 create mode 100644 framework/ActiveSync/lib/Horde/ActiveSync/Exception/InvalidRequest.php
 create mode 100644 framework/ActiveSync/lib/Horde/ActiveSync/Exception/StateGone.php

http://git.horde.org/horde-git/-/commit/4b7384756feff33d5727f462022bc93c56b583ee

-----------------------------------------------------------------------

commit 876070ef768ae7178a11510234e03fb4ce66b469
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Wed Jun 29 02:51:28 2011 -0400

    phpdoc/wrapping/comments

 framework/ActiveSync/lib/Horde/ActiveSync/State/History.php |   45 +++++------
 1 files changed, 22 insertions(+), 23 deletions(-)

http://git.horde.org/horde-git/-/commit/876070ef768ae7178a11510234e03fb4ce66b469

-----------------------------------------------------------------------

commit 575c7287b69dd6e59529827c0431eab89688fafd
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Wed Jun 29 02:51:43 2011 -0400

    No need for this to return anything, and in fact it is not expected to anywhere
    in existing client code.

 framework/ActiveSync/lib/Horde/ActiveSync/State/History.php |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/575c7287b69dd6e59529827c0431eab89688fafd

-----------------------------------------------------------------------

commit b20610b900f68a4cdebe0e80fd3b336ef7ebd44f
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Wed Jun 29 02:52:26 2011 -0400

    This is already logged by the db adapter.

 framework/ActiveSync/lib/Horde/ActiveSync/State/History.php |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/b20610b900f68a4cdebe0e80fd3b336ef7ebd44f

-----------------------------------------------------------------------

commit 054b0cd0bc27ed350ac56b2df45520517812d353
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Wed Jun 29 02:56:52 2011 -0400

    BFN

 framework/ActiveSync/package.xml |    2 ++
 horde/docs/CHANGES               |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/054b0cd0bc27ed350ac56b2df45520517812d353