[commits] Horde branch master updated. 0c1b0b139a5b0a8273df56adf26b724648bdb318

Jan Schneider jan at horde.org
Thu Mar 3 22:44:03 UTC 2011


The branch "master" has been updated.
The following is a summary of the commits.

from: 543ba3fe446447834312047e000563541f9245a1

acb2fb8 Move test into correct place. We don't need a looger.
5c3ece0 Add a failing test for SQLite driver breaking table when changing the primary key column.
845f37f There is no 'id' option, there is only a 'primaryKey' option that defaults to 'id'. Fixes first bug.
c40abbd Style
3fe425d Horde_Db_Adapter_Base_TableDefinition::primaryKey() expects columns, not the complete index object. Fixed the final bug.
0c1b0b1 One more failing test. Adding autoincrementing still not working with SQLite.

-----------------------------------------------------------------------

commit acb2fb8fd166e4b0b22e688a42034ffd408c6e86
Author: Jan Schneider <jan at horde.org>
Date:   Thu Mar 3 22:27:31 2011 +0100

    Move test into correct place. We don't need a looger.

 framework/Db/test/Horde/Db/Migration/BaseTest.php     |   10 +++++
 framework/Db/test/Horde/Db/Migration/MigratorTest.php |   30 +++++------------
 2 files changed, 19 insertions(+), 21 deletions(-)

http://git.horde.org/horde-git/-/commit/acb2fb8fd166e4b0b22e688a42034ffd408c6e86

-----------------------------------------------------------------------

commit 5c3ece076b9c7fda59207c69b81fa726d1756b31
Author: Jan Schneider <jan at horde.org>
Date:   Thu Mar 3 22:35:43 2011 +0100

    Add a failing test for SQLite driver breaking table when changing the primary
    key column.

 framework/Db/test/Horde/Db/Migration/BaseTest.php |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/5c3ece076b9c7fda59207c69b81fa726d1756b31

-----------------------------------------------------------------------

commit 845f37f89bb26346fbd1d7f6e08a7318e5c9b7ec
Author: Jan Schneider <jan at horde.org>
Date:   Thu Mar 3 22:57:30 2011 +0100

    There is no 'id' option, there is only a 'primaryKey' option that defaults to 'id'. Fixes first bug.

 framework/Db/lib/Horde/Db/Adapter/Base/Schema.php                 |   73 ++---
 framework/Db/lib/Horde/Db/Adapter/Sqlite/Schema.php               |    2 +-
 .../test/Horde/Db/fixtures/migrations/3_innocent_jointable1.php   |    2 +-
 .../fixtures/migrations_with_duplicate/3_innocent_jointable2.php  |    2 +-
 .../migrations_with_missing_versions/4_innocent_jointable3.php    |    2 +-
 5 files changed, 39 insertions(+), 42 deletions(-)

http://git.horde.org/horde-git/-/commit/845f37f89bb26346fbd1d7f6e08a7318e5c9b7ec

-----------------------------------------------------------------------

commit c40abbd856bf6f2fa817ef62efef697b97490864
Author: Jan Schneider <jan at horde.org>
Date:   Thu Mar 3 23:11:12 2011 +0100

    Style

 framework/Db/lib/Horde/Db/Adapter/Base/TableDefinition.php |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

http://git.horde.org/horde-git/-/commit/c40abbd856bf6f2fa817ef62efef697b97490864

-----------------------------------------------------------------------

commit 3fe425d8f60b3433bc8e00e29113fd08fbdea07c
Author: Jan Schneider <jan at horde.org>
Date:   Thu Mar 3 23:12:03 2011 +0100

    Horde_Db_Adapter_Base_TableDefinition::primaryKey() expects columns, not the
    complete index object. Fixed the final bug.

 framework/Db/lib/Horde/Db/Adapter/Sqlite/Schema.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/3fe425d8f60b3433bc8e00e29113fd08fbdea07c

-----------------------------------------------------------------------

commit 0c1b0b139a5b0a8273df56adf26b724648bdb318
Author: Jan Schneider <jan at horde.org>
Date:   Thu Mar 3 23:41:33 2011 +0100

    One more failing test. Adding autoincrementing still not working with SQLite.

 framework/Db/test/Horde/Db/Migration/BaseTest.php |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/0c1b0b139a5b0a8273df56adf26b724648bdb318




More information about the commits mailing list