[commits] Horde branch master updated. 317a1ea3e26d7a49c89c34c1770b9321e17b9d72

[Michael M Slusarz]

The branch "master" has been updated.
The following is a summary of the commits.

from: 0370500171caecd3934c9d94b9b7f4dc793de229

5b93762 Optimize forwarding by reusing stream resource
5910bac Cleanup vcard attachment code
e080814 Fix intermittent attachment loss when composing messages.
317a1ea Sanity checking when viewing compose attachments

-----------------------------------------------------------------------

commit 5b937620d25978e742f6be078733cefe6494dcf4
Author: Michael M Slusarz <slusarz at horde.org>
Date:   Mon Oct 31 21:40:45 2011 -0600

    Optimize forwarding by reusing stream resource

 imp/lib/Compose.php |   23 ++++++++++++++---------
 1 files changed, 14 insertions(+), 9 deletions(-)

http://git.horde.org/horde-git/-/commit/5b937620d25978e742f6be078733cefe6494dcf4

-----------------------------------------------------------------------

commit 5910bac6d55998b688a409d04c0e029bad7b2aeb
Author: Michael M Slusarz <slusarz at horde.org>
Date:   Mon Oct 31 22:32:50 2011 -0600

    Cleanup vcard attachment code

 imp/compose.php     |    7 +----
 imp/lib/Compose.php |   65 +++++++++++++++++++++++++--------------------------
 2 files changed, 34 insertions(+), 38 deletions(-)

http://git.horde.org/horde-git/-/commit/5910bac6d55998b688a409d04c0e029bad7b2aeb

-----------------------------------------------------------------------

commit e08081438cb1a09638897cabd1e46fb3e1120e59
Author: Michael M Slusarz <slusarz at horde.org>
Date:   Mon Oct 31 22:43:50 2011 -0600

    Fix intermittent attachment loss when composing messages.
    
    Fixed by implementing Serializable for IMP_Compose.
    
    In the server access when attaching a file, the Horde_Mime_Part contains
    the data of the attachment, stored in a stream.  When saving the
    IMP_Compose object to the session, this part was being serialized with
    the entire contents of the data into the part.  Not good for session
    sizes, and this data was periodically being lost.  We already have the
    attachment data stored (either in VFS or filesystem), so we don't need
    this data to be stored in the MIME Part - scrub it before serializing.
    
    For the record, the way to reproduce:
    
    1. Use dynamic view
    2. Open compose screen
    3. Attach a file
    4. Insert at least one character in body (to trigger auto-save draft)
    5. Wait for an auto-save draft
    6. Try to view contents of attachment - error will be thrown.

 imp/docs/CHANGES            |    1 +
 imp/lib/Compose.php         |   78 +++++++++++++++++++++++++++++++++---------
 imp/lib/Factory/Compose.php |    1 -
 imp/package.xml             |    1 +
 4 files changed, 63 insertions(+), 18 deletions(-)

http://git.horde.org/horde-git/-/commit/e08081438cb1a09638897cabd1e46fb3e1120e59

-----------------------------------------------------------------------

commit 317a1ea3e26d7a49c89c34c1770b9321e17b9d72
Author: Michael M Slusarz <slusarz at horde.org>
Date:   Mon Oct 31 22:50:08 2011 -0600

    Sanity checking when viewing compose attachments

 imp/view.php |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/317a1ea3e26d7a49c89c34c1770b9321e17b9d72