[commits] Horde branch master updated. f2cea2dad967b03f3f27b33226fe25d6d74cb767
Michael M Slusarz
slusarz at horde.org
Wed Nov 23 11:47:46 UTC 2011
The branch "master" has been updated.
The following is a summary of the commits.
from: bb8a59fdebb940e0e3dfb67dd74ab71efd530141
f2cea2d Fix critical issues with Autoload Caching.
-----------------------------------------------------------------------
commit f2cea2dad967b03f3f27b33226fe25d6d74cb767
Author: Michael M Slusarz <slusarz at horde.org>
Date: Wed Nov 23 04:08:59 2011 -0700
Fix critical issues with Autoload Caching.
First, we should only be writing cache data if the cache array has
changed; otherwise, we are creating a 0% hit rate on the cache entry.
Internally Cache temp file and extension_loaded() values - the latter
is an especially expensive call (see CODING_STANDARDS).
Let file_[get|put]_contents() do all the work regarding write
permissions - no need to explicitly check.
Fix critical logic error in mapToPath() - we can't use isset() because
we may be looking null values (e.g. class names that don't map to a
file). Need to use array_key_exists() instead.
framework/Autoloader_Cache/lib/Horde/Autoloader/Cache.php | 98 ++++++++++---
1 files changed, 75 insertions(+), 23 deletions(-)
http://git.horde.org/horde-git/-/commit/f2cea2dad967b03f3f27b33226fe25d6d74cb767
More information about the commits
mailing list