[commits] Horde branch master updated. 70b2c6d70e70e7fd866bedf98fd2658a94b82879

[Michael J. Rubinsky]

The branch "master" has been updated.
The following is a summary of the commits.

from: 8ddfca1ede8a7af90fcd9162059e3323b1a15fbc

4221b6c We need $country in _create(), not in __construct
5022988b Don't allow changing units on weather data objects after the request.
4f16380 BFN
88a6815 Fix tests for new way of updating $units
70b2c6d We don't ever need (nor should we allow) __set() for these objects.

-----------------------------------------------------------------------

commit 4221b6c41701ee2b9104300338c973e0376cbef4
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Nov 28 23:31:23 2011 -0500

    We need $country in _create(), not in __construct

 timeobjects/lib/Driver/Weather.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/4221b6c41701ee2b9104300338c973e0376cbef4

-----------------------------------------------------------------------

commit 5022988bee6c675827bdc655494280979c437151
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Nov 28 23:32:29 2011 -0500

    Don't allow changing units on weather data objects after the request.
    
    This can lead to, among other things, incorrect units being displayed
    due to a chicken-egg problem in some cases. See Bug: 10804

 .../Service_Weather/lib/Horde/Service/Weather/Current/Base.php    |    8 --
 .../Service_Weather/lib/Horde/Service/Weather/Current/Google.php  |    2 +-
 .../lib/Horde/Service/Weather/Current/WeatherUnderground.php      |   16 ++--
 .../Service_Weather/lib/Horde/Service/Weather/Current/Wwo.php     |    8 +-
 .../Service_Weather/lib/Horde/Service/Weather/Forecast/Base.php   |    7 --
 .../Service_Weather/lib/Horde/Service/Weather/Forecast/Google.php |    1 -
 framework/Service_Weather/lib/Horde/Service/Weather/Google.php    |    2 +
 .../Service_Weather/lib/Horde/Service/Weather/Period/Base.php     |    8 --
 .../Service_Weather/lib/Horde/Service/Weather/Period/Google.php   |    5 +-
 .../lib/Horde/Service/Weather/Period/WeatherUnderground.php       |    8 +-
 .../Service_Weather/lib/Horde/Service/Weather/Period/Wwo.php      |    6 +-
 11 files changed, 24 insertions(+), 47 deletions(-)

http://git.horde.org/horde-git/-/commit/5022988bee6c675827bdc655494280979c437151

-----------------------------------------------------------------------

commit 4f16380df8c57b15c094ca7f295f022d623c162c
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Nov 28 23:45:51 2011 -0500

    BFN

 framework/Service_Weather/package.xml |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/4f16380df8c57b15c094ca7f295f022d623c162c

-----------------------------------------------------------------------

commit 88a68151ff9b0994c7afb019f54c2d61a07c24be
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Nov 28 23:57:58 2011 -0500

    Fix tests for new way of updating $units

 .../Service_Weather/test/Horde/Service/Weather/GoogleTest.php     |   15 +++--
 .../test/Horde/Service/Weather/WundergroundTest.php               |    6 +-
 framework/Service_Weather/test/Horde/Service/Weather/WwoTest.php  |   11 ++-
 3 files changed, 18 insertions(+), 14 deletions(-)

http://git.horde.org/horde-git/-/commit/88a68151ff9b0994c7afb019f54c2d61a07c24be

-----------------------------------------------------------------------

commit 70b2c6d70e70e7fd866bedf98fd2658a94b82879
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Mon Nov 28 23:58:38 2011 -0500

    We don't ever need (nor should we allow) __set() for these objects.

 .../Service_Weather/lib/Horde/Service/Weather/Current/Base.php    |    5 -----
 .../Service_Weather/lib/Horde/Service/Weather/Period/Base.php     |    5 -----
 2 files changed, 0 insertions(+), 10 deletions(-)

http://git.horde.org/horde-git/-/commit/70b2c6d70e70e7fd866bedf98fd2658a94b82879