[commits] Horde branch master updated. 31968658a1fd7fb725517cafc0cbf0ff4c114f7c
Michael J. Rubinsky
mrubinsk at horde.org
Sat Oct 1 07:13:57 UTC 2011
The branch "master" has been updated.
The following is a summary of the commits.
from: fe54b5b9583e6f1121950fad73697ca423a34a8f
348ffef indent
b344921 comment
3a515e7 Fix manually creating faces.
a5cbbbd No need to return the face_id, we passed it in.
69667f3 remove redundant (and erroneous) ::getDimensions() call.
9cf4b40 Use the Ansel_Image object, not the Horde_Image
0010f69 Don't attempt to create a view if we know we are loading the full data.
3196865 Reset the image data when we run Ansel_Image#raw on a dirty image.
-----------------------------------------------------------------------
commit 348ffeff8c4fe9e29c1187280cef84d829be3b03
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Oct 1 01:30:54 2011 -0400
indent
ansel/faces/savecustom.php | 14 +++++++-------
ansel/lib/Image.php | 8 ++++----
2 files changed, 11 insertions(+), 11 deletions(-)
http://git.horde.org/horde-git/-/commit/348ffeff8c4fe9e29c1187280cef84d829be3b03
-----------------------------------------------------------------------
commit b3449213c18fe12290969d351290771c8ef1f779
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Oct 1 01:32:03 2011 -0400
comment
framework/Image/lib/Horde/Image/Im.php | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/b3449213c18fe12290969d351290771c8ef1f779
-----------------------------------------------------------------------
commit 3a515e72007b204fe4411442cd80142e233165ca
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Oct 1 01:33:57 2011 -0400
Fix manually creating faces.
Can't create the view before we have the face_id, or it will save
as image 0, and need to be recreated on next load.
ansel/lib/Faces/Base.php | 37 ++++++++++++++++++-------------------
1 files changed, 18 insertions(+), 19 deletions(-)
http://git.horde.org/horde-git/-/commit/3a515e72007b204fe4411442cd80142e233165ca
-----------------------------------------------------------------------
commit a5cbbbd6632258136ee8fba5bfaccae4e136e30b
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Oct 1 01:38:55 2011 -0400
No need to return the face_id, we passed it in.
ansel/lib/Faces/Base.php | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/a5cbbbd6632258136ee8fba5bfaccae4e136e30b
-----------------------------------------------------------------------
commit 69667f303b22da5c1dec2947a10959c462c5c2ab
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Oct 1 02:54:13 2011 -0400
remove redundant (and erroneous) ::getDimensions() call.
This was loading the 'full' image data for every imageView. Plus,
this call (but on the 'screen' data) is taken care of earlier and the data cached.
ansel/lib/View/Image.php | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/69667f303b22da5c1dec2947a10959c462c5c2ab
-----------------------------------------------------------------------
commit 9cf4b40f8c074335d17e144b489fa654bfeedd3b
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Oct 1 03:03:23 2011 -0400
Use the Ansel_Image object, not the Horde_Image
ansel/lib/Faces/Base.php | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/9cf4b40f8c074335d17e144b489fa654bfeedd3b
-----------------------------------------------------------------------
commit 0010f69687b4e6e267512473f4eed536f988d559
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Oct 1 03:05:04 2011 -0400
Don't attempt to create a view if we know we are loading the full data.
ansel/lib/Image.php | 61 ++++++++++++++++++++++++++++++---------------------
1 files changed, 36 insertions(+), 25 deletions(-)
http://git.horde.org/horde-git/-/commit/0010f69687b4e6e267512473f4eed536f988d559
-----------------------------------------------------------------------
commit 31968658a1fd7fb725517cafc0cbf0ff4c114f7c
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Oct 1 03:06:56 2011 -0400
Reset the image data when we run Ansel_Image#raw on a dirty image.
This prevents the cached raw data from getting out of sync with the
composed Horde_Image. Probably need to look at this more closely
to see why exactly we need to keep the raw data cached at all...
probably need it for some effects, but might be worth reloading it
in those cases.
ansel/lib/Image.php | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/31968658a1fd7fb725517cafc0cbf0ff4c114f7c
More information about the commits
mailing list