[commits] Horde branch develop updated. 0cdbd7f63d0cba62d36e2900a482a4e4c5ae2c6b
Michael J. Rubinsky
mrubinsk at horde.org
Tue Jun 19 18:15:32 UTC 2012
The branch "develop" has been updated.
The following is a summary of the commits.
from: 20d3a037ee37634871867355a207f4e5028acbc0
a0e50ad Maintain the syncCache even if not in EAS version 12.1.
140e8a7 Always save the syncCache
391ad54 Use the SyncCache for PING requests.
f5710a7 Tweak/cleanup PING handling.
8212919 Dome doc cleanup
a30f079 Device info structure already has the device id, no need to maintain it separately.
091046d Remove all pingstate related code.
00bc481 Unused, now that we have the syncCache
dc8be8f doc/cs cleanup
eeab71e Remove deprecated method we were keeping for bc
89d691c Remove deprecated setFolderData methods
bc66af4 Some more cs/doc cleanup and matching of base/concrete class.
066bff6 Persist the last known synckey.
094ba23 More verbose
892363e Actually update the timestamp of the SYNC request in the cache, even for a non-hanging sync..
f738321 Not so verbose
13afe8d fix variable assignment
be9ef23 parse error
0cdbd7f Add migration to remove unused ping/folder state fields.
-----------------------------------------------------------------------
commit a0e50ada47890ad46522bf737dab115d46491070
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Mon Jun 18 17:50:49 2012 -0400
Maintain the syncCache even if not in EAS version 12.1.
We are going to share this cache with PING requests and get rid
of the ping state.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 72 +++++------
1 files changed, 33 insertions(+), 39 deletions(-)
http://git.horde.org/horde-git/-/commit/a0e50ada47890ad46522bf737dab115d46491070
-----------------------------------------------------------------------
commit 140e8a7fb19baf0a0cde2bd8c5b714488427d313
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Mon Jun 18 21:33:32 2012 -0400
Always save the syncCache
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 35 ++++++------
1 files changed, 17 insertions(+), 18 deletions(-)
http://git.horde.org/horde-git/-/commit/140e8a7fb19baf0a0cde2bd8c5b714488427d313
-----------------------------------------------------------------------
commit 391ad5407777b48fa06d870edad047c754615969
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Mon Jun 18 21:37:46 2012 -0400
Use the SyncCache for PING requests.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php | 85 +++++++++---
1 files changed, 64 insertions(+), 21 deletions(-)
http://git.horde.org/horde-git/-/commit/391ad5407777b48fa06d870edad047c754615969
-----------------------------------------------------------------------
commit f5710a75034b1657de16aa724af2a04688f34ca4
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 09:07:48 2012 -0400
Tweak/cleanup PING handling.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php | 11 +++++------
1 files changed, 5 insertions(+), 6 deletions(-)
http://git.horde.org/horde-git/-/commit/f5710a75034b1657de16aa724af2a04688f34ca4
-----------------------------------------------------------------------
commit 8212919e2128a2095bd54dbbb27df0b47ea98be8
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 09:12:51 2012 -0400
Dome doc cleanup
framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php | 27 ++++----------
1 files changed, 8 insertions(+), 19 deletions(-)
http://git.horde.org/horde-git/-/commit/8212919e2128a2095bd54dbbb27df0b47ea98be8
-----------------------------------------------------------------------
commit a30f079e2e03ac3280edde0b31e71f70e4e4c155
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 09:19:29 2012 -0400
Device info structure already has the device id, no need to maintain it separately.
framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php | 11 +--
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 86 +++++++-------
2 files changed, 44 insertions(+), 53 deletions(-)
http://git.horde.org/horde-git/-/commit/a30f079e2e03ac3280edde0b31e71f70e4e4c155
-----------------------------------------------------------------------
commit 091046dd7cf334212e87680df38a2986681aa588
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 09:46:56 2012 -0400
Remove all pingstate related code.
framework/ActiveSync/doc/Horde/ActiveSync/UPGRADING | 5 +-
framework/ActiveSync/lib/Horde/ActiveSync.php | 2 +-
framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php | 31 +--
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 187 ++------------
4 files changed, 26 insertions(+), 199 deletions(-)
http://git.horde.org/horde-git/-/commit/091046dd7cf334212e87680df38a2986681aa588
-----------------------------------------------------------------------
commit 00bc481c634e905d72af2b21ab510fd1e8f1f32b
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 09:49:37 2012 -0400
Unused, now that we have the syncCache
framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php | 7 ---
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 31 --------------
2 files changed, 0 insertions(+), 38 deletions(-)
http://git.horde.org/horde-git/-/commit/00bc481c634e905d72af2b21ab510fd1e8f1f32b
-----------------------------------------------------------------------
commit dc8be8f70ffd038c227c0c9588cf059396081712
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 09:56:39 2012 -0400
doc/cs cleanup
framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php | 28 +++++++++----
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 13 +++---
2 files changed, 26 insertions(+), 15 deletions(-)
http://git.horde.org/horde-git/-/commit/dc8be8f70ffd038c227c0c9588cf059396081712
-----------------------------------------------------------------------
commit eeab71e240d1ccdd893131d4e37f3e1d0db0d1cf
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 09:57:12 2012 -0400
Remove deprecated method we were keeping for bc
framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php | 10 -----
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 30 --------------
2 files changed, 0 insertions(+), 40 deletions(-)
http://git.horde.org/horde-git/-/commit/eeab71e240d1ccdd893131d4e37f3e1d0db0d1cf
-----------------------------------------------------------------------
commit 89d691c3e221c1b1a3a63c1f72c7fe40f74a5d7d
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 10:01:39 2012 -0400
Remove deprecated setFolderData methods
.../ActiveSync/lib/Horde/ActiveSync/Request/GetHierarchy.php | 4 +-
framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php | 13 --
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 48 -----
3 files changed, 1 insertions(+), 64 deletions(-)
http://git.horde.org/horde-git/-/commit/89d691c3e221c1b1a3a63c1f72c7fe40f74a5d7d
-----------------------------------------------------------------------
commit bc66af42ae52a4446776507acc4b900bd672f449
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 10:13:57 2012 -0400
Some more cs/doc cleanup and matching of base/concrete class.
framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php | 33 ++++++-------
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 34 +++++++++-----
2 files changed, 37 insertions(+), 30 deletions(-)
http://git.horde.org/horde-git/-/commit/bc66af42ae52a4446776507acc4b900bd672f449
-----------------------------------------------------------------------
commit 066bff659a3eb528772e37e5fd47d304568e0a85
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 13:34:17 2012 -0400
Persist the last known synckey.
Keep the last known synckey for each collection regardless of the
SYNCKEY value from the request. When manually triggering a SYNC request
(like from clicking a refresh button) some devices will send a full SYNC
request with only the one collection instead of a PARTIAL SYNC. This
breaks using the syncCache for PING requests, as a PING request MUST have
a previous synckey.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php | 39 +++++++++++-
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 9 +++
2 files changed, 46 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/066bff659a3eb528772e37e5fd47d304568e0a85
-----------------------------------------------------------------------
commit 094ba23a36a5d1b7b7bb3c4eeb23e5ce75e0baa7
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 13:36:45 2012 -0400
More verbose
framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php | 2 +-
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/094ba23a36a5d1b7b7bb3c4eeb23e5ce75e0baa7
-----------------------------------------------------------------------
commit 892363eec6c8d2c309b617bbbf98ec39c4a3b4ec
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 13:37:01 2012 -0400
Actually update the timestamp of the SYNC request in the cache, even for a non-hanging sync..
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/892363eec6c8d2c309b617bbbf98ec39c4a3b4ec
-----------------------------------------------------------------------
commit f7383215249ab0a67d68e30b3a95d92b876d60c4
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 13:53:14 2012 -0400
Not so verbose
framework/ActiveSync/lib/Horde/ActiveSync/Request/FolderSync.php | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/f7383215249ab0a67d68e30b3a95d92b876d60c4
-----------------------------------------------------------------------
commit 13afe8d9040f004256cb0a3984bbdab05197033f
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 13:53:26 2012 -0400
fix variable assignment
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/13afe8d9040f004256cb0a3984bbdab05197033f
-----------------------------------------------------------------------
commit be9ef23b29f17313c9cbc441ecd3c1419ede907e
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 14:14:40 2012 -0400
parse error
framework/ActiveSync/lib/Horde/ActiveSync/Request/FolderSync.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/be9ef23b29f17313c9cbc441ecd3c1419ede907e
-----------------------------------------------------------------------
commit 0cdbd7f63d0cba62d36e2900a482a4e4c5ae2c6b
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Jun 19 14:15:00 2012 -0400
Add migration to remove unused ping/folder state fields.
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 2 -
.../Horde/ActiveSync/11_horde_activesync_removepingstate.php | 22 +++++
framework/ActiveSync/package.xml | 8 +-
3 files changed, 27 insertions(+), 5 deletions(-)
create mode 100644 framework/ActiveSync/migration/Horde/ActiveSync/11_horde_activesync_removepingstate.php
http://git.horde.org/horde-git/-/commit/0cdbd7f63d0cba62d36e2900a482a4e4c5ae2c6b
More information about the commits
mailing list