[commits] Horde branch master updated. 52def0f86e4bbbd880a7f422b76159423b4ec01a
Michael J. Rubinsky
mrubinsk at horde.org
Sun Nov 11 20:20:29 UTC 2012
The branch "master" has been updated.
The following is a summary of the commits.
from: 6f5122cfa08b02ebf7bcd6bdabbab336fde5a4aa
dd8554f Revert "Revert "QRESYNC -> CONDSTORE""
9e2bad6 spacing, get rid of unused constant
efdd15e Better constant name
1faab38 Unused method
c67d813 One more MODSEQ -> HIGHESTMODSEQ change
19feb38 Version the serialized folder data.
64609eb No need for STATUS_MESSAGES here
1b19b46 Tweaks to the imap code for detecting message changes:
2678da1 Don't attempt to get the entire folder list if all we need is the type.
04c59a2 We can't truncate the FETCH since it evidently breaks decoding.
9c5e430 Use the less buggy fwrite instead of stream_copy_to_stream
f839bab Some devices can be picky about line endings as well.
8c96266 Don't increment the loop detection counter if we are not requesting changes.
77c87d4 Increment the maximum loop counter limit.
ce1acad Clean up comments
f9222ff Fix truncation for EAS 2.5 as well.
32dc86d Merge branch 'activesync_imap_vanished'
52def0f CHANGES
-----------------------------------------------------------------------
commit dd8554f886cffe7e01c273c2d0f607dca86f076c
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Nov 10 15:09:24 2012 -0500
Revert "Revert "QRESYNC -> CONDSTORE""
This reverts commit ee18a08557c8123d2dad0849e0bd269084f469b1.
framework/ActiveSync/lib/Horde/ActiveSync/Folder/Imap.php | 9 ++---
framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php | 20 ++++++------
2 files changed, 13 insertions(+), 16 deletions(-)
http://git.horde.org/horde-git/-/commit/dd8554f886cffe7e01c273c2d0f607dca86f076c
-----------------------------------------------------------------------
commit 9e2bad6cfe26b62ba29d299feaa24099789f925f
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Nov 10 15:10:40 2012 -0500
spacing, get rid of unused constant
framework/ActiveSync/lib/Horde/ActiveSync/Folder/Imap.php | 11 +++++------
1 files changed, 5 insertions(+), 6 deletions(-)
http://git.horde.org/horde-git/-/commit/9e2bad6cfe26b62ba29d299feaa24099789f925f
-----------------------------------------------------------------------
commit efdd15ec6969adf0a608a2a4cd0335901345e9a5
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Nov 10 15:13:02 2012 -0500
Better constant name
framework/ActiveSync/lib/Horde/ActiveSync/Folder/Imap.php | 2 +-
framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/efdd15ec6969adf0a608a2a4cd0335901345e9a5
-----------------------------------------------------------------------
commit 1faab38fff7bf96129dee9f0d6d17d4e7f84088d
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Nov 10 15:26:31 2012 -0500
Unused method
framework/ActiveSync/lib/Horde/ActiveSync/Folder/Imap.php | 12 ------------
1 files changed, 0 insertions(+), 12 deletions(-)
http://git.horde.org/horde-git/-/commit/1faab38fff7bf96129dee9f0d6d17d4e7f84088d
-----------------------------------------------------------------------
commit c67d813cc8a93a086de036a76cf3894b61cf2437
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Nov 10 15:27:08 2012 -0500
One more MODSEQ -> HIGHESTMODSEQ change
framework/ActiveSync/lib/Horde/ActiveSync/Folder/Imap.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/c67d813cc8a93a086de036a76cf3894b61cf2437
-----------------------------------------------------------------------
commit 19feb38b0e8d1a9ef2f0ac38a3995d27e56427b7
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Nov 10 17:35:51 2012 -0500
Version the serialized folder data.
framework/ActiveSync/lib/Horde/ActiveSync/Folder/Imap.php | 24 +++++++++++--
1 files changed, 21 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/19feb38b0e8d1a9ef2f0ac38a3995d27e56427b7
-----------------------------------------------------------------------
commit 64609eb1a1f71b63e240b4559c2ada1605602320
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Nov 10 17:39:15 2012 -0500
No need for STATUS_MESSAGES here
framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/64609eb1a1f71b63e240b4559c2ada1605602320
-----------------------------------------------------------------------
commit 1b19b46004e82b0caafffea50b5d2e790f8cb18d
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Nov 10 20:50:17 2012 -0500
Tweaks to the imap code for detecting message changes:
We now cache the UIDs sent to the device for both CONDSTORE and non-CONDSTORE servers.
Improves ability to detetect VANISHED messages.
framework/ActiveSync/lib/Horde/ActiveSync/Folder/Imap.php | 61 +++++-------
framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php | 58 +++++++-----
2 files changed, 59 insertions(+), 60 deletions(-)
http://git.horde.org/horde-git/-/commit/1b19b46004e82b0caafffea50b5d2e790f8cb18d
-----------------------------------------------------------------------
commit 2678da18fe3b5bb4ff548ab72b54df96a756049e
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Nov 10 21:19:31 2012 -0500
Don't attempt to get the entire folder list if all we need is the type.
When fetching a message from a collection, we only need to know if
a collection type is a calendar, addressbook, email etc... we
don't need to know the exact type of email folder (sent, inbox, etc...).
This potentially saves a LIST call to the IMAP server for each email message
sent to the device.
framework/Core/lib/Horde/Core/ActiveSync/Driver.php | 27 +++++++++++++++++-
1 files changed, 25 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/2678da18fe3b5bb4ff548ab72b54df96a756049e
-----------------------------------------------------------------------
commit 04c59a23338e81e72567d8033ad4172643d0966c
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Nov 11 00:35:38 2012 -0500
We can't truncate the FETCH since it evidently breaks decoding.
When we are FETCHing a plain text part the is transfer encoded in
e.g., quoted-printable and it's not decoded server side, not
having the entire text will produce broken data when we set
the content in the mime object. Transfering this data to
iOS devices *completly* breaks syncing.
framework/ActiveSync/lib/Horde/ActiveSync/Imap/Message.php | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/04c59a23338e81e72567d8033ad4172643d0966c
-----------------------------------------------------------------------
commit 9c5e4303916681b8c3f37bf7182ccdd088e142af
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Nov 11 00:40:49 2012 -0500
Use the less buggy fwrite instead of stream_copy_to_stream
framework/ActiveSync/lib/Horde/ActiveSync/Wbxml/Encoder.php | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/9c5e4303916681b8c3f37bf7182ccdd088e142af
-----------------------------------------------------------------------
commit f839bab97d57da741ce2a0ac4eb51622709d004c
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Nov 11 00:41:13 2012 -0500
Some devices can be picky about line endings as well.
framework/ActiveSync/lib/Horde/ActiveSync/Wbxml/Encoder.php | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/f839bab97d57da741ce2a0ac4eb51622709d004c
-----------------------------------------------------------------------
commit 8c962664a1c7f8e60af57a961d873f04309e9f08
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Nov 11 00:55:06 2012 -0500
Don't increment the loop detection counter if we are not requesting changes.
FETCH requests do not increment the synckey, so they should not increment the counter either.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/8c962664a1c7f8e60af57a961d873f04309e9f08
-----------------------------------------------------------------------
commit 77c87d4dc935e25bafa320a6eb70d0bc85d64f07
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Nov 11 00:58:41 2012 -0500
Increment the maximum loop counter limit.
This is really designed as a last resort fail-safe. The device
should kill the sync long before this is reached. Keeping it too
low can cause it to be hit by a user manually refreshing the sync.
framework/ActiveSync/lib/Horde/ActiveSync.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/77c87d4dc935e25bafa320a6eb70d0bc85d64f07
-----------------------------------------------------------------------
commit ce1acad0adba25d42df375e727f4accac4f0820a
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Nov 11 13:53:05 2012 -0500
Clean up comments
framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php | 4 +---
framework/ActiveSync/lib/Horde/ActiveSync/Imap/Message.php | 1 -
2 files changed, 1 insertions(+), 4 deletions(-)
http://git.horde.org/horde-git/-/commit/ce1acad0adba25d42df375e727f4accac4f0820a
-----------------------------------------------------------------------
commit f9222ff805ce2b16f5b7a193509d423347a1c6cc
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Nov 11 13:53:46 2012 -0500
Fix truncation for EAS 2.5 as well.
framework/ActiveSync/lib/Horde/ActiveSync/Imap/Message.php | 20 +++++++----
1 files changed, 13 insertions(+), 7 deletions(-)
http://git.horde.org/horde-git/-/commit/f9222ff805ce2b16f5b7a193509d423347a1c6cc
-----------------------------------------------------------------------
commit 32dc86d3331e9639d78241fecec7eb94ac0459b9
Merge: 6f5122c f9222ff
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Nov 11 15:11:43 2012 -0500
Merge branch 'activesync_imap_vanished'
framework/ActiveSync/lib/Horde/ActiveSync.php | 2 +-
framework/ActiveSync/lib/Horde/ActiveSync/Folder/Imap.php | 111 +++++------
framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php | 79 ++++----
framework/ActiveSync/lib/Horde/ActiveSync/Imap/Message.php | 23 ++-
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 2 +-
framework/ActiveSync/lib/Horde/ActiveSync/Wbxml/Encoder.php | 17 ++-
framework/Core/lib/Horde/Core/ActiveSync/Driver.php | 27 +++-
7 files changed, 147 insertions(+), 114 deletions(-)
http://git.horde.org/horde-git/-/commit/32dc86d3331e9639d78241fecec7eb94ac0459b9
-----------------------------------------------------------------------
commit 52def0f86e4bbbd880a7f422b76159423b4ec01a
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Nov 11 15:20:12 2012 -0500
CHANGES
framework/ActiveSync/package.xml | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/52def0f86e4bbbd880a7f422b76159423b4ec01a
More information about the commits
mailing list