[commits] Horde branch master updated. 1c79ca0ecc649922635cbb08c7c56ca6aa58de4c

Michael J. Rubinsky mrubinsk at horde.org
Wed Sep 5 17:16:40 UTC 2012


The branch "master" has been updated.
The following is a summary of the commits.

from: 33aa7aea959a560278c5acaf680c966f68c3fad9

0f9123b Fix and cleanup deleting tasks from Nag_Form_Task.
b6241a2 No idea what this was supposed to do.
1c79ca0 Remove unused parameter.

-----------------------------------------------------------------------

commit 0f9123b800263656b4fc4dfd0aef2d20dea4ae02
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Wed Sep 5 13:12:45 2012 -0400

    Fix and cleanup deleting tasks from Nag_Form_Task.
    
    No need for custom renderer for Tasks either, all can be done by
    applying logic in the c'tor when deciding what buttons to add.

 nag/app/controllers/SaveTask.php |   30 +++++++++++++++++++++++-
 nag/lib/Form/Renderer/Task.php   |   45 --------------------------------------
 nag/lib/Form/Task.php            |   30 +++++++++++++++++++------
 nag/package.xml                  |   16 ++++---------
 4 files changed, 56 insertions(+), 65 deletions(-)
 delete mode 100644 nag/lib/Form/Renderer/Task.php

http://git.horde.org/horde-git/-/commit/0f9123b800263656b4fc4dfd0aef2d20dea4ae02

-----------------------------------------------------------------------

commit b6241a2141fa7f17aaa2e3fccf2fa2eaa65f4516
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Wed Sep 5 13:14:29 2012 -0400

    No idea what this was supposed to do.
    
    $mobile is being assigned true, is not used anywhere else on the page
    and resulted in the (now unused) 3rd parameter to always be true..
    most likely not what was intended.

 nag/smartmobile.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/b6241a2141fa7f17aaa2e3fccf2fa2eaa65f4516

-----------------------------------------------------------------------

commit 1c79ca0ecc649922635cbb08c7c56ca6aa58de4c
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Wed Sep 5 13:15:55 2012 -0400

    Remove unused parameter.
    
    The logic for this is handled in the form c'tor.

 nag/task.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/1c79ca0ecc649922635cbb08c7c56ca6aa58de4c




More information about the commits mailing list