[commits] Horde branch master updated. fdd580a06a94a92181cd4c0bcc4f04b1ee62cc43

Michael M Slusarz slusarz at horde.org
Thu Sep 27 23:43:26 UTC 2012


The branch "master" has been updated.
The following is a summary of the commits.

from: 56d64e1477579a8522daa4bc14bcbb7bc4d445b0

fdd580a [mms] Improved parsing of incoming IMAP server stream.

-----------------------------------------------------------------------

commit fdd580a06a94a92181cd4c0bcc4f04b1ee62cc43
Author: Michael M Slusarz <slusarz at curecanti.org>
Date:   Tue Sep 25 13:20:27 2012 -0600

    [mms] Improved parsing of incoming IMAP server stream.
    
    Use a separate server interaction object to handle the server
    comminications.  Allows us to better encapsulate/store information such
    as tags and response codes within the server response.
    
    Re-reading the RFC specs, it turns out that literals can be sent in both
    continuation and tagged responses (although, in practice, this rarely
    (never?) happens).  Thus, all incoming server streams should be
    tokenized.  Additionally, it is possible for response codes to be sent
    in a continuation response (although, again, in practice this doesn't
    happen).
    
    Remove an unneeded BAD check on initial connection (server can only send
    OK, PREAUTH, or BYE at this time).
    
    Server stream parsing is all done in one location now, so Socket.php
    code should be cleaner, easier to read, and easier to maintain.

 framework/Imap_Client/lib/Horde/Imap/Client/Base.php              |   32 -
 framework/Imap_Client/lib/Horde/Imap/Client/Exception.php         |   10 +
 .../lib/Horde/Imap/Client/Exception/ServerResponse.php            |   18 +-
 .../Imap_Client/lib/Horde/Imap/Client/Interaction/Server.php      |  130 +
 .../lib/Horde/Imap/Client/Interaction/Server/Continuation.php     |   17 +
 .../lib/Horde/Imap/Client/Interaction/Server/Tagged.php           |   38 +
 .../lib/Horde/Imap/Client/Interaction/Server/Untagged.php         |   17 +
 framework/Imap_Client/lib/Horde/Imap/Client/Socket.php            |  775 ++---
 framework/Imap_Client/lib/Horde/Imap/Client/Tokenize.php          |   10 +
 framework/Imap_Client/package.xml                                 |   18 +-
 10 files changed, 581 insertions(+), 484 deletions(-)
 create mode 100644 framework/Imap_Client/lib/Horde/Imap/Client/Interaction/Server.php
 create mode 100644 framework/Imap_Client/lib/Horde/Imap/Client/Interaction/Server/Continuation.php
 create mode 100644 framework/Imap_Client/lib/Horde/Imap/Client/Interaction/Server/Tagged.php
 create mode 100644 framework/Imap_Client/lib/Horde/Imap/Client/Interaction/Server/Untagged.php

http://git.horde.org/horde-git/-/commit/fdd580a06a94a92181cd4c0bcc4f04b1ee62cc43




More information about the commits mailing list