[commits] Horde branch master updated. 1b4afbd3b4e43a6db797fd8924cf1517f7ee2bb0
Michael J. Rubinsky
mrubinsk at horde.org
Thu Apr 18 13:20:48 UTC 2013
The branch "master" has been updated.
The following is a summary of the commits.
from: 5c09d06df5da725a94b8dfc365e0362371908254
125413c Expose the logger and device objects.
87142b5 Add factory methods for collectionsObject and syncObject.
1c6ebe3 grammer/typo
4c4a666 Existence check.
fca85dc Fix false positive change detection when no MODSEQ is available.
4187e5d Fix setting flags during initial sync when no MODSEQ is available.
99e9ce1 Tweak some logging, remove some overly verbose entries.
2347287 Use the factory methods in Horde_ActiveSync.
6f77902 Inject the logger and server object.
876a16e Update some comments.
64b0f86 simplify
ae9d259 Change order, we shouldn't update the cache if there was an error.
43e7049 Add Horde_ActiveSync_Collectons::updateCollectionsFromCache().
d471408 Add method to get the heartbeat interval, normalized to seconds.
147be01 Ignore the syncCache's timestamp when validating.
299a91a Move this to the collection object.
2e373ea Extract pollForChanges() to the collection object.
d784d81 Standardize on $state.
be6b615 Add @property
0880d2c Remove unnecessary parameter.
47b3602 phpdoc
3658afc Do some method organization...
2e13a74 Fix variable names.
1b4afbd Ensure headelt is defined.
-----------------------------------------------------------------------
commit 125413c37cc6cf74f58977e684092fa141b70d1c
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:01:40 2013 -0400
Expose the logger and device objects.
framework/ActiveSync/lib/Horde/ActiveSync.php | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/125413c37cc6cf74f58977e684092fa141b70d1c
-----------------------------------------------------------------------
commit 87142b5b44c2977ff08717cf279f0ab1109ad5bf
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:02:16 2013 -0400
Add factory methods for collectionsObject and syncObject.
framework/ActiveSync/lib/Horde/ActiveSync.php | 30 +++++++++++++++++++++++++
1 files changed, 30 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/87142b5b44c2977ff08717cf279f0ab1109ad5bf
-----------------------------------------------------------------------
commit 1c6ebe38d0c35df0778f7b09162dbdcfa4a412eb
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:04:36 2013 -0400
grammer/typo
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/1c6ebe38d0c35df0778f7b09162dbdcfa4a412eb
-----------------------------------------------------------------------
commit 4c4a66654a752fefcea1a8412e0baf0ebd3eb1e7
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:08:52 2013 -0400
Existence check.
Since we can now call getChanges() with just flags from the maillog,
we won't always have the 'read' and 'flagged' keys. Fixes some undefined
index errors in the log.
framework/ActiveSync/lib/Horde/ActiveSync/Folder/Imap.php | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/4c4a66654a752fefcea1a8412e0baf0ebd3eb1e7
-----------------------------------------------------------------------
commit fca85dc8e6fe824aece2e97db15ec4bfc30248e9
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:10:40 2013 -0400
Fix false positive change detection when no MODSEQ is available.
framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/fca85dc8e6fe824aece2e97db15ec4bfc30248e9
-----------------------------------------------------------------------
commit 4187e5d66315b7deb73cbb1f9b474813682f1f32
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:12:22 2013 -0400
Fix setting flags during initial sync when no MODSEQ is available.
Fixes broken caching of UIDs in the sync state which could lead to
anything from completely broken syncs to the inability to detect
deleted messages.
framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/4187e5d66315b7deb73cbb1f9b474813682f1f32
-----------------------------------------------------------------------
commit 99e9ce10efce39d899ffce8a8eefe503e3b49ec8
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:16:27 2013 -0400
Tweak some logging, remove some overly verbose entries.
framework/ActiveSync/lib/Horde/ActiveSync/Request/FolderSync.php | 2 -
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 14 +++---
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 4 +-
3 files changed, 9 insertions(+), 11 deletions(-)
http://git.horde.org/horde-git/-/commit/99e9ce10efce39d899ffce8a8eefe503e3b49ec8
-----------------------------------------------------------------------
commit 2347287e3dbd9c982c10511f3c1e215a9fb2e8d7
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:18:48 2013 -0400
Use the factory methods in Horde_ActiveSync.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Base.php | 13 -----
framework/ActiveSync/lib/Horde/ActiveSync/Request/FolderSync.php | 2 +-
.../ActiveSync/lib/Horde/ActiveSync/Request/GetItemEstimate.php | 2 +-
framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php | 2 +-
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 9 ++--
5 files changed, 7 insertions(+), 21 deletions(-)
http://git.horde.org/horde-git/-/commit/2347287e3dbd9c982c10511f3c1e215a9fb2e8d7
-----------------------------------------------------------------------
commit 6f779027d776af8d81b7dbf432b6c0599c631cec
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:21:17 2013 -0400
Inject the logger and server object.
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 28 +++++++++++--
1 files changed, 24 insertions(+), 4 deletions(-)
http://git.horde.org/horde-git/-/commit/6f779027d776af8d81b7dbf432b6c0599c631cec
-----------------------------------------------------------------------
commit 876a16eb0c038464fad48e00b49a75138738787b
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:22:37 2013 -0400
Update some comments.
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 8 ++++++++
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 11 ++++++-----
2 files changed, 14 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/876a16eb0c038464fad48e00b49a75138738787b
-----------------------------------------------------------------------
commit 64b0f86a5d021fe3dd7d6713ca9a124c6c6dacd3
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:23:29 2013 -0400
simplify
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 46 +++++-------
1 files changed, 18 insertions(+), 28 deletions(-)
http://git.horde.org/horde-git/-/commit/64b0f86a5d021fe3dd7d6713ca9a124c6c6dacd3
-----------------------------------------------------------------------
commit ae9d25971e12c3c0c77fe8e644b5fdfe0608c063
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:24:18 2013 -0400
Change order, we shouldn't update the cache if there was an error.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/ae9d25971e12c3c0c77fe8e644b5fdfe0608c063
-----------------------------------------------------------------------
commit 43e70496aeb8f3dd078a4b1c6651b087966bcbdf
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:26:26 2013 -0400
Add Horde_ActiveSync_Collectons::updateCollectionsFromCache().
Used to pull the most recent collection data from cache so looping
syncs/pings will always have the most recent data without having
to die/reissue.
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 16 +++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/43e70496aeb8f3dd078a4b1c6651b087966bcbdf
-----------------------------------------------------------------------
commit d47140864850a612117ff6276f0d88bd87c75a80
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:27:47 2013 -0400
Add method to get the heartbeat interval, normalized to seconds.
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 16 +++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/d47140864850a612117ff6276f0d88bd87c75a80
-----------------------------------------------------------------------
commit 147be01895c2da25eeb10808b37f8ac8dd7221ab
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:28:21 2013 -0400
Ignore the syncCache's timestamp when validating.
Prevents concurrent sync requests from killing a ping unless
necessary.
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/147be01895c2da25eeb10808b37f8ac8dd7221ab
-----------------------------------------------------------------------
commit 299a91a1603dd1c78629d55eb7a7bb4261fd3164
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:29:41 2013 -0400
Move this to the collection object.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 25 +-----------
1 files changed, 2 insertions(+), 23 deletions(-)
http://git.horde.org/horde-git/-/commit/299a91a1603dd1c78629d55eb7a7bb4261fd3164
-----------------------------------------------------------------------
commit 2e373ea878f01bf97a7b5af2a0f205469bfb684f
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:30:11 2013 -0400
Extract pollForChanges() to the collection object.
Will eventually be used for PING too, reducing duplication of code.
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 173 +++++++++++-
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 157 ++---------
2 files changed, 190 insertions(+), 140 deletions(-)
http://git.horde.org/horde-git/-/commit/2e373ea878f01bf97a7b5af2a0f205469bfb684f
-----------------------------------------------------------------------
commit d784d819f8e1731ef396a5b93fd4d9bb4321004d
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:36:32 2013 -0400
Standardize on $state.
framework/ActiveSync/lib/Horde/ActiveSync/Driver/Base.php | 10 +-
framework/ActiveSync/lib/Horde/ActiveSync/Request/Base.php | 10 +-
.../ActiveSync/lib/Horde/ActiveSync/Request/FolderCreate.php | 12 +-
framework/ActiveSync/lib/Horde/ActiveSync/Request/FolderSync.php | 16 ++--
.../ActiveSync/lib/Horde/ActiveSync/Request/GetItemEstimate.php | 6 +-
framework/ActiveSync/lib/Horde/ActiveSync/Request/MoveItems.php | 2 +-
framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php | 12 +-
framework/ActiveSync/lib/Horde/ActiveSync/Request/Provision.php | 20 ++--
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 22 ++--
framework/ActiveSync/lib/Horde/ActiveSync/Sync.php | 14 ++--
10 files changed, 62 insertions(+), 62 deletions(-)
http://git.horde.org/horde-git/-/commit/d784d819f8e1731ef396a5b93fd4d9bb4321004d
-----------------------------------------------------------------------
commit be6b615004cfed62ee461d9a41f68e46791a9261
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:46:02 2013 -0400
Add @property
framework/ActiveSync/lib/Horde/ActiveSync.php | 26 ++++++++++++++++++++++++-
1 files changed, 25 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/be6b615004cfed62ee461d9a41f68e46791a9261
-----------------------------------------------------------------------
commit 0880d2c515ee3685e4bf8f3e71d1be519bb3d860
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:50:25 2013 -0400
Remove unnecessary parameter.
framework/ActiveSync/lib/Horde/ActiveSync.php | 2 +-
framework/ActiveSync/lib/Horde/ActiveSync/Request/Base.php | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/0880d2c515ee3685e4bf8f3e71d1be519bb3d860
-----------------------------------------------------------------------
commit 47b360272573fb612ec89ee99afe830c2b2f4f10
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Wed Apr 17 23:51:52 2013 -0400
phpdoc
framework/Core/lib/Horde/Core/ActiveSync/Driver.php | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/47b360272573fb612ec89ee99afe830c2b2f4f10
-----------------------------------------------------------------------
commit 3658afc6dddfc3e59bc0190004a1551db989053c
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 00:02:50 2013 -0400
Do some method organization...
framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php | 742 ++++++------
1 files changed, 375 insertions(+), 367 deletions(-)
http://git.horde.org/horde-git/-/commit/3658afc6dddfc3e59bc0190004a1551db989053c
-----------------------------------------------------------------------
commit 2e13a746d912fc6195d0791c4586ce00a8951331
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 00:04:42 2013 -0400
Fix variable names.
framework/ActiveSync/lib/Horde/ActiveSync/Sync.php | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/2e13a746d912fc6195d0791c4586ce00a8951331
-----------------------------------------------------------------------
commit 1b4afbd3b4e43a6db797fd8924cf1517f7ee2bb0
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 09:19:11 2013 -0400
Ensure headelt is defined.
Not sure if this is the correct fix, but this fixes tons of
warnings in my log and the inability to view certain emails.
imp/lib/Mime/Viewer/Html.php | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/1b4afbd3b4e43a6db797fd8924cf1517f7ee2bb0
More information about the commits
mailing list