[commits] Horde branch master updated. c6e1bad528ac435a1a3ede16ef33d4c28bc37188
Michael J. Rubinsky
mrubinsk at horde.org
Fri Apr 19 03:09:35 UTC 2013
The branch "master" has been updated.
The following is a summary of the commits.
from: e50eb31f40fc5c046a0023537bf04c36978b96a7
3abea5b phpdoc
80ffa21 Log if we have Wbxml or not in the SENDMAIL command.
93be151 Simplify
38b60f7 clean up/add/remove some logging.
5caf539 We can't limit to collections with synckeys here.
cde7bca Avoid undefined variable warnings.
792aaa2 This status seems to work better to obtain the desired result.
e589efc Don't remove the collection if it's not refreshed.
6b05633 Attempt to get a synckey from the cache when adding the collection.
9f25ba9 phpdoc/typehints
496f285 Allow for checking of synckey when initializing the state.
9cccfd4 Give up early if we know we don't have pingable collections.
872b7f4 comments
b10e755 Add havePingableCollections() and updatePingableFlag()
b3d79f8 Perform the empty pingable check after we initialize the state.
3667d55 Better variable name, we need lastsynckey here instead of synckey.
68a0719 Shorter variable name
6e4cadb Persist the pingable flag as well.
08b70ba Completely rewrite PING handling to use the new collection handler.
c6e1bad Might not have airsyncbasebody, even in 12.1.
-----------------------------------------------------------------------
commit 3abea5b739eafdca8367616c18621426bb063ca6
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 14:07:52 2013 -0400
phpdoc
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/3abea5b739eafdca8367616c18621426bb063ca6
-----------------------------------------------------------------------
commit 80ffa21916af8a84aeda48adb59c658c008a1b8b
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 14:20:14 2013 -0400
Log if we have Wbxml or not in the SENDMAIL command.
framework/ActiveSync/lib/Horde/ActiveSync/Request/SendMail.php | 10 ++++---
1 files changed, 6 insertions(+), 4 deletions(-)
http://git.horde.org/horde-git/-/commit/80ffa21916af8a84aeda48adb59c658c008a1b8b
-----------------------------------------------------------------------
commit 93be151b6357b0cad9b75fc20af880d1590165a4
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 14:24:54 2013 -0400
Simplify
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/93be151b6357b0cad9b75fc20af880d1590165a4
-----------------------------------------------------------------------
commit 38b60f782ef3e07794012b79386fb8e0f3db4944
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 19:57:01 2013 -0400
clean up/add/remove some logging.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 1 -
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 9 ++-------
framework/ActiveSync/lib/Horde/ActiveSync/Wbxml/Decoder.php | 1 -
3 files changed, 2 insertions(+), 9 deletions(-)
http://git.horde.org/horde-git/-/commit/38b60f782ef3e07794012b79386fb8e0f3db4944
-----------------------------------------------------------------------
commit 5caf539759bce873a3d0c42b9695a19c4c1e4717
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 22:45:41 2013 -0400
We can't limit to collections with synckeys here.
We want the lastsynckey value.
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/5caf539759bce873a3d0c42b9695a19c4c1e4717
-----------------------------------------------------------------------
commit cde7bcac3de84b2d679ffefa812a4fb853602bec
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 22:47:25 2013 -0400
Avoid undefined variable warnings.
.../ActiveSync/lib/Horde/ActiveSync/Request/GetItemEstimate.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/cde7bcac3de84b2d679ffefa812a4fb853602bec
-----------------------------------------------------------------------
commit 792aaa2805221224609c108d835cbd26a5855580
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 22:48:03 2013 -0400
This status seems to work better to obtain the desired result.
This needs to trigger the client to reinitialize the syncstate with the server.
.../ActiveSync/lib/Horde/ActiveSync/Request/GetItemEstimate.php | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/792aaa2805221224609c108d835cbd26a5855580
-----------------------------------------------------------------------
commit e589efc56921f21ff02d817ab0d4ad58bce0fed1
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 22:49:53 2013 -0400
Don't remove the collection if it's not refreshed.
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/e589efc56921f21ff02d817ab0d4ad58bce0fed1
-----------------------------------------------------------------------
commit 6b05633b52a290f6ae9e1be785b9ec2c36b80931
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 22:50:54 2013 -0400
Attempt to get a synckey from the cache when adding the collection.
Needed from requests like PING that don't send the synckey, it's
expected to always be operating against the most recent confirmed state.
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 20 +++++++++++--
1 files changed, 17 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/6b05633b52a290f6ae9e1be785b9ec2c36b80931
-----------------------------------------------------------------------
commit 9f25ba956181b4a09083b71a4029a2c9899700c1
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 22:58:44 2013 -0400
phpdoc/typehints
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 13 ++++++++++---
1 files changed, 10 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/9f25ba956181b4a09083b71a4029a2c9899700c1
-----------------------------------------------------------------------
commit 496f285cf5cd10b0fb4a47384b808af7fcf41743
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 22:59:37 2013 -0400
Allow for checking of synckey when initializing the state.
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 12 +++++++++++-
1 files changed, 11 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/496f285cf5cd10b0fb4a47384b808af7fcf41743
-----------------------------------------------------------------------
commit 9cccfd42be0fa733d67bd598cecf38b43cf22bff
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 23:00:43 2013 -0400
Give up early if we know we don't have pingable collections.
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/9cccfd42be0fa733d67bd598cecf38b43cf22bff
-----------------------------------------------------------------------
commit 872b7f4b08e79a8cbc90e45ae573feadd0d585dd
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 23:01:14 2013 -0400
comments
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
http://git.horde.org/horde-git/-/commit/872b7f4b08e79a8cbc90e45ae573feadd0d585dd
-----------------------------------------------------------------------
commit b10e7553a39b3e7f184af50d6f643685f9f847c2
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 23:02:31 2013 -0400
Add havePingableCollections() and updatePingableFlag()
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 31 +++++++++++++
1 files changed, 31 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/b10e7553a39b3e7f184af50d6f643685f9f847c2
-----------------------------------------------------------------------
commit b3d79f8820288b8bf4f547583fc03af61f789b4b
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 23:02:56 2013 -0400
Perform the empty pingable check after we initialize the state.
Gives the chance to detect vanished state.
framework/ActiveSync/lib/Horde/ActiveSync/Collections.php | 24 ++++++++----
1 files changed, 16 insertions(+), 8 deletions(-)
http://git.horde.org/horde-git/-/commit/b3d79f8820288b8bf4f547583fc03af61f789b4b
-----------------------------------------------------------------------
commit 3667d553f67aaf98761f9ea169b3e44c1a0a6678
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 23:04:57 2013 -0400
Better variable name, we need lastsynckey here instead of synckey.
framework/ActiveSync/lib/Horde/ActiveSync/SyncCache.php | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/3667d553f67aaf98761f9ea169b3e44c1a0a6678
-----------------------------------------------------------------------
commit 68a0719e5af38f392eb5240b9f9d1a7ddedb9990
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 23:05:55 2013 -0400
Shorter variable name
framework/ActiveSync/lib/Horde/ActiveSync/SyncCache.php | 16 +++++++-------
1 files changed, 8 insertions(+), 8 deletions(-)
http://git.horde.org/horde-git/-/commit/68a0719e5af38f392eb5240b9f9d1a7ddedb9990
-----------------------------------------------------------------------
commit 6e4cadb5e64b4dfda9adb59426a9134b88aaa4c0
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 23:06:11 2013 -0400
Persist the pingable flag as well.
framework/ActiveSync/lib/Horde/ActiveSync/SyncCache.php | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/6e4cadb5e64b4dfda9adb59426a9134b88aaa4c0
-----------------------------------------------------------------------
commit 08b70badb94cbb0021ff9b9b26c1206f31635cfb
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 23:06:29 2013 -0400
Completely rewrite PING handling to use the new collection handler.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Ping.php | 307 ++++--------
1 files changed, 89 insertions(+), 218 deletions(-)
http://git.horde.org/horde-git/-/commit/08b70badb94cbb0021ff9b9b26c1206f31635cfb
-----------------------------------------------------------------------
commit c6e1bad528ac435a1a3ede16ef33d4c28bc37188
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu Apr 18 23:07:12 2013 -0400
Might not have airsyncbasebody, even in 12.1.
When devices send ghosted modify commands, we only have what changed.
turba/lib/Driver.php | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/c6e1bad528ac435a1a3ede16ef33d4c28bc37188
More information about the commits
mailing list