[commits] Horde branch master updated. 6b7193aefc3295d925919b7608ff7b2f7ff8f86c

Michael J. Rubinsky mrubinsk at horde.org
Mon Aug 26 15:46:12 UTC 2013


The branch "master" has been updated.
The following is a summary of the commits.

from: bc47667a978f0dd7cb223a0807ab12f9fab81ec7

6b7193a Fix sync loop if all messages in a folder were filtered on initial sync

-----------------------------------------------------------------------

commit 6b7193aefc3295d925919b7608ff7b2f7ff8f86c
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date:   Fri Aug 23 17:33:37 2013 +0200

    Fix sync loop if all messages in a folder were filtered on initial sync
    
    We are only calling $folder->setChanges() if we found changes for a folder.
    If all messages are older than our filter window, we never called setChanges().
    Therefore the total message count was still zero.
    
    The next time we ping() the folder, the total message count
    does not match for the folder -> we have a positive "ping".
    This results in a sync loop.
    
    Since we simplified the CONDSTORE / non-CONDSTORE handling,
    there is no need to store "total_messages" in a separate variable.
    Just get it from the saved IMAP state which we update unconditionally.
    
    Bug: 12606 - Fix regression caused by addition of message count check in imap pinging.
    
    Signed-off-by: Michael J Rubinsky <mrubinsk at horde.org>

 framework/ActiveSync/lib/Horde/ActiveSync/Folder/Imap.php  |   21 +++---------
 framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php |    8 ++--
 2 files changed, 9 insertions(+), 20 deletions(-)

http://git.horde.org/horde-git/-/commit/6b7193aefc3295d925919b7608ff7b2f7ff8f86c




More information about the commits mailing list