[commits] Horde branch imp_6_1 updated. 901a6a1ae698fd44db419d41a975841a60d66780
Michael M Slusarz
slusarz at horde.org
Mon Mar 25 21:03:02 UTC 2013
The branch "imp_6_1" has been updated.
The following is a summary of the commits.
from: 9083b8bf58f4557adcf48e84b51a69faffb2a9af
901a6a1 Rewrite attachment storage backend
-----------------------------------------------------------------------
commit 901a6a1ae698fd44db419d41a975841a60d66780
Author: Michael M Slusarz <slusarz at horde.org>
Date: Sun Mar 24 23:33:50 2013 -0600
Rewrite attachment storage backend
This was sort of how I implemented this a couple of months ago, but for
some reason I took a more integrated approach. However, this approach
better allows future/further support of storage backends other than the
traditional IMP model (i.e. cloud storage).
Further, this approach better abstracts temporary storage vs. linked
storage. Since both appear the same to the user (the difference isn't
apparent until the message is sent out), they should be handled the same
by the code also. Theoretically allows a backend driver to be written
that would store attachments differently based on content (e.g. images
get sent as linked attachment and saved in a web-accessible photo
application).
Instead of a hook, this can be configured by changing the $classAtc and
$classLink variables in IMP_Factory_ComposeAtc at run-time; this is a
bit too specialized for a hook, since it requires some knowledge of the
attachment storage classes before it can be implemented.
imp/config/hooks.php.dist | 20 --
imp/docs/UPGRADING | 1 -
imp/lib/Application.php | 1 -
imp/lib/Compose.php | 4 +-
imp/lib/Compose/Attachment.php | 111 +++-----
imp/lib/Compose/Attachment/Linked.php | 41 +++
imp/lib/Compose/Attachment/Linked/Metadata.php | 93 ++++++
imp/lib/Compose/Attachment/Storage.php | 110 +++++++
imp/lib/Compose/Attachment/Storage/Vfs.php | 104 +++++++
imp/lib/Compose/Attachment/Storage/VfsLinked.php | 176 ++++++++++++
imp/lib/Compose/LinkedAttachment.php | 266 ++++--------------
imp/lib/Factory/ComposeAtc.php | 82 ++++++
imp/lib/Factory/ComposeVfs.php | 35 ---
imp/lib/LoginTasks/SystemTask/GarbageCollection.php | 14 +-
imp/lib/LoginTasks/Task/DeleteAttachmentsMonthly.php | 14 +-
15 files changed, 724 insertions(+), 348 deletions(-)
create mode 100644 imp/lib/Compose/Attachment/Linked.php
create mode 100644 imp/lib/Compose/Attachment/Linked/Metadata.php
create mode 100644 imp/lib/Compose/Attachment/Storage.php
create mode 100644 imp/lib/Compose/Attachment/Storage/Vfs.php
create mode 100644 imp/lib/Compose/Attachment/Storage/VfsLinked.php
create mode 100644 imp/lib/Factory/ComposeAtc.php
delete mode 100644 imp/lib/Factory/ComposeVfs.php
http://git.horde.org/horde-git/-/commit/901a6a1ae698fd44db419d41a975841a60d66780
More information about the commits
mailing list