[commits] Horde branch master updated. 24181adf76bef93aaefba40ebf66d25ec1c7a05d

Michael J. Rubinsky mrubinsk at horde.org
Thu Nov 21 21:26:32 UTC 2013


The branch "master" has been updated.
The following is a summary of the commits.

from: f76e66f013a6bb8e3b725546e1c2c973c8240c94

24181ad Fix sync "loop" of Kolab categories <-> Horde tags sync. Fixes #12770.

Summary: http://github.com/horde/horde/compare/f76e66f013a6bb8e3b725546e1c2c973c8240c94...24181adf76bef93aaefba40ebf66d25ec1c7a05d

-----------------------------------------------------------------------

commit 24181adf76bef93aaefba40ebf66d25ec1c7a05d
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date:   Wed Oct 16 16:22:31 2013 +0200

    Fix sync "loop" of Kolab categories <-> Horde tags sync. Fixes #12770.
    
    Consider this scenario with a new, empty calendar:
    
    1. User inserts the first event. The event is tagged with "foobar".
       This tag is inserted into the tagging backend.
    2. User creates another event with a foreign Kolab client.
       This event is tagged "Foobar" (noticed the capital 'F')
    3. kronolith syncs in the foreign event. The Kolab sync tells
       the tag backend to store the tag(s) for the new event object,
       it does a case insensitive search for an existing tag label.
       -> it picks the existing row id of "foobar".
    
    The next time Event::synchronizeTags() runs, it notices
    the tags given by the Kolab driver for the second event
    differ from the tag backend ("Foobar" != "foobar")
        -> A sync is triggered.
    
    I have a productive calendar with about 2.000 events.
    The sync "loop" produces 3.6000+ INSERT / UPDATE statements
    on every click.
    
    Fix it by making the tag label comparison case insensitive.
    
    Signed-off-by: Michael J Rubinsky <mrubinsk at horde.org>

 kronolith/lib/Event.php |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/24181adf76bef93aaefba40ebf66d25ec1c7a05d
http://git.horde.org/horde-git/-/commit/24181adf76bef93aaefba40ebf66d25ec1c7a05d




More information about the commits mailing list