[commits] Horde branch master updated. abba424065d1634dff3184b28f7c7778e4a49ed4

Michael M Slusarz slusarz at horde.org
Thu Feb 6 08:09:52 UTC 2014


The branch "master" has been updated.
The following is a summary of the commits.

from: d57b13a58d2e149e8181b698c62bf7e4f83d5821

c952777 [mms] Abstract Horde configuration parsing into Horde_Registry_Hordeconfig class.
57df2cd Fix status() handling
8c6b502 Cleaner when written this way
0cf097b Use array_diff_key() here
abba424 Drastically reduce the calls to getValue().

Summary: http://github.com/horde/horde/compare/d57b13a58d2e149e8181b698c62bf7e4f83d5821...abba424065d1634dff3184b28f7c7778e4a49ed4

-----------------------------------------------------------------------

commit c952777dca33c2a57e890ff53d59d90ca749d0a4
Author: Michael M Slusarz <slusarz at horde.org>
Date:   Wed Feb 5 23:37:47 2014 -0700

    [mms] Abstract Horde configuration parsing into Horde_Registry_Hordeconfig class.
    
    The ultimate goal would be to directly use the config objects as the
    global $conf object.  It would have 2 immediate benefits (besides the
    general future benefits of OO flexibility in the future):
    
    1. On-demand config file loading.  If the application configuration is
    never used in an access, we would never have to even load the config
    file.
    2. Even if the config file is loaded, we would then have on-demand
    loading per key.  Which is still a win - merging configuration
    options in an application can be very expensive in an access that
    switches application contexts (I've seen 5% of script times spent in
    _mergeConfig).
    
    For now, just take advantage of abstraction by explicitly converting to
    array after generation.  Passes existing complex config parsing unit
    test, so we are no worse off than before.

 framework/Core/lib/Horde/Registry.php                    |   43 +----
 framework/Core/lib/Horde/Registry/Hordeconfig.php        |  140 ++++++++++++++
 framework/Core/lib/Horde/Registry/Hordeconfig/Merged.php |  124 ++++++++++++
 framework/Core/package.xml                               |   18 +-
 framework/Core/test/Horde/Core/RegistryTest.php          |   18 +-
 framework/Core/test/Horde/Core/Stub/Registry.php         |   39 ----
 6 files changed, 295 insertions(+), 87 deletions(-)
 create mode 100644 framework/Core/lib/Horde/Registry/Hordeconfig.php
 create mode 100644 framework/Core/lib/Horde/Registry/Hordeconfig/Merged.php
 delete mode 100644 framework/Core/test/Horde/Core/Stub/Registry.php

http://github.com/horde/horde/commit/c952777dca33c2a57e890ff53d59d90ca749d0a4
http://git.horde.org/horde-git/-/commit/c952777dca33c2a57e890ff53d59d90ca749d0a4

-----------------------------------------------------------------------

commit 57df2cd0341fc88f692f12a69c29c9db63e4bd2e
Author: Michael M Slusarz <slusarz at horde.org>
Date:   Thu Feb 6 00:03:02 2014 -0700

    Fix status() handling

 imp/lib/Imap.php |   15 +++++++--------
 1 files changed, 7 insertions(+), 8 deletions(-)

http://github.com/horde/horde/commit/57df2cd0341fc88f692f12a69c29c9db63e4bd2e
http://git.horde.org/horde-git/-/commit/57df2cd0341fc88f692f12a69c29c9db63e4bd2e

-----------------------------------------------------------------------

commit 8c6b502445272bfecf77e8d22b31d54185b21c9b
Author: Michael M Slusarz <slusarz at horde.org>
Date:   Thu Feb 6 00:28:55 2014 -0700

    Cleaner when written this way

 imp/lib/Ajax/Application/ListMessages.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://github.com/horde/horde/commit/8c6b502445272bfecf77e8d22b31d54185b21c9b
http://git.horde.org/horde-git/-/commit/8c6b502445272bfecf77e8d22b31d54185b21c9b

-----------------------------------------------------------------------

commit 0cf097b94fe30e89a70e4b08c0b9314f77c8df98
Author: Michael M Slusarz <slusarz at horde.org>
Date:   Thu Feb 6 00:56:14 2014 -0700

    Use array_diff_key() here

 turba/lib/Driver.php |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

http://github.com/horde/horde/commit/0cf097b94fe30e89a70e4b08c0b9314f77c8df98
http://git.horde.org/horde-git/-/commit/0cf097b94fe30e89a70e4b08c0b9314f77c8df98

-----------------------------------------------------------------------

commit abba424065d1634dff3184b28f7c7778e4a49ed4
Author: Michael M Slusarz <slusarz at horde.org>
Date:   Thu Feb 6 00:56:57 2014 -0700

    Drastically reduce the calls to getValue().
    
    Per xdebug, reduces self time in search() API call from 3% to < 1%.
    (My test example - addressbook search in IMP - reduce # of getValue
    calls from 1,514 to 112).

 turba/lib/Api.php |   31 +++++++++++++++----------------
 1 files changed, 15 insertions(+), 16 deletions(-)

http://github.com/horde/horde/commit/abba424065d1634dff3184b28f7c7778e4a49ed4
http://git.horde.org/horde-git/-/commit/abba424065d1634dff3184b28f7c7778e4a49ed4




More information about the commits mailing list