[commits] Horde branch master updated. d45e47aedf28e59145cc75361004cce7765b1a9d

Michael J. Rubinsky mrubinsk at horde.org
Tue Jun 2 00:12:36 UTC 2015


The branch "master" has been updated.
The following is a summary of the commits.

from: 1f3bae7b37dc16239972fab9e90bf0313d3c1fe4

d45e47a Fix sync "loop" of Kolab categories <-> Horde tags sync. Second part of #12770

Summary: http://github.com/horde/horde/compare/1f3bae7b37dc16239972fab9e90bf0313d3c1fe4...d45e47aedf28e59145cc75361004cce7765b1a9d

-----------------------------------------------------------------------

commit d45e47aedf28e59145cc75361004cce7765b1a9d
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date:   Sat May 30 18:14:14 2015 +0200

    Fix sync "loop" of Kolab categories <-> Horde tags sync. Second part of #12770
    
    Consider this scenario with a new, empty task list:
    
    1. User inserts the first task. The task is tagged with "foobar".
       This tag is inserted into the tagging backend.
    2. User creates another task with a foreign Kolab client.
       This task is tagged "Foobar" (noticed the capital 'F')
    3. nag syncs in the foreign task. The Kolab sync tells
       the tagging backend to store the tag(s) for the new task object,
       it does a case insensitive search for an existing tag label.
       -> it picks the existing row id of "foobar".
    
    The next time Nag_Task::synchronizeTags() runs, it notices
    the tags given by the Kolab driver for the second task
    differ from the tag backend ("Foobar" != "foobar")
        -> A sync is triggered.
    
    Fix it by making the tag label comparison case insensitive.
    A similar fix is already in place in kronolith.
    
    Signed-off-by: Michael J Rubinsky <mrubinsk at horde.org>

 nag/lib/Task.php |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/d45e47aedf28e59145cc75361004cce7765b1a9d




More information about the commits mailing list