[commits] Horde branch master updated. 015fd3addb112e4a436ad3d49fdb1981f06674eb
Michael M Slusarz
slusarz at horde.org
Wed Jun 3 06:17:50 UTC 2015
The branch "master" has been updated.
The following is a summary of the commits.
from: a927332f922d60651d83193e65a2eb3e1ab08441
558c8b9 Partially revert "[mms] Fix parsing icalendar attributes that contain duplicate keys."
015fd3a Use new Horde_Icalendar#getAttributeSingle()
Summary: http://github.com/horde/horde/compare/a927332f922d60651d83193e65a2eb3e1ab08441...015fd3addb112e4a436ad3d49fdb1981f06674eb
-----------------------------------------------------------------------
commit 558c8b90690611aa063e913beeaf79e5e1d5b1c4
Author: Michael M Slusarz <slusarz at horde.org>
Date: Wed Jun 3 00:00:17 2015 -0600
Partially revert "[mms] Fix parsing icalendar attributes that contain duplicate keys."
This reverts commit c4f07c6ca953f5d04603b9e10ad629e701ac103e.
getAttribute()'s API is too loose. There *really* should be a way to
force either a string value (lib makes best choice decision as to which
value, if multiple, should be returned) or array. But this is not
possible - it is up to caller to explicitly check for return type :(
Compromise: new getAttributeSingle() method
framework/Icalendar/lib/Horde/Icalendar.php | 25 ++++-
framework/Icalendar/package.xml | 12 +-
framework/Icalendar/test/Horde/Icalendar/AttributeTest.php | 2 +-
.../Icalendar/test/Horde/Icalendar/fixtures/multiple-summary.ics | 16 ++--
4 files changed, 38 insertions(+), 17 deletions(-)
http://github.com/horde/horde/commit/558c8b90690611aa063e913beeaf79e5e1d5b1c4
-----------------------------------------------------------------------
commit 015fd3addb112e4a436ad3d49fdb1981f06674eb
Author: Michael M Slusarz <slusarz at horde.org>
Date: Wed Jun 3 00:16:22 2015 -0600
Use new Horde_Icalendar#getAttributeSingle()
imp/lib/Ajax/Imple/ItipRequest.php | 20 ++++----
imp/lib/Mime/Viewer/Itip.php | 12 +++---
imp/package.xml | 2 +-
imp/test/Imp/Unit/Mime/Viewer/ItipTest.php | 65 ++++++++++++++++++++++------
4 files changed, 69 insertions(+), 30 deletions(-)
http://github.com/horde/horde/commit/015fd3addb112e4a436ad3d49fdb1981f06674eb
More information about the commits
mailing list