[commits] Horde branch master updated. c971fa53bede55ccb7122b2006b07e4ad1b666bd
Michael J. Rubinsky
mrubinsk at horde.org
Fri Jun 5 20:35:33 UTC 2015
The branch "master" has been updated.
The following is a summary of the commits.
from: e510069baf35662744334fcc2744e7f9287febd3
15b57f3 Update history instead of appending to it (=bloating)
ff34f3b Store Kolab_Storage_Factory in class (we need it later on)
ce68883 Compute proper history prefix for Kolab objects
9aaf8ba Only consider known 'action' values for finding the latest history entry
fc7565e Re-issue 'add' action for an object if the last action was 'delete'
9c97608 Only issue a 'delete' action if all copies of an object are gone
8e9463e Improve IMAP folder UIDVALIDITY change detection. Fixes #11807.
3f04c7a Full sync for the history database: Mark vanished entries as deleted
2741c01 Update history instead of appending to it
17d7809 Tie Kolab_Storage to Horde_History if enabled
9efe5be Fix Kolab <-> Horde_History sync marker: The 'sync' timestamp must be per folder
d00c195 Adapt Kolab Horde_History unit test to new id prefixes
0ebed7f New UT: Test stale history cleanup on full history sync
2c1c09b New UT: Ensure history does not get polluted for unknown folder types
a934342 New UT: Ensure no 'delete' action gets issued on duplicate removal
4d41bba New UT: Test for 'modify' action on object uid re-appearance
6e87e14 Use Horde_History modseq to find the latest entry of an object. This gets rid of the "delete" heuristic detection, too.
d4db576 Speed up history sync
f1ed9e1 Better detection if a full history sync is needed in a multi-process environment
61bc608 Better logging in case we can't compute the history prefix
f7c1491 Determine share id via the Horde_Share subsystem.
2efa590 Only compute history prefix if we have changes to process
3cdb616 Log if we have to do a full history sync (which is normal for initial syncs)
7178b3f Add logging to aid debugging (especially when interacting with ActiveSync)
0693959 This isn't used anywhere else, don't keep a reference to it.
e83258c cs, prefix protected members properly.
5b95144 private -> protected
3956351 INFO -> DEBUG
e3c7ec4 Fix merge.
0693b62 Horde::log should not be used outside of Core/Application code.
006d4ca Satisfy the interface.
20250fe ws/cs/phpdoc
1496bd2 Break out Core specific data.
2f7f132 Update package.xml filelist.
04040e7 Must set the logger.
4a2a269 cs/phpdoc etc...
84abaf3 Match method signature of parent.
1389049 This is static
4912c64 This is mostly Thomas' code.
cc36df0 No need to replace a body part with the exact same body part.
9d4c932 Short circuit the content decoding if it was already done server side.
e4f431c yay typehints.
188a29b phpdoc
a2f7df6 Add mock/stub for the prefix generator.
278bb56 Fix test error.
c971fa5 Fix merge/rebase.
Summary: http://github.com/horde/horde/compare/e510069baf35662744334fcc2744e7f9287febd3...c971fa53bede55ccb7122b2006b07e4ad1b666bd
-----------------------------------------------------------------------
commit 15b57f39d28e2d73f2febd3bd5ffae6681ea8de5
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Wed Mar 20 13:46:18 2013 +0100
Update history instead of appending to it (=bloating)
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 6 ++--
1 files changed, 3 insertions(+), 3 deletions(-)
http://github.com/horde/horde/commit/15b57f39d28e2d73f2febd3bd5ffae6681ea8de5
-----------------------------------------------------------------------
commit ff34f3b29c34926fa9c1231f679870b108353dec
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Wed Mar 20 13:50:08 2013 +0100
Store Kolab_Storage_Factory in class (we need it later on)
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 10 ++++-
1 files changed, 9 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/ff34f3b29c34926fa9c1231f679870b108353dec
-----------------------------------------------------------------------
commit ce6888374195c3d5c578886f982adbec94061c82
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Wed Mar 20 14:00:07 2013 +0100
Compute proper history prefix for Kolab objects
The IDs in the history database are always
formatted like this: "APPNAME:SHARE_ID:OBJECT_UID".
Kolab must compute the same prefix for objects
synced in from foreign clients. Otherwise client code
using the listBy() or getChanges() API (=ActiveSync)
would miss those objects.
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 79 ++++-
1 files changed, 76 insertions(+), 3 deletions(-)
http://github.com/horde/horde/commit/ce6888374195c3d5c578886f982adbec94061c82
-----------------------------------------------------------------------
commit 9aaf8ba05527de6bd54e3ca3d2ae1e6c00635f82
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Wed Mar 20 14:08:59 2013 +0100
Only consider known 'action' values for finding the latest history entry
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/9aaf8ba05527de6bd54e3ca3d2ae1e6c00635f82
-----------------------------------------------------------------------
commit fc7565e0cac4bfb9b4157feefa059a992baeed60
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Wed Mar 20 14:14:37 2013 +0100
Re-issue 'add' action for an object if the last action was 'delete'
In the Kolab world, objects can vanish
and re-appear using the same object uid.
(a foreign client is sending an update over a slow link,
we see the delete first and minutes later the APPEND/add request)
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 14 +++++
1 files changed, 14 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/fc7565e0cac4bfb9b4157feefa059a992baeed60
-----------------------------------------------------------------------
commit 9c976086cccfad6bb70e8c551d1f7cb9e29b17eb
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Wed Mar 20 14:24:56 2013 +0100
Only issue a 'delete' action if all copies of an object are gone
Otherwise we just deleted a duplicated object or updated the original one.
(An update results in an ADDED + DELETED folder action)
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 10 ++++-
1 files changed, 8 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/9c976086cccfad6bb70e8c551d1f7cb9e29b17eb
-----------------------------------------------------------------------
commit 8e9463e42526b5617b465a12fbc4ad565e016d08
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Wed Mar 20 14:38:06 2013 +0100
Improve IMAP folder UIDVALIDITY change detection. Fixes #11807.
We stored the whole list of IMAP UIDs of a folder next
to every object. This turned out to be a major memory
and CPU time hog (see #11807).
Instead we detect a change of UIDVALIDITY at the
IMAP folder cache level (where it belongs) and pass
the information about a reset situation to the
history 'query' as additional parameter.
framework/Kolab_Storage/lib/Horde/Kolab/Storage/Data/Cached.php | 13 ++-
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 27 +++--
2 files changed, 25 insertions(+), 15 deletions(-)
http://github.com/horde/horde/commit/8e9463e42526b5617b465a12fbc4ad565e016d08
-----------------------------------------------------------------------
commit 3f04c7ac989faecf4dd64b786d94225b6349c2fb
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Wed Mar 20 14:47:55 2013 +0100
Full sync for the history database: Mark vanished entries as deleted
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 40 ++++-
1 files changed, 37 insertions(+), 3 deletions(-)
http://github.com/horde/horde/commit/3f04c7ac989faecf4dd64b786d94225b6349c2fb
-----------------------------------------------------------------------
commit 2741c0132ae04ff38807c5fab7700650f147c087
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Wed Mar 20 15:12:12 2013 +0100
Update history instead of appending to it
.../lib/Horde/Kolab/Storage/Data/Query/History/Cache.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/2741c0132ae04ff38807c5fab7700650f147c087
-----------------------------------------------------------------------
commit 17d780945b033b3721c6fb85bbb6ad5c3bb2a315
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Thu Mar 21 11:50:07 2013 +0100
Tie Kolab_Storage to Horde_History if enabled
Otherwise Kolab_Storage_Factory::createHistory()
will use the in-memory only Horde_History_Mock object.
framework/Core/lib/Horde/Core/Factory/KolabStorage.php | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/17d780945b033b3721c6fb85bbb6ad5c3bb2a315
-----------------------------------------------------------------------
commit 9efe5bef4e7ebc3aa23131616b8549679ec93bb1
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Thu Mar 21 15:10:38 2013 +0100
Fix Kolab <-> Horde_History sync marker: The 'sync' timestamp must be per folder
Otherwise one folder overwrites the sync marker of other folders.
We need to keep our own timestamp since the sync of a folder cache
might be successful but the history sync could fail (timeout etc).
.../lib/Horde/Kolab/Storage/Data/Query/History/Cache.php | 7 +++-
1 files changed, 5 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/9efe5bef4e7ebc3aa23131616b8549679ec93bb1
-----------------------------------------------------------------------
commit d00c1954daab328bc36b39fa873173345ea9cdf9
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Fri Mar 22 15:23:40 2013 +0100
Adapt Kolab Horde_History unit test to new id prefixes
.../test/Horde/Kolab/Storage/Unit/Data/Query/History/BaseTest.php | 46 +++-
.../Kolab_Storage/test/Horde/Kolab/Storage/fixtures/note2.eml | 42 ++++
2 files changed, 76 insertions(+), 12 deletions(-)
create mode 100644 framework/Kolab_Storage/test/Horde/Kolab/Storage/fixtures/note2.eml
http://github.com/horde/horde/commit/d00c1954daab328bc36b39fa873173345ea9cdf9
-----------------------------------------------------------------------
commit 0ebed7f40b7a4fa0c5f7230d39b233ee9aa2032f
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Fri Mar 22 16:27:25 2013 +0100
New UT: Test stale history cleanup on full history sync
.../test/Horde/Kolab/Storage/Unit/Data/Query/History/BaseTest.php | 54 +++++
1 files changed, 54 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/0ebed7f40b7a4fa0c5f7230d39b233ee9aa2032f
-----------------------------------------------------------------------
commit 2c1c09bdd15583a8fdfa2a1649f7a482fa10e63b
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Mon Mar 25 14:54:48 2013 +0100
New UT: Ensure history does not get polluted for unknown folder types
.../test/Horde/Kolab/Storage/Unit/Data/Query/History/BaseTest.php | 74 ++++-
1 files changed, 60 insertions(+), 14 deletions(-)
http://github.com/horde/horde/commit/2c1c09bdd15583a8fdfa2a1649f7a482fa10e63b
-----------------------------------------------------------------------
commit a93434202694a4b273f0e00230037f9b2485aa8e
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Mon Mar 25 16:24:01 2013 +0100
New UT: Ensure no 'delete' action gets issued on duplicate removal
.../test/Horde/Kolab/Storage/Unit/Data/Query/History/BaseTest.php | 37 +++++
1 files changed, 37 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/a93434202694a4b273f0e00230037f9b2485aa8e
-----------------------------------------------------------------------
commit 4d41bba16ec7990b24ba89a9d525235ff4fabb85
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Mon Mar 25 17:19:23 2013 +0100
New UT: Test for 'modify' action on object uid re-appearance
.../test/Horde/Kolab/Storage/Unit/Data/Query/History/BaseTest.php | 39 +++++
1 files changed, 39 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/4d41bba16ec7990b24ba89a9d525235ff4fabb85
-----------------------------------------------------------------------
commit 6e87e14f1c725723d2a2aa912641f42dc4d7e802
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Thu Jul 25 12:05:00 2013 +0200
Use Horde_History modseq to find the latest entry of an object.
This gets rid of the "delete" heuristic detection, too.
Note: The minimum supported Horde_History version is 2.1.0.
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 8 +---
1 files changed, 2 insertions(+), 6 deletions(-)
http://github.com/horde/horde/commit/6e87e14f1c725723d2a2aa912641f42dc4d7e802
-----------------------------------------------------------------------
commit d4db576f64ee538999dbb255ab95e0cd1a08f07a
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Sat Aug 10 18:35:52 2013 +0200
Speed up history sync
Use new Horde_History->getLatestEntry($object) function
which greatly speeds up the sync process.
Also don't mark objects as deleted if they
are already deleted in the complete re-sync mode.
(we sent out a lot of unnecesssary delete requests via ActiveSync)
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 25 ++---
1 files changed, 11 insertions(+), 14 deletions(-)
http://github.com/horde/horde/commit/d4db576f64ee538999dbb255ab95e0cd1a08f07a
-----------------------------------------------------------------------
commit f1ed9e130b2a240e8db38d3150795ae1bb75fc35
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Thu Aug 22 17:38:05 2013 +0200
Better detection if a full history sync is needed in a multi-process environment
If our stored 'last_sync' timestamp is newer than the logged 'sync'
action in the history database, the last history update aborted for some reason.
If the 'sync' action from the history database is newer, it means
our in-memory version of the data_cache was outdated
and already updated by another process.
.../lib/Horde/Kolab/Storage/Data/Query/History/Cache.php | 24 ++++-
1 files changed, 19 insertions(+), 5 deletions(-)
http://github.com/horde/horde/commit/f1ed9e130b2a240e8db38d3150795ae1bb75fc35
-----------------------------------------------------------------------
commit 61bc60860049743fb960f0198222ebc427552c35
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Mon Sep 2 20:55:37 2013 +0200
Better logging in case we can't compute the history prefix
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 15 +++-
1 files changed, 11 insertions(+), 4 deletions(-)
http://github.com/horde/horde/commit/61bc60860049743fb960f0198222ebc427552c35
-----------------------------------------------------------------------
commit f7c14912c0adf7e930a634018b04369850d57e42
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Mon Sep 2 21:41:46 2013 +0200
Determine share id via the Horde_Share subsystem.
Calling getParameters() might be a bit faster
but this approach fails when the share has
never been "saved" via horde -> There is no annotation.
This change will most likely break the unit test
since we now depend on Horde_Share. Needs checking.
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 34 +++--
1 files changed, 19 insertions(+), 15 deletions(-)
http://github.com/horde/horde/commit/f7c14912c0adf7e930a634018b04369850d57e42
-----------------------------------------------------------------------
commit 2efa59026f04bf25c0d707632f9e12ef6af682d8
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Mon Sep 2 21:57:42 2013 +0200
Only compute history prefix if we have changes to process
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 30 +++--
1 files changed, 20 insertions(+), 10 deletions(-)
http://github.com/horde/horde/commit/2efa59026f04bf25c0d707632f9e12ef6af682d8
-----------------------------------------------------------------------
commit 3cdb6165e95b223d98c3c1c199df2268e00bb21c
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Mon Sep 2 21:58:21 2013 +0200
Log if we have to do a full history sync (which is normal for initial syncs)
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/3cdb6165e95b223d98c3c1c199df2268e00bb21c
-----------------------------------------------------------------------
commit 7178b3fdc60969a070043d0f2e1eb950b9b8b72f
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Tue Sep 3 14:50:58 2013 +0200
Add logging to aid debugging (especially when interacting with ActiveSync)
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 20 +++-
1 files changed, 15 insertions(+), 5 deletions(-)
http://github.com/horde/horde/commit/7178b3fdc60969a070043d0f2e1eb950b9b8b72f
-----------------------------------------------------------------------
commit 069395946d5064aded2af446805dcf81a409934c
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu May 14 17:41:05 2015 -0400
This isn't used anywhere else, don't keep a reference to it.
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 11 +----
1 files changed, 1 insertions(+), 10 deletions(-)
http://github.com/horde/horde/commit/069395946d5064aded2af446805dcf81a409934c
-----------------------------------------------------------------------
commit e83258cdd3e6c3dbecbb73b4390fe2b0dcfc3be9
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu May 14 17:44:35 2015 -0400
cs, prefix protected members properly.
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 42 ++---
.../lib/Horde/Kolab/Storage/Data/Query/History/Cache.php | 10 +-
2 files changed, 25 insertions(+), 27 deletions(-)
http://github.com/horde/horde/commit/e83258cdd3e6c3dbecbb73b4390fe2b0dcfc3be9
-----------------------------------------------------------------------
commit 5b951444e2959f788a67ebd98aacc4f2260efc34
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu May 14 17:45:52 2015 -0400
private -> protected
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 2 +-
.../lib/Horde/Kolab/Storage/Data/Query/Preferences/Base.php | 4 +-
.../test/Horde/Kolab/Storage/Unit/Data/Query/History/BaseTest.php | 8 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
http://github.com/horde/horde/commit/5b951444e2959f788a67ebd98aacc4f2260efc34
-----------------------------------------------------------------------
commit 395635111ddde15dd9f0183d75d9be079cc728a5
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu May 14 17:50:39 2015 -0400
INFO -> DEBUG
framework/Kolab_Storage/lib/Horde/Kolab/Storage/Data/Cached.php | 15 +++----
1 files changed, 6 insertions(+), 9 deletions(-)
http://github.com/horde/horde/commit/395635111ddde15dd9f0183d75d9be079cc728a5
-----------------------------------------------------------------------
commit e3c7ec4f41004868eafdbef0d93cffa74301149f
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu May 14 17:54:05 2015 -0400
Fix merge.
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/e3c7ec4f41004868eafdbef0d93cffa74301149f
-----------------------------------------------------------------------
commit 0693b6251328dde42c08f54585c3332b8201eb69
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu May 14 18:17:27 2015 -0400
Horde::log should not be used outside of Core/Application code.
.../Kolab_Storage/lib/Horde/Kolab/Storage/Data/Decorator/Log.php | 5 +-
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 68 ++++-
.../lib/Horde/Kolab/Storage/Data/Query/History/Cache.php | 10 +-
3 files changed, 67 insertions(+), 16 deletions(-)
http://github.com/horde/horde/commit/0693b6251328dde42c08f54585c3332b8201eb69
-----------------------------------------------------------------------
commit 006d4ca63e09f755bfa3e4d99439f078835b44d6
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu May 14 21:26:25 2015 -0400
Satisfy the interface.
framework/Kolab_Storage/lib/Horde/Kolab/Storage/Data/Query.php | 1 +
.../lib/Horde/Kolab/Storage/Data/Query/Preferences/Base.php | 6 +++++
.../lib/Horde/Kolab/Storage/Data/Query/Preferences/Cache.php | 6 +++++
.../Kolab_Storage/test/Horde/Kolab/Storage/Stub/DataQuery.php | 5 ++++
4 files changed, 18 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/006d4ca63e09f755bfa3e4d99439f078835b44d6
-----------------------------------------------------------------------
commit 20250fee68a0c6dd68ea11650386718119eb0dfc
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu May 14 21:26:41 2015 -0400
ws/cs/phpdoc
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 47 ++---
.../lib/Horde/Kolab/Storage/Data/Query/History/Cache.php | 3 +-
.../Kolab_Storage/test/Horde/Kolab/Storage/Unit/Data/BaseTest.php | 2 +-
3 files changed, 23 insertions(+), 29 deletions(-)
http://github.com/horde/horde/commit/20250fee68a0c6dd68ea11650386718119eb0dfc
-----------------------------------------------------------------------
commit 1496bd21af11361e52ea0e5a161aa7717a5f84ab
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Mon May 18 16:42:59 2015 -0400
Break out Core specific data.
Implement an interface that provides a History prefix. This is
most likely a stop-gap until Horde 6 when this would probably be
better suited to being a decorator/wrapper of the Horde_History
object itself.
framework/Core/lib/Horde/Core/Factory/KolabStorage.php | 1 +
framework/Core/lib/Horde/Core/Kolab/Storage/HistoryPrefix.php | 79 ++++
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 99 +----
framework/Kolab_Storage/lib/Horde/Kolab/Storage/Factory.php | 23 +-
framework/Kolab_Storage/lib/Horde/Kolab/Storage/HistoryPrefix.php | 33 ++
5 files changed, 145 insertions(+), 90 deletions(-)
create mode 100644 framework/Core/lib/Horde/Core/Kolab/Storage/HistoryPrefix.php
create mode 100644 framework/Kolab_Storage/lib/Horde/Kolab/Storage/HistoryPrefix.php
http://github.com/horde/horde/commit/1496bd21af11361e52ea0e5a161aa7717a5f84ab
-----------------------------------------------------------------------
commit 2f7f13252890b3bd5a913cc9eaa3c6dc9377d64d
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Mon May 18 16:56:49 2015 -0400
Update package.xml filelist.
framework/Core/package.xml | 10 ++++++++--
framework/Kolab_Storage/package.xml | 8 ++++++--
2 files changed, 14 insertions(+), 4 deletions(-)
http://github.com/horde/horde/commit/2f7f13252890b3bd5a913cc9eaa3c6dc9377d64d
-----------------------------------------------------------------------
commit 04040e774f4a0852aa228b360619fd11f8720888
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Mon May 18 23:23:03 2015 -0400
Must set the logger.
framework/Kolab_Storage/lib/Horde/Kolab/Storage/Data/Base.php | 1 +
.../Kolab_Storage/lib/Horde/Kolab/Storage/Data/Decorator/Log.php | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/04040e774f4a0852aa228b360619fd11f8720888
-----------------------------------------------------------------------
commit 4a2a269254f2bea9720dd157254b9c2e1bb19b49
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Mon May 18 23:40:32 2015 -0400
cs/phpdoc etc...
framework/Core/lib/Horde/Core/Kolab/Storage/HistoryPrefix.php | 12 +++++
framework/Kolab_Storage/lib/Horde/Kolab/Storage/Cache/Data.php | 8 ++--
framework/Kolab_Storage/lib/Horde/Kolab/Storage/Data/Cached.php | 11 ++--
.../Kolab_Storage/lib/Horde/Kolab/Storage/Data/Decorator/Log.php | 8 ++-
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 2 +
.../lib/Horde/Kolab/Storage/Data/Query/History/Cache.php | 2 +-
framework/Kolab_Storage/lib/Horde/Kolab/Storage/Decorator/Log.php | 6 +-
.../lib/Horde/Kolab/Storage/Decorator/Synchronization.php | 7 ++-
framework/Kolab_Storage/lib/Horde/Kolab/Storage/HistoryPrefix.php | 10 ++--
nag/lib/Driver/Kolab.php | 2 +-
10 files changed, 43 insertions(+), 25 deletions(-)
http://github.com/horde/horde/commit/4a2a269254f2bea9720dd157254b9c2e1bb19b49
-----------------------------------------------------------------------
commit 84abaf393cbd301ca4827b155db41dbe26b50916
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun May 24 20:09:12 2015 -0400
Match method signature of parent.
nag/lib/Driver/Kolab.php | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/84abaf393cbd301ca4827b155db41dbe26b50916
-----------------------------------------------------------------------
commit 1389049d8cf5c3a8d701debd04b540364fc96d44
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun May 24 20:10:42 2015 -0400
This is static
framework/Core/lib/Horde/Core/Kolab/Storage/HistoryPrefix.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/1389049d8cf5c3a8d701debd04b540364fc96d44
-----------------------------------------------------------------------
commit 4912c6406a54bac7c6993e12ef7dc3217e1d89c2
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Thu May 28 12:40:23 2015 -0400
This is mostly Thomas' code.
framework/Core/lib/Horde/Core/Kolab/Storage/HistoryPrefix.php | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/4912c6406a54bac7c6993e12ef7dc3217e1d89c2
-----------------------------------------------------------------------
commit cc36df08d3aef06b72b00831ed82384f7e38461a
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Mon Jun 1 14:30:51 2015 -0400
No need to replace a body part with the exact same body part.
No idea why this was done. Traced back to commit 0d2544c. Started
polling the IMAP server for both the original part and the bodypart.
Previous commit was 6c6db9e, when support for modifying objects
was first introduced (even then, hard to say if this was ultimately
happening since the actions are so spread out among different, deep,
class structures.
Anyway, this seems to work, and fixes an issue that was causing
the data to be decoded into some kind of binary data instead of
the XML data is really is.
framework/Kolab_Storage/lib/Horde/Kolab/Storage/Object.php | 11 +----------
1 files changed, 1 insertions(+), 10 deletions(-)
http://github.com/horde/horde/commit/cc36df08d3aef06b72b00831ed82384f7e38461a
-----------------------------------------------------------------------
commit 9d4c9323bca19cd8d722dbbb882b72390109f3a7
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Mon Jun 1 14:36:40 2015 -0400
Short circuit the content decoding if it was already done server side.
framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Imap.php | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/9d4c9323bca19cd8d722dbbb882b72390109f3a7
-----------------------------------------------------------------------
commit e4f431cb937bfe4db3664a0e9b8e72e232239a81
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Mon Jun 1 18:37:49 2015 -0400
yay typehints.
.../lib/Horde/Kolab/Storage/Data/Query/History/Base.php | 9 +++--
.../lib/Horde/Kolab/Storage/Data/Query/Preferences/Base.php | 2 +-
2 files changed, 7 insertions(+), 4 deletions(-)
http://github.com/horde/horde/commit/e4f431cb937bfe4db3664a0e9b8e72e232239a81
-----------------------------------------------------------------------
commit 188a29b3bc64e9fb1446de9a691ba4cee635ad6d
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Fri Jun 5 11:43:22 2015 -0400
phpdoc
framework/Kolab_Storage/lib/Horde/Kolab/Storage/Factory.php | 19 ++++++----
1 files changed, 11 insertions(+), 8 deletions(-)
http://github.com/horde/horde/commit/188a29b3bc64e9fb1446de9a691ba4cee635ad6d
-----------------------------------------------------------------------
commit a2f7df62fe8749bfed6527a2f1eabb8b8139c4d4
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Fri Jun 5 11:45:24 2015 -0400
Add mock/stub for the prefix generator.
Fixes first round of test failures, and allows another set to fail :)
framework/Kolab_Storage/package.xml | 10 +-
.../Kolab_Storage/test/Horde/Kolab/Storage/Stub/HistoryPrefix.php | 50 +++++
framework/Kolab_Storage/test/Horde/Kolab/Storage/TestCase.php | 1 +
3 files changed, 59 insertions(+), 2 deletions(-)
create mode 100644 framework/Kolab_Storage/test/Horde/Kolab/Storage/Stub/HistoryPrefix.php
http://github.com/horde/horde/commit/a2f7df62fe8749bfed6527a2f1eabb8b8139c4d4
-----------------------------------------------------------------------
commit 278bb5617964b52ec301bf755a2710231b743241
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Fri Jun 5 11:48:01 2015 -0400
Fix test error.
Tests now pass.
.../Kolab_Storage/test/Horde/Kolab/Storage/Stub/HistoryPrefix.php | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/278bb5617964b52ec301bf755a2710231b743241
-----------------------------------------------------------------------
commit c971fa53bede55ccb7122b2006b07e4ad1b666bd
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Fri Jun 5 16:08:15 2015 -0400
Fix merge/rebase.
framework/Kolab_Storage/lib/Horde/Kolab/Storage/Data/Cached.php | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/c971fa53bede55ccb7122b2006b07e4ad1b666bd
More information about the commits
mailing list