[commits] Horde branch master updated. 90c7625d4b148a3871df229d5e14a3dae4f8b64b

Michael J. Rubinsky mrubinsk at horde.org
Thu May 14 19:02:33 UTC 2015


The branch "master" has been updated.
The following is a summary of the commits.

from: bc85e5fa994e654ec90dc9ed72cf3f229fc2d9d6

9ad50e9 private -> protected
21517b8 cs
fc5f6e9 This fixes a broken mock object in the tests.
217a47e Test against the interface, since we might be wrapped with a decorator.
90c7625 Some more cs,ws etc...

Summary: http://github.com/horde/horde/compare/bc85e5fa994e654ec90dc9ed72cf3f229fc2d9d6...90c7625d4b148a3871df229d5e14a3dae4f8b64b

-----------------------------------------------------------------------

commit 9ad50e9760384d09c874f76142c8b51f63fcedc1
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Thu May 14 14:20:15 2015 -0400

    private -> protected

 framework/Kolab_Storage/lib/Horde/Kolab/Storage/Base.php |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

http://github.com/horde/horde/commit/9ad50e9760384d09c874f76142c8b51f63fcedc1

-----------------------------------------------------------------------

commit 21517b8b1f588e25887c79f910a884226e89ff40
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Thu May 14 14:22:15 2015 -0400

    cs
    
    Always use protected unless there is a good reason not to.
    ws, phpdoc, proper variable/member/property naming.

 framework/Kolab_Storage/lib/Horde/Kolab/Storage/Cache.php     |   57 +++------
 framework/Kolab_Storage/lib/Horde/Kolab/Storage/Data/Base.php |   27 ++---
 framework/Kolab_Storage/lib/Horde/Kolab/Storage/Object.php    |   41 +++---
 framework/Kolab_Storage/lib/Horde/Kolab/Storage/Query.php     |    2 -
 4 files changed, 51 insertions(+), 76 deletions(-)

http://github.com/horde/horde/commit/21517b8b1f588e25887c79f910a884226e89ff40

-----------------------------------------------------------------------

commit fc5f6e9d11733c1dcbadd984a04b1e84f5c1f783
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Thu May 14 15:01:09 2015 -0400

    This fixes a broken mock object in the tests.

 framework/Kolab_Storage/lib/Horde/Kolab/Storage/Data.php          |    7 +++++
 .../Kolab_Storage/lib/Horde/Kolab/Storage/Data/Decorator/Log.php  |    5 +++
 2 files changed, 12 insertions(+), 0 deletions(-)

http://github.com/horde/horde/commit/fc5f6e9d11733c1dcbadd984a04b1e84f5c1f783

-----------------------------------------------------------------------

commit 217a47e686d1a2637f240e0e088d197df570ba23
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Thu May 14 15:01:37 2015 -0400

    Test against the interface, since we might be wrapped with a decorator.

 .../Kolab_Storage/test/Horde/Kolab/Storage/Unit/CachedTest.php    |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://github.com/horde/horde/commit/217a47e686d1a2637f240e0e088d197df570ba23

-----------------------------------------------------------------------

commit 90c7625d4b148a3871df229d5e14a3dae4f8b64b
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Thu May 14 15:02:10 2015 -0400

    Some more cs,ws etc...

 .../Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Mock/Data.php    |    1 +
 framework/Kolab_Storage/lib/Horde/Kolab/Storage/Object.php        |    1 +
 framework/Kolab_Storage/lib/Horde/Kolab/Storage/Queriable.php     |    2 --
 .../Kolab_Storage/lib/Horde/Kolab/Storage/Synchronization.php     |    2 +-
 4 files changed, 3 insertions(+), 3 deletions(-)

http://github.com/horde/horde/commit/90c7625d4b148a3871df229d5e14a3dae4f8b64b




More information about the commits mailing list