[commits] Horde branch master updated. 8d3c9e22642d3d7b16ce8dfc82b7186bff76ebe9
Michael J. Rubinsky
mrubinsk at horde.org
Sun Apr 10 16:36:27 UTC 2016
The branch "master" has been updated.
The following is a summary of the commits.
from: b58b7b5c69fb5f380385531d4d6c5aa6d9de1876
09213da Protect against duplicate synckey in cache.
48b3e3c No need to pass this around, it's already available in the object.
0803d9e Tweak comment.
405d7a2 Simplify.
9d0b832 phpdoc
71bf0d6 Remove broken conditional.
c26ede7 Another useless check. This is always true now.
467fbc8 Tweak comments.
f8e9854 @todo
9baf330 @todo++
e8dcee7 @todo--
71e2faf BFN
e1c7d34 Parse error
8d3c9e2 Use the short form for UTC like we do everywhere else in Horde.
Summary: http://github.com/horde/horde/compare/b58b7b5c69fb5f380385531d4d6c5aa6d9de1876...8d3c9e22642d3d7b16ce8dfc82b7186bff76ebe9
-----------------------------------------------------------------------
commit 09213da87c844a71a0eb3be4afbe5cbe2f37f0c8
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Apr 5 09:23:44 2016 -0400
Protect against duplicate synckey in cache.
This should never happen, synckeys should always be unique to
each collection. However, broken/corrupt clients may send the
wrong synckey/collection pair.
framework/ActiveSync/lib/Horde/ActiveSync/State/Mongo.php | 2 +-
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/09213da87c844a71a0eb3be4afbe5cbe2f37f0c8
-----------------------------------------------------------------------
commit 48b3e3ca78a15835d3ca202a30f343ee78ebdcc4
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Tue Apr 5 09:31:32 2016 -0400
No need to pass this around, it's already available in the object.
framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php | 7 +----
framework/ActiveSync/lib/Horde/ActiveSync/State/Mongo.php | 14 ++++--------
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 14 ++++--------
3 files changed, 12 insertions(+), 23 deletions(-)
http://github.com/horde/horde/commit/48b3e3ca78a15835d3ca202a30f343ee78ebdcc4
-----------------------------------------------------------------------
commit 0803d9e0a42c4118c67c84f641d874c4a5c56b22
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Fri Apr 8 07:55:04 2016 -0400
Tweak comment.
framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
http://github.com/horde/horde/commit/0803d9e0a42c4118c67c84f641d874c4a5c56b22
-----------------------------------------------------------------------
commit 405d7a2a5d69fa3dbb3b0c2747124c941c3b66c1
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Apr 9 10:54:06 2016 -0400
Simplify.
Set the GETCHANGES value in one place.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 43 +++++-------
1 files changed, 19 insertions(+), 24 deletions(-)
http://github.com/horde/horde/commit/405d7a2a5d69fa3dbb3b0c2747124c941c3b66c1
-----------------------------------------------------------------------
commit 9d0b832009a0a369f9fd966ab5b3418cbcd49a2b
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Apr 9 10:54:48 2016 -0400
phpdoc
framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/9d0b832009a0a369f9fd966ab5b3418cbcd49a2b
-----------------------------------------------------------------------
commit 71bf0d649f03fbbe7cd89d7fe9d91e938f09cd6b
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Apr 9 11:00:16 2016 -0400
Remove broken conditional.
$sync and $importer are always non-existent - left over cruft.
$collection['synckey'] is always a string, so the equality comparison
to (int)0 will always succeed. The end result is that the code *worked*,
since the equality check always passed, but for the wrong reasons.
In current code, this block of code is only ever reached when the state
should be saved, so no need for any of these checks.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 16 +++---------
1 files changed, 4 insertions(+), 12 deletions(-)
http://github.com/horde/horde/commit/71bf0d649f03fbbe7cd89d7fe9d91e938f09cd6b
-----------------------------------------------------------------------
commit c26ede7de84cb2ada299287db48c3fc8820397a7
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Apr 9 11:03:34 2016 -0400
Another useless check. This is always true now.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
http://github.com/horde/horde/commit/c26ede7de84cb2ada299287db48c3fc8820397a7
-----------------------------------------------------------------------
commit 467fbc819f22dcceadbe67aed4c44db2c98541a2
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sat Apr 9 11:09:27 2016 -0400
Tweak comments.
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 11 +++++------
1 files changed, 5 insertions(+), 6 deletions(-)
http://github.com/horde/horde/commit/467fbc819f22dcceadbe67aed4c44db2c98541a2
-----------------------------------------------------------------------
commit f8e9854d5d0da7c8308d9238c8ad47880deb519e
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Apr 10 12:06:29 2016 -0400
@todo
Tried doing this for Horde 5, but too much workarounds to keep it BC.
framework/ActiveSync/doc/Horde/ActiveSync/TODO | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/f8e9854d5d0da7c8308d9238c8ad47880deb519e
-----------------------------------------------------------------------
commit 9baf33010894eef0f6a6b88d72a4ae63aab51feb
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Apr 10 12:08:46 2016 -0400
@todo++
framework/ActiveSync/doc/Horde/ActiveSync/TODO | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/9baf33010894eef0f6a6b88d72a4ae63aab51feb
-----------------------------------------------------------------------
commit e8dcee7a454c80bedffa004c05cf5b6ec8071eee
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Apr 10 12:09:39 2016 -0400
@todo--
framework/ActiveSync/doc/Horde/ActiveSync/TODO | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
http://github.com/horde/horde/commit/e8dcee7a454c80bedffa004c05cf5b6ec8071eee
-----------------------------------------------------------------------
commit 71e2faffee726dd3e24023d1c16a70f60564e82a
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Apr 10 12:12:00 2016 -0400
BFN
framework/ActiveSync/package.xml | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/71e2faffee726dd3e24023d1c16a70f60564e82a
-----------------------------------------------------------------------
commit e1c7d347dc54e4927f844f57334f322e771e0615
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Apr 10 12:13:19 2016 -0400
Parse error
framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/e1c7d347dc54e4927f844f57334f322e771e0615
-----------------------------------------------------------------------
commit 8d3c9e22642d3d7b16ce8dfc82b7186bff76ebe9
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date: Sun Apr 10 12:33:51 2016 -0400
Use the short form for UTC like we do everywhere else in Horde.
Fixes a number of tests and equality checks where we compare against
UTC explicitly.
framework/Date/lib/Horde/Date.php | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
http://github.com/horde/horde/commit/8d3c9e22642d3d7b16ce8dfc82b7186bff76ebe9
More information about the commits
mailing list