[commits] Horde branch master updated. c9b4f5304f134508cfa94ef2b42b834e5193acf4

Jan Schneider jan at horde.org
Fri Aug 12 13:27:25 UTC 2016


The branch "master" has been updated.
The following is a summary of the commits.

from: 4fe872a23b186c858b22428391b3c452279054f4

3beb82b Don't overwrite $rows.
9b68135 Use delete().
5b69d7a [jan] Fix deleting retrieved tasks from SQL storage.
c9b4f53 Use select() instead of selectAll() where applicable.

Summary: http://github.com/horde/horde/compare/4fe872a23b186c858b22428391b3c452279054f4...c9b4f5304f134508cfa94ef2b42b834e5193acf4

-----------------------------------------------------------------------

commit 3beb82b86fa986aab70a921258eefb6d369d47d0
Author: Jan Schneider <jan at horde.org>
Date:   Fri Aug 12 15:03:59 2016 +0200

    Don't overwrite $rows.

 framework/Queue/lib/Horde/Queue/Storage/Db.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/3beb82b86fa986aab70a921258eefb6d369d47d0

-----------------------------------------------------------------------

commit 9b6813510c5dde812babe2d9be06c0c0d9ce6996
Author: Jan Schneider <jan at horde.org>
Date:   Fri Aug 12 15:05:02 2016 +0200

    Use delete().

 framework/Queue/lib/Horde/Queue/Storage/Db.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

http://github.com/horde/horde/commit/9b6813510c5dde812babe2d9be06c0c0d9ce6996

-----------------------------------------------------------------------

commit 5b69d7ab4a481f9588259ab2da936021c4a06c07
Author: Jan Schneider <jan at horde.org>
Date:   Fri Aug 12 15:06:20 2016 +0200

    [jan] Fix deleting retrieved tasks from SQL storage.

 framework/Queue/package.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/5b69d7ab4a481f9588259ab2da936021c4a06c07

-----------------------------------------------------------------------

commit c9b4f5304f134508cfa94ef2b42b834e5193acf4
Author: Jan Schneider <jan at horde.org>
Date:   Fri Aug 12 15:11:01 2016 +0200

    Use select() instead of selectAll() where applicable.
    
    select() is much more resource friendly, because it doesn't copy the complete result set into an array, but uses the database's result paging capabilities instead while traversing over the result set.
    It can safely be used where we simply loop over the result set. If we need the array structure instead, or want to manipulate the rows inside the loop, selectAll() should still be used.

 agora/lib/Driver.php                               | 14 +++++++-------
 agora/lib/Driver/SplitSql.php                      |  6 +++---
 ansel/lib/Storage.php                              |  4 ++--
 .../10_ansel_upgrade_computestylehashes.php        |  4 ++--
 ansel/migration/3_ansel_upgrade_style.php          |  2 +-
 ansel/migration/4_ansel_upgrade_tagstocontent.php  |  4 ++--
 .../migration/5_ansel_upgrade_categoriestotags.php |  2 +-
 content/lib/Objects/Manager.php                    |  2 +-
 content/lib/Tagger.php                             |  4 ++--
 content/lib/Users/Manager.php                      |  2 +-
 content/test/Content/Sql/Base.php                  |  4 ++--
 .../ActiveSync/lib/Horde/ActiveSync/State/Sql.php  |  6 +++---
 .../20_horde_activesync_removesynccounters.php     |  2 +-
 framework/Alarm/lib/Horde/Alarm/Sql.php            |  4 ++--
 framework/Auth/lib/Horde/Auth/Cyrsql.php           |  2 +-
 framework/Core/lib/Horde/Core/Auth/Signup/Sql.php  |  5 +----
 framework/Lock/lib/Horde/Lock/Sql.php              |  2 +-
 framework/Prefs/lib/Horde/Prefs/Storage/Sql.php    |  2 +-
 framework/Queue/lib/Horde/Queue/Storage/Db.php     |  2 +-
 framework/Share/lib/Horde/Share/Sql.php            | 22 +++++++++++-----------
 framework/Share/lib/Horde/Share/Sqlng.php          |  8 ++++----
 framework/Vfs/lib/Horde/Vfs/Musql.php              | 14 +++++++-------
 hermes/lib/Driver/Sql.php                          |  8 ++++----
 ingo/lib/Storage/Sql.php                           |  2 +-
 .../bin/kronolith-convert-datatree-shares-to-sql   |  2 +-
 kronolith/bin/kronolith-convert-to-utc             |  2 +-
 kronolith/lib/Driver/Sql.php                       |  2 +-
 .../21_kronolith_upgrade_exceptionutc.php          |  4 ++--
 .../24_kronolith_upgrade_resourcestoshares.php     |  2 +-
 mnemo/bin/mnemo-convert-datatree-shares-to-sql     |  2 +-
 mnemo/bin/mnemo-convert-to-utf8                    |  2 +-
 mnemo/lib/Driver/Sql.php                           |  2 +-
 nag/lib/Driver/Sql.php                             |  6 +++---
 trean/lib/Bookmarks.php                            |  6 +++---
 turba/bin/turba-convert-datatree-shares-to-sql     |  2 +-
 turba/lib/Api.php                                  |  2 +-
 turba/lib/Driver/Sql.php                           |  4 ++--
 ulaform/lib/Driver/Sql.php                         |  2 +-
 whups/bin/whups-convert-datatree-shares-to-sql     |  2 +-
 whups/lib/Driver/Sql.php                           | 20 ++++++++++----------
 whups/migration/6_whups_upgrade_transactions.php   |  4 ++--
 wicked/bin/wicked-convert-to-utf8                  |  8 ++++----
 42 files changed, 99 insertions(+), 102 deletions(-)

http://github.com/horde/horde/commit/c9b4f5304f134508cfa94ef2b42b834e5193acf4




More information about the commits mailing list