[commits] Horde branch master updated. 69f76037422214df5aa46ab6a79fc2a009d9459f

Jan Schneider jan at horde.org
Thu Dec 22 13:20:23 UTC 2016


The branch "master" has been updated.
The following is a summary of the commits.

from: c20d2261eb34f97d9308f912702adfae96226b2b

bc8046b Use horde-table.
8980c7b Must not unset $baseid.
335bf8a This must explicitly be an empty string.
69f7603 Started getting Vilma working again.

Summary: http://github.com/horde/horde/compare/c20d2261eb34f97d9308f912702adfae96226b2b...69f76037422214df5aa46ab6a79fc2a009d9459f

-----------------------------------------------------------------------

commit bc8046b222a623154721a28b07e6e15179e9c0e1
Author: Jan Schneider <jan at horde.org>
Date:   Mon Dec 19 12:49:43 2016 +0100

    Use horde-table.

 vilma/templates/domains/index.html  | 2 +-
 vilma/templates/users/index.html    | 2 +-
 vilma/templates/virtuals/index.html | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

http://github.com/horde/horde/commit/bc8046b222a623154721a28b07e6e15179e9c0e1

-----------------------------------------------------------------------

commit 8980c7b7bcee16ec958277668b9137b2ab83674e
Author: Jan Schneider <jan at horde.org>
Date:   Thu Dec 22 13:44:59 2016 +0100

    Must not unset $baseid.
    
    Unsetting will trigger __get() on future access because it removes the property. Setting to null is the equivalent to having an empty property.
    
    Also fix the warning message.

 kronolith/lib/Event.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

http://github.com/horde/horde/commit/8980c7b7bcee16ec958277668b9137b2ab83674e

-----------------------------------------------------------------------

commit 335bf8a7f6a3b62ccb1d7fb2cf7a47cb8205d9f9
Author: Jan Schneider <jan at horde.org>
Date:   Thu Dec 22 14:17:46 2016 +0100

    This must explicitly be an empty string.
    
    If we just unset the property (the idea was to rely on the default value of that column being an empty string), it won't work when updating the event, where we individually SET the property values.
    The old behavior resulted in event with exceptionoriginaldate being empty while the baseid was still set, crashing Kronolith in later occurences.

 kronolith/lib/Event/Sql.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

http://github.com/horde/horde/commit/335bf8a7f6a3b62ccb1d7fb2cf7a47cb8205d9f9

-----------------------------------------------------------------------

commit 69f76037422214df5aa46ab6a79fc2a009d9459f
Author: Jan Schneider <jan at horde.org>
Date:   Thu Dec 22 14:19:09 2016 +0100

    Started getting Vilma working again.
    
    Turned out to take to long to be billable, so this is WIP.

 vilma/domains/index.php                 | 23 ++++++------
 vilma/lib/Application.php               | 31 ++++++++++++-----
 vilma/lib/Driver/Sql.php                |  8 ++++-
 vilma/lib/Form/EditUser.php             |  2 +-
 vilma/package.xml                       | 16 ++++-----
 vilma/templates/domains/index.html      | 31 -----------------
 vilma/templates/domains/index.html.php  | 26 ++++++++++++++
 vilma/templates/users/index.html        | 62 ---------------------------------
 vilma/templates/users/index.html.php    | 57 ++++++++++++++++++++++++++++++
 vilma/templates/virtuals/index.html     | 32 -----------------
 vilma/templates/virtuals/index.html.php | 32 +++++++++++++++++
 vilma/users/edit.php                    | 13 ++++---
 vilma/users/index.php                   | 26 ++++++--------
 13 files changed, 183 insertions(+), 176 deletions(-)
 delete mode 100644 vilma/templates/domains/index.html
 create mode 100644 vilma/templates/domains/index.html.php
 delete mode 100644 vilma/templates/users/index.html
 create mode 100644 vilma/templates/users/index.html.php
 delete mode 100644 vilma/templates/virtuals/index.html
 create mode 100644 vilma/templates/virtuals/index.html.php

http://github.com/horde/horde/commit/69f76037422214df5aa46ab6a79fc2a009d9459f




More information about the commits mailing list