[commits] Horde branch master updated. a3daee45ba73e472139416e1dce8f33d56b692e1

[Jan Schneider]

The branch "master" has been updated.
The following is a summary of the commits.

from: b754ca323b06f94892b20e285a04cfceaac57b2c

a3daee4 Load the correct Math_BigInteger.

Summary: http://github.com/horde/horde/compare/b754ca323b06f94892b20e285a04cfceaac57b2c...a3daee45ba73e472139416e1dce8f33d56b692e1

-----------------------------------------------------------------------

commit a3daee45ba73e472139416e1dce8f33d56b692e1
Author: Jan Schneider <jan at horde.org>
Date:   Thu Jan 7 15:13:58 2016 +0100

    Load the correct Math_BigInteger.
    
    This is obviously a horrible duct tape just to make the framework test suite
    run. The general problem is that a class name of Math_BigInteger resolves to
    phpseclib's Math\BigInteger too, because the composer autoloader tries PSR-0
    autoloading if cannot find a class. As soon as the composer autoloader is
    executed before Horde's, Math_BigInteger will resolve to phpseclib where it
    cannot find the correct class name though. This will happen in real code, as
    soon as Horde_Mapi is used together with Horde_Pgp.
    
    In the long run this can only be solved by either distributing phpseclib as a
    separate package that both Horde_Pgp and Horde_Mapi can depend on, and rewrite
    Horde_Mapi to use that Math\BigInteger implementation. Or to switch the
    complete installation method of Horde to Composer. But then we cannot patch
    openpgp-php to properly work with Horde_Pgp. Welcome to the world of Composer
    dependencies in a more then trivial-size project.

 framework/Mapi/package.xml                  |    6 ++++--
 framework/Mapi/test/Horde/Mapi/Autoload.php |   15 +++++++++++++++
 2 files changed, 19 insertions(+), 2 deletions(-)
 create mode 100644 framework/Mapi/test/Horde/Mapi/Autoload.php

http://github.com/horde/horde/commit/a3daee45ba73e472139416e1dce8f33d56b692e1