[commits] Horde branch master updated. d01524cad8b115fad01d47cf62d97d6eaba66d51

[Jan Schneider]

The branch "master" has been updated.
The following is a summary of the commits.

from: d61f2e214e58e3160f1798522735d7ac6a52dedc

ca7fea4 Fix undefined notices and correctly return number of errors.
566af96 Don't detect dead code recursively.
f832b22 Remove metrics that aren't supported by PHPLOC.
79d8a79 Remove unused variables.
29c686f [jan] Don't exit after running phpunit tests.
5601185 Remove unused variable.
4cb28ff This will never work.
b3a7493 This wouldn't have worked either.
d01524c Wow, this actually DID work!

Summary: http://github.com/horde/horde/compare/d61f2e214e58e3160f1798522735d7ac6a52dedc...d01524cad8b115fad01d47cf62d97d6eaba66d51

-----------------------------------------------------------------------

commit ca7fea460ab8e2c332c5643ddbd6469600f467ac
Author: Jan Schneider <jan at horde.org>
Date:   Fri Apr 7 11:10:56 2017 +0200

    Fix undefined notices and correctly return number of errors.

 components/lib/Components/Qc/Task/Cs.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

http://github.com/horde/horde/commit/ca7fea460ab8e2c332c5643ddbd6469600f467ac

-----------------------------------------------------------------------

commit 566af96c872c9767847372387f8584c56202ac6d
Author: Jan Schneider <jan at horde.org>
Date:   Fri Apr 7 11:11:44 2017 +0200

    Don't detect dead code recursively.
    
    This is just confusing and misleading most of the time.

 components/lib/Components/Qc/Task/Dcd.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

http://github.com/horde/horde/commit/566af96c872c9767847372387f8584c56202ac6d

-----------------------------------------------------------------------

commit f832b22ed39a2e2208a910266785e1cdc89eb926
Author: Jan Schneider <jan at horde.org>
Date:   Fri Apr 7 11:12:16 2017 +0200

    Remove metrics that aren't supported by PHPLOC.

 components/lib/Components/Qc/Task/Loc.php | 6 ------
 1 file changed, 6 deletions(-)

http://github.com/horde/horde/commit/f832b22ed39a2e2208a910266785e1cdc89eb926

-----------------------------------------------------------------------

commit 79d8a79ee354d19a45deef14fec4cc9d3b639dfa
Author: Jan Schneider <jan at horde.org>
Date:   Fri Apr 7 11:12:42 2017 +0200

    Remove unused variables.

 framework/Reflection/lib/Horde/Reflection.php      | 3 +--
 framework/Reflection/lib/Horde/Reflection/Wiki.php | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

http://github.com/horde/horde/commit/79d8a79ee354d19a45deef14fec4cc9d3b639dfa

-----------------------------------------------------------------------

commit 29c686f32e48f7986c5d45e625c1b5a0ff7b7efb
Author: Jan Schneider <jan at horde.org>
Date:   Fri Apr 7 11:51:00 2017 +0200

    [jan] Don't exit after running phpunit tests.

 framework/Test/lib/Horde/Test/AllTests.php | 3 ++-
 framework/Test/package.xml                 | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

http://github.com/horde/horde/commit/29c686f32e48f7986c5d45e625c1b5a0ff7b7efb

-----------------------------------------------------------------------

commit 560118529a8e92b4fa85a51eeda2746c9e063737
Author: Jan Schneider <jan at horde.org>
Date:   Fri Apr 7 11:51:49 2017 +0200

    Remove unused variable.

 framework/Refactor/lib/Horde/Refactor/Rule/FileLevelDocBlock.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

http://github.com/horde/horde/commit/560118529a8e92b4fa85a51eeda2746c9e063737

-----------------------------------------------------------------------

commit 4cb28fff451b6cf97a2121d1e9efee74f8a037c9
Author: Jan Schneider <jan at horde.org>
Date:   Fri Apr 7 11:57:48 2017 +0200

    This will never work.
    
    Looks like it isn't used anyway.

 framework/Pear/lib/Horde/Pear/Package/Xml/Directory.php | 16 ----------------
 1 file changed, 16 deletions(-)

http://github.com/horde/horde/commit/4cb28fff451b6cf97a2121d1e9efee74f8a037c9

-----------------------------------------------------------------------

commit b3a7493318d402d3d37a5c1c65fd3eac0d970afa
Author: Jan Schneider <jan at horde.org>
Date:   Fri Apr 7 11:59:13 2017 +0200

    This wouldn't have worked either.
    
    But at least it looks important enough to not being removed completely.

 framework/Pear/lib/Horde/Pear/Package/Xml/Element/Directory.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

http://github.com/horde/horde/commit/b3a7493318d402d3d37a5c1c65fd3eac0d970afa

-----------------------------------------------------------------------

commit d01524cad8b115fad01d47cf62d97d6eaba66d51
Author: Jan Schneider <jan at horde.org>
Date:   Fri Apr 7 12:03:23 2017 +0200

    Wow, this actually DID work!
    
    I still don't have an idea, how. But revert the change and fix the access level instead.

 framework/Pear/lib/Horde/Pear/Package/Xml/Directory.php | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

http://github.com/horde/horde/commit/d01524cad8b115fad01d47cf62d97d6eaba66d51