[commits] Controller branch FRAMEWORK_5_2 updated. df4ab749f83a74be266bbb809147006d6c2d7771

Michael J. Rubinsky mrubinsk at horde.org
Wed Jul 4 17:30:55 UTC 2018


The branch "FRAMEWORK_5_2" has been updated.
The following is a summary of the commits.

from: 7d9a0f7fa6c6ab1cd1a5eb9a60f98a4717bd3580

4aac24b Add Request Body Stream to interface
e4a9a09 getRequestBody for null request
47f0a48 Mock getRequestBody
5ca9ce4 Get the post/put data if it is not form-encoded
ac72afa syntax
ffde2f8 [mjr] Add Request Body Stream to interface (PR #1, Ralf Lang <lang at b1-systems.de>).
df4ab74 [mjr] Add Request Body Stream to interface (PR #1, Ralf Lang <lang at b1-systems.de>).

Summary: https://github.com/horde/Controller/compare/7d9a0f7fa6c6...df4ab749f83a

-----------------------------------------------------------------------

commit 4aac24b8d5ec92d81553f076fd264fa672ac0e01
Author: Ralf Lang <lang at b1-systems.de>
Date:   Wed, 04 Jul 2018 13:26:45 -0400

Add Request Body Stream to interface

I noticed Horde_Controller currently lacks any access to the body of a http request like post or put, unless it's form-encoded. In this case, getPostVars works well
For the REST usecase, I would want to post/put a json object string containing details.

Another use case would be handling some bulk upload like a file (owncloudish) or a media stream.

For the REST use case, just slurping stdin and returning it as a string would be sufficient.
For the latter, it would be more convenient to expose the stream resource - both memory and performance wise.
Horde_Stream has a __toString() to implicitly return a string where one is expected.

 M lib/Horde/Controller/Request.php

https://github.com/horde/Controller/commit/4aac24b8d5ec92d81553f076fd264fa672ac0e01

-----------------------------------------------------------------------

commit e4a9a096598156cc9a591203f64584c7e4df9441
Author: Ralf Lang <lang at b1-systems.de>
Date:   Wed, 04 Jul 2018 13:26:57 -0400

getRequestBody for null request

 M lib/Horde/Controller/Request/Null.php

https://github.com/horde/Controller/commit/e4a9a096598156cc9a591203f64584c7e4df9441

-----------------------------------------------------------------------

commit 47f0a48f861f3596a40fd7b1361bf9c5ee77e4d9
Author: Ralf Lang <lang at b1-systems.de>
Date:   Wed, 04 Jul 2018 13:27:07 -0400

Mock getRequestBody

 M lib/Horde/Controller/Request/Mock.php

https://github.com/horde/Controller/commit/47f0a48f861f3596a40fd7b1361bf9c5ee77e4d9

-----------------------------------------------------------------------

commit 5ca9ce49af366089074de4471f132fce1172ef52
Author: Ralf Lang <lang at b1-systems.de>
Date:   Wed, 04 Jul 2018 13:27:16 -0400

Get the post/put data if it is not form-encoded

 M lib/Horde/Controller/Request/Http.php

https://github.com/horde/Controller/commit/5ca9ce49af366089074de4471f132fce1172ef52

-----------------------------------------------------------------------

commit ac72afab16e66b5a6338969b218a1f3453948fa1
Author: Ralf Lang <lang at b1-systems.de>
Date:   Wed, 04 Jul 2018 13:27:26 -0400

syntax

 M lib/Horde/Controller/Request/Mock.php

https://github.com/horde/Controller/commit/ac72afab16e66b5a6338969b218a1f3453948fa1

-----------------------------------------------------------------------

commit ffde2f85ea9d9864dfe4787e32f49164f6136183
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Wed, 04 Jul 2018 13:29:44 -0400

[mjr] Add Request Body Stream to interface (PR #1, Ralf Lang <lang at b1-systems.de>).

 M doc/Horde/Controller/changelog.yml

https://github.com/horde/Controller/commit/ffde2f85ea9d9864dfe4787e32f49164f6136183

-----------------------------------------------------------------------

commit df4ab749f83a74be266bbb809147006d6c2d7771
Author: Michael J Rubinsky <mrubinsk at horde.org>
Date:   Wed, 04 Jul 2018 13:29:44 -0400

[mjr] Add Request Body Stream to interface (PR #1, Ralf Lang <lang at b1-systems.de>).

 M doc/Horde/Controller/CHANGES
 M package.xml

https://github.com/horde/Controller/commit/df4ab749f83a74be266bbb809147006d6c2d7771


More information about the commits mailing list