[commits] Controller branch master updated. 3c8e56fdbfc7d95c3b577c962ac2d4082eff0d85

Michael J. Rubinsky mrubinsk at horde.org
Sun Jun 24 02:41:12 UTC 2018


The branch "master" has been updated.
The following is a summary of the commits.

from: e24baf15da2ad7118c95dcd08b2f48b8714474bd

b5feaf1 Add Request Body Stream to interface
20d6549 getRequestBody for null request
bb56ffe Mock getRequestBody
de38e53 Get the post/put data if it is not form-encoded
a1796cd syntax
3c8e56f Merge pull request #1 from ralflang/controller-rest-request-body

Summary: https://github.com/horde/Controller/compare/e24baf15da2a...3c8e56fdbfc7

-----------------------------------------------------------------------

commit b5feaf17b2336b6f16c67fea27975bc21b023010
Author: Ralf Lang <lang at b1-systems.de>
Date:   Sat, 17 Mar 2018 23:44:00 +0100

Add Request Body Stream to interface

I noticed Horde_Controller currently lacks any access to the body of a http request like post or put, unless it's form-encoded. In this case, getPostVars works well
For the REST usecase, I would want to post/put a json object string containing details.

Another use case would be handling some bulk upload like a file (owncloudish) or a media stream.

For the REST use case, just slurping stdin and returning it as a string would be sufficient.
For the latter, it would be more convenient to expose the stream resource - both memory and performance wise.
Horde_Stream has a __toString() to implicitly return a string where one is expected.

 M lib/Horde/Controller/Request.php

https://github.com/horde/Controller/commit/b5feaf17b2336b6f16c67fea27975bc21b023010

-----------------------------------------------------------------------

commit 20d65491b4b9b559ca0ac1f88ade5a698fe95849
Author: Ralf Lang <lang at b1-systems.de>
Date:   Sat, 17 Mar 2018 23:47:51 +0100

getRequestBody for null request

 M lib/Horde/Controller/Request/Null.php

https://github.com/horde/Controller/commit/20d65491b4b9b559ca0ac1f88ade5a698fe95849

-----------------------------------------------------------------------

commit bb56ffeef8227f8cf9d50de1e113b03823d82882
Author: Ralf Lang <lang at b1-systems.de>
Date:   Sat, 17 Mar 2018 23:52:54 +0100

Mock getRequestBody

 M lib/Horde/Controller/Request/Mock.php

https://github.com/horde/Controller/commit/bb56ffeef8227f8cf9d50de1e113b03823d82882

-----------------------------------------------------------------------

commit de38e53601ec5501f7db2c385921be93327bd2b1
Author: Ralf Lang <lang at b1-systems.de>
Date:   Sat, 17 Mar 2018 23:56:38 +0100

Get the post/put data if it is not form-encoded

 M lib/Horde/Controller/Request/Http.php

https://github.com/horde/Controller/commit/de38e53601ec5501f7db2c385921be93327bd2b1

-----------------------------------------------------------------------

commit a1796cdae022af2b06ade84a5e38639f7e79c70c
Author: Ralf Lang <lang at b1-systems.de>
Date:   Sun, 18 Mar 2018 18:20:59 +0100

syntax

 M lib/Horde/Controller/Request/Mock.php

https://github.com/horde/Controller/commit/a1796cdae022af2b06ade84a5e38639f7e79c70c

-----------------------------------------------------------------------

commit 3c8e56fdbfc7d95c3b577c962ac2d4082eff0d85
Author: Michael J Rubinsky <mike at theupstairsroom.com>
Date:   Sat, 23 Jun 2018 22:41:11 -0400

Merge pull request #1 from ralflang/controller-rest-request-body

Controller rest request body

 M lib/Horde/Controller/Request.php
 M lib/Horde/Controller/Request/Http.php
 M lib/Horde/Controller/Request/Mock.php
 M lib/Horde/Controller/Request/Null.php

https://github.com/horde/Controller/commit/3c8e56fdbfc7d95c3b577c962ac2d4082eff0d85


More information about the commits mailing list