[commits] Imap_Client branch FRAMEWORK_5_2 updated. cfab3d1633903d1c47e244741c44857e39b6a41d

[jan at horde.org]

The branch "FRAMEWORK_5_2" has been updated.
The following is a summary of the commits.

from: b385693831187718682493e41a192f9161797d00

4721ced Fix continue statement within switch/case keeping original behavior
e65e3d5 This was probably the intention, and the tokenizer test still passes.
b553b75 [jan] Fix warning with PHP 7.3 (Eloy Lafuente (stronk7) <stronk7 at moodle.org>, PR 6).
cfab3d1 [jan] Fix warning with PHP 7.3 (Eloy Lafuente (stronk7) <stronk7 at moodle.org>, PR 6).

Summary: https://github.com/horde/Imap_Client/compare/b38569383118...cfab3d163390

-----------------------------------------------------------------------

commit 4721cedd9744a0173ceab6a20c5647b550157c43
Author: Eloy Lafuente (stronk7) <stronk7 at moodle.org>
Date:   Fri, 26 Oct 2018 22:38:13 +0200

Fix continue statement within switch/case keeping original behavior

continue statements within switch/case statements always have
behaved like break (ending the switch). Only exception is when
they are within a loop and we may want to use 'continue 2;'
instead (to jump to next iteration).

PHP7.3 has added a PHPWarning for all this switch/case/continue
uses (https://wiki.php.net/rfc/continue_on_switch_deprecation) so
this just changes is to the BC equivalent break. As far as there
isn't remaining code in the loop after the switch, it is 100%
the same than a continue 2.

 M lib/Horde/Imap/Client/Tokenize.php

https://github.com/horde/Imap_Client/commit/4721cedd9744a0173ceab6a20c5647b550157c43

-----------------------------------------------------------------------

commit e65e3d5fb31da6e7de99c21331be7de786792b4f
Author: Jan Schneider <jan at horde.org>
Date:   Fri, 26 Oct 2018 22:38:13 +0200

This was probably the intention, and the tokenizer test still passes.

 M lib/Horde/Imap/Client/Tokenize.php

https://github.com/horde/Imap_Client/commit/e65e3d5fb31da6e7de99c21331be7de786792b4f

-----------------------------------------------------------------------

commit b553b751c7f53bcef0d2b2fddc891a8350fd8206
Author: Jan Schneider <jan at horde.org>
Date:   Fri, 26 Oct 2018 22:48:37 +0200

[jan] Fix warning with PHP 7.3 (Eloy Lafuente (stronk7) <stronk7 at moodle.org>, PR 6).

 M doc/Horde/Imap/Client/changelog.yml

https://github.com/horde/Imap_Client/commit/b553b751c7f53bcef0d2b2fddc891a8350fd8206

-----------------------------------------------------------------------

commit cfab3d1633903d1c47e244741c44857e39b6a41d
Author: Jan Schneider <jan at horde.org>
Date:   Fri, 26 Oct 2018 22:48:56 +0200

[jan] Fix warning with PHP 7.3 (Eloy Lafuente (stronk7) <stronk7 at moodle.org>, PR 6).

 M doc/Horde/Imap/Client/CHANGES
 M package.xml

https://github.com/horde/Imap_Client/commit/cfab3d1633903d1c47e244741c44857e39b6a41d