[commits] [Wiki] changed: Doc/Dev/FormPackage

[Ralf Lang (B1 Systems GmbH)]

rlang  Wed, 10 Mar 2021 16:07:23 +0000

Modified page: https://wiki.horde.org/Doc/Dev/FormPackage
New Revision:  16
Change log:  Document some structural issues to address.

@@ -218,4 +218,42 @@
      print_r($info);
      echo '</pre>';
  }
  </code>
+
+
+++ Horde_Form design issues
+
++++ Constructors
+
+some PHP 4 constructors are left
+
+Fix:
+
++++ singletons
+
+Construct & pass dependencies. There should be no reason for a singleton.
+Fix:
+
++++ inheritance + method signature mismatch
+-
+Fix:
+
++++ inconsistent class names
+- lowercase field types
+Fix:
+
++++ Internally uses the Horde:: shortcuts (separate package, hard to test)
+Fix:
+
++++ Multiple classes in one file
+- Most field types are attached to the Horde_Form_Type base package.
+Fix:
+
++++ Extensive use of reference signatures
+Fix:
+
++++ hard-coupled javascript
+- parts rely on scriptaculous and hence prototypjs
+- parts rely on redboxjs
+Fix:
+