[commits] [Wiki] changed: Doc/Dev/FormPackage

[Ralf Lang (B1 Systems GmbH)]

rlang  Wed, 10 Mar 2021 17:32:01 +0000

Modified page: https://wiki.horde.org/Doc/Dev/FormPackage
New Revision:  20
Change log:  fixes

@@ -234,29 +234,37 @@
  Construct & pass dependencies. There should be no reason for a singleton.
  Fix:

  +++ inheritance + method signature mismatch
-- 
+- Form_Type's init() pseudo constructor
+
  Fix:
+- Use proper constructors
+- Provide a builder with a fluent interface?

  +++ inconsistent class names
  - lowercase field types
-Fix:
+Fix:
+- Namespaces and structured class names

  +++ Internally uses the Horde:: shortcuts (separate package, hard to test)
-Fix:
+Fix:

  +++ Multiple classes in one file
  - Most field types are attached to the Horde_Form_Type base package.
  Fix:
-
-+++ Extensive use of reference signatures
-Fix:
+
+- one class per file
+
++++ Extensive use of reference signatures
+Fix: Check if we really need these.

  +++ hard-coupled javascript
  - parts rely on scriptaculous and hence prototypjs
  - parts rely on redboxjs
  Fix:
+
+- check if we can factor out the JS

  +++ Uses globals
  - registry
  - injector