commit: imp message.php view.php imp/docs CHANGES imp/lib IMP.php

[chuck@horde.org]

chuck       2001/01/03 16:09:28 PST

  Modified files:
    .                    message.php view.php 
    docs                 CHANGES 
    lib                  IMP.php 
  Log:
  New attachment downloading code. This changes a couple of things around,
  including:
  
  - caching $mime objects in the session with the new SessionCache:: class so
  that we don't have to pass them in the URL and don't have to re-parse the
  whole message in most cases. We do fall back on re-calling
  imap_fetchstructure if the object isn't in the cache.
  
  - don't send content-disposition: attachment; use inline instead. This is
  completely counter-intuitive and goes against even microsoft's
  documentation, but content-disposition: attachment was causing IE5 to do
  EXTREMELY odd things (consistently saving the contents of HTTP_REFERER
  instead of the attachment).
  
  - don't quote filenames in the content-disposition header; a note in MSDN
  says specifically not to, so I'll give it a shot. It hasn't broken anything
  so far.
  
  - put the path_info part of the url (i.e. view.php/<filename>?args_here)
  before the arguments. I'm not sure how this ever worked before.
  
  PLEASE TEST THIS ON EVERYTHING YOU HAVE. SSL, no SSL, etc...
  
  Revision  Changes    Path
  2.182     +3 -3      imp/message.php
  2.80      +21 -16    imp/view.php
  1.253     +2 -0      imp/docs/CHANGES
  1.112     +11 -8     imp/lib/IMP.php