[cvs] commit: agora forums.php manageforum.php agora/lib Agora.php ManageForum.php Menu.php base.php constants.php giapeto/lib Giapeto.php base.php constants.php ingo/lib Ingo.php base.php...

Mon Mar 3 11:10:21 PST 2003

chuck       2003/03/03 11:10:20 PST

  Modified files:
    .                    forums.php manageforum.php 
    lib                  Agora.php ManageForum.php Menu.php 
                         base.php 
    lib                  Giapeto.php base.php 
    lib                  Ingo.php base.php 
    lib                  Jonah.php base.php 
    lib                  Driver.php Juno.php base.php 
    config               prefs.php.dist 
    lib                  Comic.php Image.php Klutz.php 
    lib/Comic            bysize.php direct.php search.php 
    lib                  Midas.php 
    config               prefs.php.dist 
    lib                  MIMP.php 
    lib                  SAM.php base.php 
    lib                  Driver.php Scry.php base.php 
    config               prefs.php.dist 
    lib                  Trean.php 
  Removed files:
    lib                  constants.php 
    lib                  constants.php 
    lib                  constants.php 
    lib                  constants.php 
    lib                  constants.php 
    lib                  constants.php 
    lib                  constants.php 
    lib                  constants.php 
    lib                  constants.php 
    lib                  constants.php 
    lib                  constants.php 
  Log:
  Nuke a lot of constants.php files.

  Specific Reason: constants should be defined in the application's base
  class file UNLESS constants are needed in one of the configuration
  files (the case for all those remaining). Only then should you break
  things out to a seperate file (and even then, we may want to just
  include the app's library file).

  General Reason: Including files is *very* expensive. Short files are
  pointless if we can avoid them; it's much cheaper to have slightly
  longer files than multiple short ones (especially when we're going to
  include all the short files anyways).

  Revision  Changes    Path
  1.11      +3 -3      agora/forums.php
  1.29      +27 -1     agora/lib/Agora.php
  1.5       +0 -32     agora/lib/Attic/constants.php (dead)
  1.4       +4 -4      agora/lib/ManageForum.php
  1.9       +1 -26     agora/lib/Menu.php
  1.11      +2 -3      agora/lib/base.php
  1.8       +3 -5      agora/manageforum.php
  1.16      +0 -31     giapeto/lib/Attic/constants.php (dead)
  1.128     +28 -3     giapeto/lib/Giapeto.php
  1.30      +2 -3      giapeto/lib/base.php
  1.4       +0 -32     ingo/lib/Attic/constants.php (dead)
  1.20      +128 -83   ingo/lib/Ingo.php
  1.12      +3 -6      ingo/lib/base.php
  1.3       +0 -18     jonah/lib/Attic/constants.php (dead)
  1.42      +19 -2     jonah/lib/Jonah.php
  1.30      +1 -4      jonah/lib/base.php
  1.4       +0 -15     juno/lib/Attic/constants.php (dead)
  1.10      +2 -5      juno/lib/Driver.php
  1.6       +17 -5     juno/lib/Juno.php
  1.13      +1 -4      juno/lib/base.php
  1.6       +1 -4      klutz/config/prefs.php.dist
  1.4       +0 -21     klutz/lib/Attic/constants.php (dead)
  1.22      +2 -9      klutz/lib/Comic.php
  1.12      +24 -25    klutz/lib/Comic/bysize.php
  1.13      +4 -6      klutz/lib/Comic/direct.php
  1.17      +5 -7      klutz/lib/Comic/search.php
  1.9       +19 -11    klutz/lib/Image.php
  1.19      +19 -4     klutz/lib/Klutz.php
  1.9       +0 -56     midas/lib/Attic/constants.php (dead)
  1.26      +49 -2     midas/lib/Midas.php
  1.8       +1 -4      mimp/config/prefs.php.dist
  1.2       +0 -77     mimp/lib/Attic/constants.php (dead)
  1.18      +71 -3     mimp/lib/MIMP.php
  1.5       +0 -14     sam/lib/Attic/constants.php (dead)
  1.11      +9 -9      sam/lib/SAM.php
  1.12      +2 -1      sam/lib/base.php
  1.3       +0 -33     scry/lib/Attic/constants.php (dead)
  1.6       +4 -4      scry/lib/Driver.php
  1.10      +20 -2     scry/lib/Scry.php
  1.7       +2 -3      scry/lib/base.php
  1.5       +1 -4      trean/config/prefs.php.dist
  1.7       +0 -18     trean/lib/Attic/constants.php (dead)
  1.11      +11 -3     trean/lib/Trean.php

  Chora Links:
  http://cvs.horde.org/diff.php/agora/forums.php?r1=1.10&r2=1.11&ty=u
  http://cvs.horde.org/diff.php/agora/lib/Agora.php?r1=1.28&r2=1.29&ty=u
  http://cvs.horde.org/co.php/agora/lib/Attic/constants.php?r=1.4
  http://cvs.horde.org/diff.php/agora/lib/ManageForum.php?r1=1.3&r2=1.4&ty=u
  http://cvs.horde.org/diff.php/agora/lib/Menu.php?r1=1.8&r2=1.9&ty=u
  http://cvs.horde.org/diff.php/agora/lib/base.php?r1=1.10&r2=1.11&ty=u
  http://cvs.horde.org/diff.php/agora/manageforum.php?r1=1.7&r2=1.8&ty=u
  http://cvs.horde.org/co.php/giapeto/lib/Attic/constants.php?r=1.15
  http://cvs.horde.org/diff.php/giapeto/lib/Giapeto.php?r1=1.127&r2=1.128&ty=u
  http://cvs.horde.org/diff.php/giapeto/lib/base.php?r1=1.29&r2=1.30&ty=u
  http://cvs.horde.org/co.php/ingo/lib/Attic/constants.php?r=1.3
  http://cvs.horde.org/diff.php/ingo/lib/Ingo.php?r1=1.19&r2=1.20&ty=u
  http://cvs.horde.org/diff.php/ingo/lib/base.php?r1=1.11&r2=1.12&ty=u
  http://cvs.horde.org/co.php/jonah/lib/Attic/constants.php?r=1.2
  http://cvs.horde.org/diff.php/jonah/lib/Jonah.php?r1=1.41&r2=1.42&ty=u
  http://cvs.horde.org/diff.php/jonah/lib/base.php?r1=1.29&r2=1.30&ty=u
  http://cvs.horde.org/co.php/juno/lib/Attic/constants.php?r=1.3
  http://cvs.horde.org/diff.php/juno/lib/Driver.php?r1=1.9&r2=1.10&ty=u
  http://cvs.horde.org/diff.php/juno/lib/Juno.php?r1=1.5&r2=1.6&ty=u
  http://cvs.horde.org/diff.php/juno/lib/base.php?r1=1.12&r2=1.13&ty=u
  http://cvs.horde.org/diff.php/klutz/config/prefs.php.dist?r1=1.5&r2=1.6&ty=u
  http://cvs.horde.org/co.php/klutz/lib/Attic/constants.php?r=1.3
  http://cvs.horde.org/diff.php/klutz/lib/Comic.php?r1=1.21&r2=1.22&ty=u
  http://cvs.horde.org/diff.php/klutz/lib/Comic/bysize.php?r1=1.11&r2=1.12&ty=u
  http://cvs.horde.org/diff.php/klutz/lib/Comic/direct.php?r1=1.12&r2=1.13&ty=u
  http://cvs.horde.org/diff.php/klutz/lib/Comic/search.php?r1=1.16&r2=1.17&ty=u
  http://cvs.horde.org/diff.php/klutz/lib/Image.php?r1=1.8&r2=1.9&ty=u
  http://cvs.horde.org/diff.php/klutz/lib/Klutz.php?r1=1.18&r2=1.19&ty=u
  http://cvs.horde.org/co.php/midas/lib/Attic/constants.php?r=1.8
  http://cvs.horde.org/diff.php/midas/lib/Midas.php?r1=1.25&r2=1.26&ty=u
  http://cvs.horde.org/diff.php/mimp/config/prefs.php.dist?r1=1.7&r2=1.8&ty=u
  http://cvs.horde.org/co.php/mimp/lib/Attic/constants.php?r=1.1
  http://cvs.horde.org/diff.php/mimp/lib/MIMP.php?r1=1.17&r2=1.18&ty=u
  http://cvs.horde.org/co.php/sam/lib/Attic/constants.php?r=1.4
  http://cvs.horde.org/diff.php/sam/lib/SAM.php?r1=1.10&r2=1.11&ty=u
  http://cvs.horde.org/diff.php/sam/lib/base.php?r1=1.11&r2=1.12&ty=u
  http://cvs.horde.org/co.php/scry/lib/Attic/constants.php?r=1.2
  http://cvs.horde.org/diff.php/scry/lib/Driver.php?r1=1.5&r2=1.6&ty=u
  http://cvs.horde.org/diff.php/scry/lib/Scry.php?r1=1.9&r2=1.10&ty=u
  http://cvs.horde.org/diff.php/scry/lib/base.php?r1=1.6&r2=1.7&ty=u
  http://cvs.horde.org/diff.php/trean/config/prefs.php.dist?r1=1.4&r2=1.5&ty=u
  http://cvs.horde.org/co.php/trean/lib/Attic/constants.php?r=1.6
  http://cvs.horde.org/diff.php/trean/lib/Trean.php?r1=1.10&r2=1.11&ty=u