[cvs] commit: horde/lib Horde.php horde/config nls.php.dist

Eric Rostetter eric.rostetter at physics.utexas.edu
Tue Apr 22 18:04:40 PDT 2003


ericr       2003/04/22 17:04:40 PDT

  Modified files:
    lib                  Horde.php 
    config               nls.php.dist 
  Log:
  First attempt to make access keys "work" with multibyte character sets
  
  * Define the max bytes for each character set we support in nls.php
  * If multibyte (max > 1) then append access key string to end in ()s
  
  This isn't optimal, as Horde::getAccessKey is handed the *translated*
  string and doesn't treat it properly as multibyte (it can't really), so
  the characters it picks for access keys are rather random (it increments
  through the multibyte string by one, picking up whatever ascii value
  happens to be in that byte).  I'm not sure how to fix that -- Suggestions
  welcome.
  
  At least now in my testing, it no longer breaks multibyte translations
  when access keys are on.  Feedback welcome.
  
  I've only defined the max bytes for the charsets as that is all I needed.
  If desired we could make this an array/structure with more info (e.g.
  min bytes as well as max bytes) but I'm not sure we have any use for
  such additional info.
  
  Revision  Changes    Path
  1.23      +20 -2     horde/config/nls.php.dist
  1.282     +24 -11    horde/lib/Horde.php

  Chora Links:
  http://cvs.horde.org/diff.php/horde/config/nls.php.dist?r1=1.22&r2=1.23&ty=u
  http://cvs.horde.org/diff.php/horde/lib/Horde.php?r1=1.281&r2=1.282&ty=u


More information about the cvs mailing list