[cvs] commit: imp mailbox.php imp/lib Mailbox.php Message.php

[Chuck Hagenbuch]

chuck       2003/06/16 06:56:54 PDT

  Modified files:
    .                    mailbox.php 
    lib                  Mailbox.php Message.php 
  Log:
  fix always copying messages in mailbox.php (instead of moving)
  
  - mailbox.php was calling IMP_Message::copy() with the wrong set of
  constants - IMP_MAILBOX_[MOVE|COPY] instead of IMP_MESSAGE_*.
  
  - in lib/Message.php and lib/Mailbox.php, MOVE and COPY were defined
  in opposite orders, so the action was flipped instead of mapping
  correctly, because we used the wrong constants.
  
  - so, now we define them in the same order, and we use the right
  constants, just to hit all possible bases.
  
  How bad a hit *is* define()? This is pretty confusing having 3 sets of
  constants around. If it's really bad, can we just move to string
  actions? Seems like that'd be easier to follow.
  
  Revision  Changes    Path
  1.42      +4 -4      imp/lib/Mailbox.php
  1.121     +3 -2      imp/lib/Message.php
  2.504     +2 -2      imp/mailbox.php

  Chora Links:
  http://cvs.horde.org/diff.php/imp/lib/Mailbox.php?r1=1.41&r2=1.42&ty=u
  http://cvs.horde.org/diff.php/imp/lib/Message.php?r1=1.120&r2=1.121&ty=u
  http://cvs.horde.org/diff.php/imp/mailbox.php?r1=2.503&r2=2.504&ty=u